René's URL Explorer Experiment


Title: [3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658) by pablogsal · Pull Request #16685 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658) by pablogsal · Pull Request #16685 · python/cpython

X Title: [3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658) by pablogsal · Pull Request #16685 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: bpo-38379: when a finalizer resurrects an object, nothing is actually collected in this run of gc. Change the stats to relect that truth.. (cherry picked from commit ecbf35f) Co-authored-by: Tim ...

X Description: bpo-38379: when a finalizer resurrects an object, nothing is actually collected in this run of gc. Change the stats to relect that truth.. (cherry picked from commit ecbf35f) Co-authored-by: Tim ...

Mail addresses
tim.peters@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/16685

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b8911853-1b67-14fe-645e-f48b8b23e5ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA42:1960E9:157F5D:1D1311:6A4D84FF
html-safe-nonce9011911706366351fe8e8f8cfc1cb02f56f0a1449c9ea9af02111922b3634741
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTQyOjE5NjBFOToxNTdGNUQ6MUQxMzExOjZBNEQ4NEZGIiwidmlzaXRvcl9pZCI6Ijc0NjA2ODc4MzM2NzU0MzMyMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacef1ccfba9a5e90d7b0f12d842642f04e2df102edfa925fe6064e0c563079435b
hovercard-subject-tagpull_request:326450586
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/16685/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/34f8bc3377db6dda919f8bf355cfdadab8a120ca1389dc43f5cd76d8d0bf75d0/python/cpython/pull/16685
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/34f8bc3377db6dda919f8bf355cfdadab8a120ca1389dc43f5cd76d8d0bf75d0/python/cpython/pull/16685
og:image:altbpo-38379: when a finalizer resurrects an object, nothing is actually collected in this run of gc. Change the stats to relect that truth.. (cherry picked from commit ecbf35f) Co-authored-by: Tim ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepablogsal
hostnamegithub.com
expected-hostnamegithub.com
Nonec6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6702a58b419a792226bd21ef0fb1bcb318bbcaa3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/16685#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16685
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16685
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/16685
Reloadhttps://github.com/python/cpython/pull/16685
Reloadhttps://github.com/python/cpython/pull/16685
Please reload this pagehttps://github.com/python/cpython/pull/16685
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/16685
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
pablogsal:backport-ecbf35f-3.7https://github.com/pablogsal/cpython/tree/backport-ecbf35f-3.7
Conversationhttps://github.com/python/cpython/pull/16685
Commits1 (1)https://github.com/python/cpython/pull/16685/commits
Checkshttps://github.com/python/cpython/pull/16685/checks
Files changedhttps://github.com/python/cpython/pull/16685/files
[3.7] bpo-38379: don't claim objects are collected when they aren't (GH-16658)https://github.com/python/cpython/pull/16685#top
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
pablogsal:backport-ecbf35f-3.7https://github.com/pablogsal/cpython/tree/backport-ecbf35f-3.7
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 9, 2019https://github.com/python/cpython/pull/16685#issue-504898359
Please reload this pagehttps://github.com/python/cpython/pull/16685
bpo-38379https://bugs.python.org/issue38379
ecbf35fhttps://github.com/python/cpython/commit/ecbf35f9335b0420cb8adfda6f299d6747a16515
https://bugs.python.org/issue38379https://bugs.python.org/issue38379
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/16685
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Oct 9, 2019https://github.com/python/cpython/pull/16685#event-2700522420
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 9, 2019 https://github.com/python/cpython/pull/16685#ref-pullrequest-504078773
bpo-38379: don't claim objects are collected when they aren't #16658 https://github.com/python/cpython/pull/16658
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 9, 2019https://github.com/python/cpython/pull/16685#event-2700522590
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 9, 2019 https://github.com/python/cpython/pull/16685#ref-pullrequest-504896058
[3.8] bpo-38379: don't claim objects are collected when they aren't (GH-16658) #16683 https://github.com/python/cpython/pull/16683
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
🤖 automerge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Arobot%3A%20automerge%22
Oct 9, 2019https://github.com/python/cpython/pull/16685#event-2700536267
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
tim-onehttps://github.com/tim-one
October 9, 2019 21:17https://github.com/python/cpython/pull/16685#event-2700537156
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 9, 2019https://github.com/python/cpython/pull/16685#event-2700539583
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 9, 2019https://github.com/python/cpython/pull/16685#issuecomment-540203822
Please reload this pagehttps://github.com/python/cpython/pull/16685
https://github.com/tim-one
tim-onehttps://github.com/tim-one
Oct 9, 2019 https://github.com/python/cpython/pull/16685#pullrequestreview-299705117
View reviewed changes https://github.com/python/cpython/pull/16685/files
tim-onehttps://github.com/tim-one
https://github.com/python/cpython/pull/16685#pullrequestreview-299705117
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/16685
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 9, 2019https://github.com/python/cpython/pull/16685#event-2700548108
https://github.com/tim-one
https://github.com/pablogsal
[3.7] bpo-38379: don't claim objects are collected when they aren't (https://github.com/python/cpython/pull/16685/commits/92fab6570965b608dc560296a73d67f67a83303c
p…https://github.com/python/cpython/pull/16658
92fab65https://github.com/python/cpython/pull/16685/commits/92fab6570965b608dc560296a73d67f67a83303c
…ythonGH-16658https://github.com/python/cpython/pull/16658
ecbf35fhttps://github.com/pablogsal/cpython/commit/ecbf35f9335b0420cb8adfda6f299d6747a16515
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
force-pushedhttps://github.com/python/cpython/compare/62da4ca5721d84b81682abcbfc1490c9d3fe25d2..92fab6570965b608dc560296a73d67f67a83303c
62da4cahttps://github.com/python/cpython/commit/62da4ca5721d84b81682abcbfc1490c9d3fe25d2
92fab65https://github.com/python/cpython/commit/92fab6570965b608dc560296a73d67f67a83303c
Compare https://github.com/python/cpython/compare/62da4ca5721d84b81682abcbfc1490c9d3fe25d2..92fab6570965b608dc560296a73d67f67a83303c
October 9, 2019 21:24https://github.com/python/cpython/pull/16685#event-2700557230
https://github.com/tim-one
tim-onehttps://github.com/tim-one
Oct 9, 2019https://github.com/python/cpython/pull/16685#issuecomment-540207194
Please reload this pagehttps://github.com/python/cpython/pull/16685
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Oct 9, 2019https://github.com/python/cpython/pull/16685#issuecomment-540207813
Please reload this pagehttps://github.com/python/cpython/pull/16685
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 9, 2019https://github.com/python/cpython/pull/16685#issuecomment-540213851
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/16685
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
a081e93https://github.com/python/cpython/commit/a081e931505f190b5ccdff9a781e59b3f13fcc31
Oct 9, 2019https://github.com/python/cpython/pull/16685#event-2700605422
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 9, 2019https://github.com/python/cpython/pull/16685#event-2700605500
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
October 9, 2019 21:43https://github.com/python/cpython/pull/16685#event-2700606519
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16685
https://github.com/tim-one
tim-one https://github.com/tim-one
https://github.com/python/cpython/pull/16685/files/62da4ca5721d84b81682abcbfc1490c9d3fe25d2
Please reload this pagehttps://github.com/python/cpython/pull/16685
https://github.com/pablogsal
https://github.com/tim-one
https://github.com/miss-islington
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.