René's URL Explorer Experiment


Title: gh-82565: Fix a possible assertion failure in _pickle by ZackerySpytz · Pull Request #16606 · python/cpython · GitHub

Open Graph Title: gh-82565: Fix a possible assertion failure in _pickle by ZackerySpytz · Pull Request #16606 · python/cpython

X Title: gh-82565: Fix a possible assertion failure in _pickle by ZackerySpytz · Pull Request #16606 · python/cpython

Description: In _Unpickler_SetInputStream(), _PyObject_LookupAttrId() is called three times in a row without any error handling. If an exception occurs during the first or second call, _PyObject_LookupAttrId() will be called with a live exception. https://bugs.python.org/issue38384 Issue: gh-82565

Open Graph Description: In _Unpickler_SetInputStream(), _PyObject_LookupAttrId() is called three times in a row without any error handling. If an exception occurs during the first or second call, _PyObject_LookupAttrId()...

X Description: In _Unpickler_SetInputStream(), _PyObject_LookupAttrId() is called three times in a row without any error handling. If an exception occurs during the first or second call, _PyObject_LookupAttrId()...

Opengraph URL: https://github.com/python/cpython/pull/16606

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f22b8026-9cfd-7a47-d690-94a955622bbf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF90:12E713:D6304:10C4FE:696B36A9
html-safe-nonce571887434df33c8e41d7b52c26ab21fa870d42707bcbf6665f6f889e7273e0be
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjkwOjEyRTcxMzpENjMwNDoxMEM0RkU6Njk2QjM2QTkiLCJ2aXNpdG9yX2lkIjoiMzQ3ODgxMDYzMTE5ODE2MDU1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2bb1ccb99b292378707152b3190d461f688e9d1ac1b06846f7060a3574f39d39
hovercard-subject-tagpull_request:325035131
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/16606/files
twitter:imagehttps://avatars.githubusercontent.com/u/25091963?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/25091963?s=400&v=4
og:image:altIn _Unpickler_SetInputStream(), _PyObject_LookupAttrId() is called three times in a row without any error handling. If an exception occurs during the first or second call, _PyObject_LookupAttrId()...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/16606/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16606%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16606%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/16606/files
Reloadhttps://github.com/python/cpython/pull/16606/files
Reloadhttps://github.com/python/cpython/pull/16606/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/16606/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/16606/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
ZackerySpytz:bpo-38384-pickle-asserthttps://github.com/ZackerySpytz/cpython/tree/bpo-38384-pickle-assert
Conversation 14 https://github.com/python/cpython/pull/16606
Commits 13 https://github.com/python/cpython/pull/16606/commits
Checks 0 https://github.com/python/cpython/pull/16606/checks
Files changed https://github.com/python/cpython/pull/16606/files
Please reload this pagehttps://github.com/python/cpython/pull/16606/files
gh-82565: Fix a possible assertion failure in _pickle https://github.com/python/cpython/pull/16606/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/16606/files
afdb094 bpo-38384: Fix a possible assertion failure in _pickle ZackerySpytz Oct 6, 2019 https://github.com/python/cpython/pull/16606/commits/afdb09406715f2685c75e93608d9740c22ba0ccf
0898bd6 Merge remote-tracking branch 'upstream/master' into bpo-38384-pickle-… ZackerySpytz Nov 22, 2019 https://github.com/python/cpython/pull/16606/commits/0898bd668cac11c2891238ef5cfb02159ce24ed8
b81c706 Add a test. ZackerySpytz Nov 22, 2019 https://github.com/python/cpython/pull/16606/commits/b81c706a59baeea2dc7ea761864dc1c234bddb12
d739b61 Merge branch 'main' into bpo-38384-pickle-assert serhiy-storchaka Oct 20, 2021 https://github.com/python/cpython/pull/16606/commits/d739b61a813c82a785f9c657f3fb0241b7f5162a
ccaeb97 Rewrite test. serhiy-storchaka Oct 20, 2021 https://github.com/python/cpython/pull/16606/commits/ccaeb979b87c15fc0d570217e60ea07397e9159c
bf18cec Add a NEWS entry and a test for pickler serhiy-storchaka Oct 20, 2021 https://github.com/python/cpython/pull/16606/commits/bf18cec625cc0f93e15bdc1ab8a437d6fc9489ee
6e24487 Modify a test and the news entry (which weren't written by me). ZackerySpytz Dec 22, 2022 https://github.com/python/cpython/pull/16606/commits/6e24487e52b7ecf4b455fac5550efe9ed1fe8fdd
cca3253 Merge branch 'main' into bpo-38384-pickle-assert arhadthedev Apr 20, 2023 https://github.com/python/cpython/pull/16606/commits/cca325375f2b64ba4f6325f7dfd66b0f7a2f6685
cd5f794 Address the comment of Serhiy arhadthedev Apr 20, 2023 https://github.com/python/cpython/pull/16606/commits/cd5f794da6e540f9fc83b9655493a4a67fc526a0
dd343e1 `_PyObject_LookupAttrId` -> `_PyObject_LookupAttr` arhadthedev Apr 21, 2023 https://github.com/python/cpython/pull/16606/commits/dd343e153875f552e22042fa5208d7f8b0b23850
12aeed8 Merge branch 'main' into bpo-38384-pickle-assert serhiy-storchaka Dec 1, 2023 https://github.com/python/cpython/pull/16606/commits/12aeed84b491a70b0f49069fb3a9e9bd873f70b3
644a1cf Fix tests. serhiy-storchaka Dec 1, 2023 https://github.com/python/cpython/pull/16606/commits/644a1cf0d2e1e20eff6e206e6dc8f4f80f59383b
57f6095 Remove a NEWS entry. serhiy-storchaka Dec 1, 2023 https://github.com/python/cpython/pull/16606/commits/57f6095632b6454d26a2d4b29d72a317b54d6ee9
Clear filters https://github.com/python/cpython/pull/16606/files
Please reload this pagehttps://github.com/python/cpython/pull/16606/files
Please reload this pagehttps://github.com/python/cpython/pull/16606/files
Lib/test/pickletester.pyhttps://github.com/python/cpython/pull/16606/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
View file https://github.com/ZackerySpytz/cpython/blob/57f6095632b6454d26a2d4b29d72a317b54d6ee9/Lib/test/pickletester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/16606/{{ revealButtonHref }}
https://github.com/python/cpython/pull/16606/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
https://github.com/python/cpython/pull/16606/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.