René's URL Explorer Experiment


Title: bpo-36356: Fix memory leak in _asynciomodule.c during "setup.py build_ext" by btharper · Pull Request #16598 · python/cpython · GitHub

Open Graph Title: bpo-36356: Fix memory leak in _asynciomodule.c during "setup.py build_ext" by btharper · Pull Request #16598 · python/cpython

X Title: bpo-36356: Fix memory leak in _asynciomodule.c during "setup.py build_ext" by btharper · Pull Request #16598 · python/cpython

Description: The module seems to be imported twice during the build process which causes a leak. Since these objects are intended to be global for the life of the import, retain them during the second import. T...

Open Graph Description: The module seems to be imported twice during the build process which causes a leak. Since these objects are intended to be global for the life of the import, retain them during the second import. T...

X Description: The module seems to be imported twice during the build process which causes a leak. Since these objects are intended to be global for the life of the import, retain them during the second import. T...

Opengraph URL: https://github.com/python/cpython/pull/16598

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:241eadc9-cda1-3d30-563f-f1d358810bcf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD3E:2DB2A9:2D34A7:3D4A2E:6969D905
html-safe-nonce5cd54df15ac0aaaeea6901cc3c47d13b7cc5a37cac37ad4d22398f77162e8741
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDNFOjJEQjJBOToyRDM0QTc6M0Q0QTJFOjY5NjlEOTA1IiwidmlzaXRvcl9pZCI6IjE0OTA1NjY5MDI5MDE3NTgyMTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac986e725c98adc9d7267f33c8a7d3f86aa545faf96fa2976fb03fdc788ca11a6f
hovercard-subject-tagpull_request:324960871
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/16598/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/77d9e5b206213192cb326f3cbf0f967a1066cf4519069a8b9ebc8b7378a52a2c/python/cpython/pull/16598
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/77d9e5b206213192cb326f3cbf0f967a1066cf4519069a8b9ebc8b7378a52a2c/python/cpython/pull/16598
og:image:altThe module seems to be imported twice during the build process which causes a leak. Since these objects are intended to be global for the life of the import, retain them during the second import. T...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebtharper
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/16598#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16598
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16598
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/16598
Reloadhttps://github.com/python/cpython/pull/16598
Reloadhttps://github.com/python/cpython/pull/16598
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/16598
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/16598
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/16598#issue-comment-box
1st1https://github.com/1st1
python:masterhttps://github.com/python/cpython/tree/master
btharper:bpo-36356-1https://github.com/btharper/cpython/tree/bpo-36356-1
bpo-36356: Fix memory leak in _asynciomodule.c during "setup.py build_ext" https://github.com/python/cpython/pull/16598#top
1st1https://github.com/1st1
python:masterhttps://github.com/python/cpython/tree/master
btharper:bpo-36356-1https://github.com/btharper/cpython/tree/bpo-36356-1
Conversation 14 https://github.com/python/cpython/pull/16598
Commits 3 https://github.com/python/cpython/pull/16598/commits
Checks 0 https://github.com/python/cpython/pull/16598/checks
Files changed https://github.com/python/cpython/pull/16598/files
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/btharper
btharperhttps://github.com/btharper
Oct 5, 2019https://github.com/python/cpython/pull/16598#issue-502993703
Please reload this pagehttps://github.com/python/cpython/pull/16598
BPO-36356https://bugs.python.org/issue?@action=redirect&bpo=36356
https://bugs.python.org/issue36356https://bugs.python.org/issue36356
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/btharper
Fix memory leak during setup.py build_exthttps://github.com/python/cpython/pull/16598/commits/3f1669e8edb49d4af74f7b7686215973b4766229
3f1669ehttps://github.com/python/cpython/pull/16598/commits/3f1669e8edb49d4af74f7b7686215973b4766229
https://github.com/btharper
btharperhttps://github.com/btharper
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
code ownershttps://github.com/python/cpython/blob/65dcc8a8dc41d3453fd6b987073a5f1b30c5c0fd/.github/CODEOWNERS#L8
October 5, 2019 17:44https://github.com/python/cpython/pull/16598#event-2689434632
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Oct 5, 2019https://github.com/python/cpython/pull/16598#event-2689434658
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 5, 2019https://github.com/python/cpython/pull/16598#event-2689434667
https://github.com/1st1
1st1https://github.com/1st1
Oct 5, 2019https://github.com/python/cpython/pull/16598#issuecomment-538698853
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/btharper
btharperhttps://github.com/btharper
Oct 6, 2019https://github.com/python/cpython/pull/16598#issuecomment-538701810
setup.py line 529https://github.com/python/cpython/blob/65dcc8a8dc41d3453fd6b987073a5f1b30c5c0fd/setup.py#L529
#1https://github.com/python/cpython/pull/1
#2https://github.com/python/cpython/pull/2
#214https://github.com/python/cpython/pull/214
#215https://github.com/python/cpython/pull/215
#216https://github.com/python/cpython/pull/216
#217https://github.com/python/cpython/pull/217
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/btharper
Ensure asyncio initialization only happens oncehttps://github.com/python/cpython/pull/16598/commits/4a342f94c27f1f84dfa0932b89bcd45f2c7b7a1a
4a342f9https://github.com/python/cpython/pull/16598/commits/4a342f94c27f1f84dfa0932b89bcd45f2c7b7a1a
https://github.com/btharper
btharperhttps://github.com/btharper
Oct 6, 2019https://github.com/python/cpython/pull/16598#issuecomment-538705787
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/1st1
1st1https://github.com/1st1
Oct 7, 2019 https://github.com/python/cpython/pull/16598#pullrequestreview-297897850
View reviewed changes https://github.com/python/cpython/pull/16598/files/4a342f94c27f1f84dfa0932b89bcd45f2c7b7a1a
Modules/_asynciomodule.chttps://github.com/python/cpython/pull/16598/files/4a342f94c27f1f84dfa0932b89bcd45f2c7b7a1a#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/1st1
1st1https://github.com/1st1
Oct 7, 2019https://github.com/python/cpython/pull/16598#issuecomment-538833307
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/btharper
https://github.com/1st1
Fix brackets on else clausehttps://github.com/python/cpython/pull/16598/commits/604b6150966a3e6070e13b4ec948edad1af72525
604b615https://github.com/python/cpython/pull/16598/commits/604b6150966a3e6070e13b4ec948edad1af72525
https://github.com/btharper
btharperhttps://github.com/btharper
Oct 7, 2019https://github.com/python/cpython/pull/16598#issuecomment-539016820
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 7, 2019https://github.com/python/cpython/pull/16598#issuecomment-539035134
@btharperhttps://github.com/btharper
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/btharper
btharperhttps://github.com/btharper
Oct 7, 2019https://github.com/python/cpython/pull/16598#issuecomment-539049511
Please reload this pagehttps://github.com/python/cpython/pull/16598
@btharperhttps://github.com/btharper
bpo-36356https://bugs.python.org/issue36356
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/1st1
1st1https://github.com/1st1
Oct 7, 2019https://github.com/python/cpython/pull/16598#issuecomment-539079587
Please reload this pagehttps://github.com/python/cpython/pull/16598
bpo-36356https://bugs.python.org/issue36356
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/1st1
1st1https://github.com/1st1
Oct 7, 2019 https://github.com/python/cpython/pull/16598#pullrequestreview-298231574
View reviewed changes https://github.com/python/cpython/pull/16598/files/604b6150966a3e6070e13b4ec948edad1af72525
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 7, 2019https://github.com/python/cpython/pull/16598#event-2692370882
https://github.com/1st1
1st1https://github.com/1st1
Oct 7, 2019https://github.com/python/cpython/pull/16598#issuecomment-539079841
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 7, 2019 https://github.com/python/cpython/pull/16598#pullrequestreview-298246664
View reviewed changes https://github.com/python/cpython/pull/16598/files/604b6150966a3e6070e13b4ec948edad1af72525
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/16598#pullrequestreview-298246664
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/1st1
1st1https://github.com/1st1
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Oct 7, 2019https://github.com/python/cpython/pull/16598#event-2692468825
https://github.com/1st1
1st1https://github.com/1st1
321def8https://github.com/python/cpython/commit/321def805abc5b7c92c7e90ca90cb2434fdab855
Oct 7, 2019https://github.com/python/cpython/pull/16598#event-2692470702
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 7, 2019https://github.com/python/cpython/pull/16598#issuecomment-539092111
@btharperhttps://github.com/btharper
@1st1https://github.com/1st1
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 7, 2019https://github.com/python/cpython/pull/16598#event-2692470808
miss-islingtonhttps://github.com/miss-islington
Oct 7, 2019 https://github.com/python/cpython/pull/16598#ref-commit-855c4f9
https://github.com/btharper
https://github.com/miss-islington
bpo-36356: Fix memory leak in _asynciomodule.c (https://github.com/miss-islington/cpython/commit/855c4f90d8a1d25ab76f993bdd876ac53a16d3f1
pythonGH-16598https://github.com/python/cpython/pull/16598
)https://github.com/miss-islington/cpython/commit/855c4f90d8a1d25ab76f993bdd876ac53a16d3f1
855c4f9https://github.com/miss-islington/cpython/commit/855c4f90d8a1d25ab76f993bdd876ac53a16d3f1
321def8https://github.com/miss-islington/cpython/commit/321def805abc5b7c92c7e90ca90cb2434fdab855
https://github.com/1st1
1st1https://github.com/1st1
Oct 7, 2019https://github.com/python/cpython/pull/16598#issuecomment-539092191
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Oct 7, 2019https://github.com/python/cpython/pull/16598#event-2692471457
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 7, 2019https://github.com/python/cpython/pull/16598#issuecomment-539092197
GH-16622https://github.com/python/cpython/pull/16622
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/16598
miss-islingtonhttps://github.com/miss-islington
Oct 7, 2019 https://github.com/python/cpython/pull/16598#ref-commit-13915a3
https://github.com/miss-islington
https://github.com/btharper
bpo-36356https://bugs.python.org/issue?@action=redirect&bpo=36356
: Fix memory leak in _asynciomodule.c (https://github.com/python/cpython/commit/13915a3100608f011b29da2f3716c990f523b631
GH-16598https://github.com/python/cpython/pull/16598
)https://github.com/python/cpython/commit/13915a3100608f011b29da2f3716c990f523b631
13915a3https://github.com/python/cpython/commit/13915a3100608f011b29da2f3716c990f523b631
321def8https://github.com/python/cpython/commit/321def805abc5b7c92c7e90ca90cb2434fdab855
jacobneiltaylorhttps://github.com/jacobneiltaylor
Dec 5, 2019 https://github.com/python/cpython/pull/16598#ref-commit-dda68d7
https://github.com/btharper
bpo-36356: Fix memory leak in _asynciomodule.c (https://github.com/jacobneiltaylor/cpython/commit/dda68d7a4ef92493fa7a2c77021c06fa45565820
pythonGH-16598https://github.com/python/cpython/pull/16598
)https://github.com/jacobneiltaylor/cpython/commit/dda68d7a4ef92493fa7a2c77021c06fa45565820
dda68d7https://github.com/jacobneiltaylor/cpython/commit/dda68d7a4ef92493fa7a2c77021c06fa45565820
https://github.com/jquesnelle
jquesnellehttps://github.com/jquesnelle
Apr 15, 2020 https://github.com/python/cpython/pull/16598#ref-pullrequest-600477790
bpo-40294: Fix use-after-free in _asynciomodule.c when module is loaded/unloaded multiple times #19542 https://github.com/python/cpython/pull/19542
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16598
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/16598/files/604b6150966a3e6070e13b4ec948edad1af72525
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/python/cpython/pull/16598/files/604b6150966a3e6070e13b4ec948edad1af72525
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/16598
https://github.com/btharper
https://github.com/1st1
https://github.com/vstinner
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.