| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0f73654f-2420-8356-f30c-7e014be7fbfd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B37A:211953:11F0D2E:1A2C1DD:6A54C0F7 |
| html-safe-nonce | a04464b51c208e343e95ee5365e67fe56fa4e58d35506286bc2627c0f23e1ccc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzdBOjIxMTk1MzoxMUYwRDJFOjFBMkMxREQ6NkE1NEMwRjciLCJ2aXNpdG9yX2lkIjoiODk2NzYwNTI5NzM0Nzg3MDk2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7b19539e605ff513ae7dbc33a17eff5528c27cd4a3237f4b6483b15a0dd7efaa |
| hovercard-subject-tag | pull_request:322873368 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/16495/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/60b079642bb4dbddd004de0a0db7806ef83c727fa61de982524719beea941a19/python/cpython/pull/16495 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/60b079642bb4dbddd004de0a0db7806ef83c727fa61de982524719beea941a19/python/cpython/pull/16495 |
| og:image:alt | Fix a bug due to the interaction of weakrefs and the cyclic garbage
collector. We must clear any weakrefs in garbage in order to prevent
their callbacks from executing and causing a crash.
https:... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nascheme |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 69f9664dd5e7a82ba8ab1b4cb7f5a2f09333ab38 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/16495#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16495 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16495 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/16495 |
| Reload | https://github.com/python/cpython/pull/16495 |
| Reload | https://github.com/python/cpython/pull/16495 |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| ambv | https://github.com/ambv |
| python:master | https://github.com/python/cpython/tree/master |
| nascheme:weakref_gc_clear | https://github.com/nascheme/cpython/tree/weakref_gc_clear |
| Conversation | https://github.com/python/cpython/pull/16495 |
| Commits1 (1) | https://github.com/python/cpython/pull/16495/commits |
| Checks | https://github.com/python/cpython/pull/16495/checks |
| Files changed | https://github.com/python/cpython/pull/16495/files |
| bpo-38006: Clear weakrefs in garbage found by the GC | https://github.com/python/cpython/pull/16495#top |
| ambv | https://github.com/ambv |
| python:master | https://github.com/python/cpython/tree/master |
| nascheme:weakref_gc_clear | https://github.com/nascheme/cpython/tree/weakref_gc_clear |
|
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#issue-500390775 |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| https://bugs.python.org/issue38006 | https://bugs.python.org/issue38006 |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
|
| https://github.com/nascheme |
| Clear weakrefs in garbage found by the GC | https://github.com/python/cpython/pull/16495/commits/00986b80e64ad1d214d4322d5848d27f002cdff6 |
| 00986b8 | https://github.com/python/cpython/pull/16495/commits/00986b80e64ad1d214d4322d5848d27f002cdff6 |
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
|
type-bug
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug |
|
needs backport to 3.8
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22 |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#event-2673973161 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#event-2673973322 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#event-2673973478 |
| https://github.com/tim-one |
| tim-one | https://github.com/tim-one |
|
Sep 30, 2019
| https://github.com/python/cpython/pull/16495#pullrequestreview-295119434 |
|
View reviewed changes
| https://github.com/python/cpython/pull/16495/files/00986b80e64ad1d214d4322d5848d27f002cdff6 |
| tim-one | https://github.com/tim-one |
| https://github.com/python/cpython/pull/16495#pullrequestreview-295119434 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#event-2674051745 |
| https://github.com/ambv |
| ambv | https://github.com/ambv |
| bcda460 | https://github.com/python/cpython/commit/bcda460baf25062ab68622b3f043f52b9db4d21d |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#event-2674060751 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#issuecomment-536656509 |
| @ambv | https://github.com/ambv |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#issuecomment-536656510 |
| @nascheme | https://github.com/nascheme |
| @ambv | https://github.com/ambv |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#event-2674060923 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#issuecomment-536656667 |
| GH-16499 | https://github.com/python/cpython/pull/16499 |
| 3.8 branch | https://github.com/python/cpython/tree/3.8 |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.8
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22 |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#event-2674062362 |
| https://github.com/nascheme |
| nascheme | https://github.com/nascheme |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#issuecomment-536658209 |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| https://github.com/tim-one |
| tim-one | https://github.com/tim-one |
| Sep 30, 2019 | https://github.com/python/cpython/pull/16495#issuecomment-536662489 |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| ambv | https://github.com/ambv |
|
Sep 30, 2019
| https://github.com/python/cpython/pull/16495#ref-commit-92ca515 |
|
| https://github.com/miss-islington |
|
| https://github.com/nascheme |
|
| https://github.com/ambv |
| Clear weakrefs in garbage found by the GC ( | https://github.com/python/cpython/commit/92ca515ee1efbdc51678e12d105ad642c9b9cc13 |
| GH-16495 | https://github.com/python/cpython/pull/16495 |
| ) ( | https://github.com/python/cpython/commit/92ca515ee1efbdc51678e12d105ad642c9b9cc13 |
| #16499 | https://github.com/python/cpython/pull/16499 |
| ) | https://github.com/python/cpython/commit/92ca515ee1efbdc51678e12d105ad642c9b9cc13 |
| 92ca515 | https://github.com/python/cpython/commit/92ca515ee1efbdc51678e12d105ad642c9b9cc13 |
| bcda460 | https://github.com/python/cpython/commit/bcda460baf25062ab68622b3f043f52b9db4d21d |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
|
Oct 1, 2019
| https://github.com/python/cpython/pull/16495#ref-pullrequest-488204109 |
|
bpo-38009: Do not call weakref callbacks that are being collected
#15645
| https://github.com/python/cpython/pull/15645 |
| https://github.com/pitrou |
| pitrou | https://github.com/pitrou |
| Oct 3, 2019 | https://github.com/python/cpython/pull/16495#issuecomment-538153299 |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| weakref.finalize | https://docs.python.org/3/library/weakref.html#weakref.finalize |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| https://github.com/pitrou |
| pitrou | https://github.com/pitrou |
|
Oct 3, 2019
| https://github.com/python/cpython/pull/16495#pullrequestreview-297190288 |
|
View reviewed changes
| https://github.com/python/cpython/pull/16495/files/00986b80e64ad1d214d4322d5848d27f002cdff6 |
| Modules/gcmodule.c | https://github.com/python/cpython/pull/16495/files/00986b80e64ad1d214d4322d5848d27f002cdff6#diff-3ba495fac5f4cc4a582187117515f3177ab91823c65a59af962fe180e06d9e77 |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| https://github.com/tim-one |
| tim-one | https://github.com/tim-one |
| Oct 4, 2019 | https://github.com/python/cpython/pull/16495#issuecomment-538174334 |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
| jacobneiltaylor | https://github.com/jacobneiltaylor |
|
Dec 5, 2019
| https://github.com/python/cpython/pull/16495#ref-commit-d422977 |
|
| https://github.com/nascheme |
| Clear weakrefs in garbage found by the GC ( | https://github.com/jacobneiltaylor/cpython/commit/d4229775b9015e41e81be0dd366eaa9a747b0228 |
| python#16495 | https://github.com/python/cpython/pull/16495 |
| ) | https://github.com/jacobneiltaylor/cpython/commit/d4229775b9015e41e81be0dd366eaa9a747b0228 |
| d422977 | https://github.com/jacobneiltaylor/cpython/commit/d4229775b9015e41e81be0dd366eaa9a747b0228 |
| https://github.com/kratsg |
| kratsg | https://github.com/kratsg |
|
Sep 14, 2020
| https://github.com/python/cpython/pull/16495#ref-issue-698707261 |
|
exception/warnings about self._alive (in weakref) when running pytest
scikit-hep/pyhf#1059
| https://github.com/scikit-hep/pyhf/issues/1059 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16495 |
|
| https://github.com/pitrou |
|
pitrou
| https://github.com/pitrou |
|
| https://github.com/python/cpython/pull/16495/files/00986b80e64ad1d214d4322d5848d27f002cdff6 |
|
| https://github.com/tim-one |
|
tim-one
| https://github.com/tim-one |
|
| https://github.com/python/cpython/pull/16495/files/00986b80e64ad1d214d4322d5848d27f002cdff6 |
|
type-bug
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug |
| Please reload this page | https://github.com/python/cpython/pull/16495 |
|
| https://github.com/nascheme |
|
| https://github.com/bedevere-bot |
|
| https://github.com/miss-islington |
|
| https://github.com/tim-one |
|
| https://github.com/pitrou |
|
| https://github.com/ambv |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |