René's URL Explorer Experiment


Title: gh-114782: Fix http.client splitting header lines on a bare CR by star7js · Pull Request #162397 · python/cpython · GitHub

Open Graph Title: gh-114782: Fix http.client splitting header lines on a bare CR by star7js · Pull Request #162397 · python/cpython

X Title: gh-114782: Fix http.client splitting header lines on a bare CR by star7js · Pull Request #162397 · python/cpython

Description: The email parser used by http.client.parse_headers() treats a bare CR as a line terminator, so one field line can be parsed as several header fields. With the request from the issue, Visible: :/\rSmuggled: :)\r\n is parsed as two headers, Visible and Smuggled. This affects http.client, http.server and wsgiref.simple_server. RFC 9112 section 2.2 says a recipient of a bare CR must either treat the element as invalid or replace each bare CR with SP before processing. This change replaces it with SP in _read_headers(), so the line stays one field. I chose replacement over rejection because it cannot break clients that talk to servers sending a stray CR. Happy to switch to rejecting (at least in http.server) if that is preferred. Only CR is affected: I checked the other characters str.splitlines() splits on (\x0b, \x0c, \x1c to \x1e, \x85) and none of them split a header line. Tests: two in test_httplib and one in test_httpservers; all fail without the change. Issue: gh-114782

Open Graph Description: The email parser used by http.client.parse_headers() treats a bare CR as a line terminator, so one field line can be parsed as several header fields. With the request from the issue, Visible: :/\rS...

X Description: The email parser used by http.client.parse_headers() treats a bare CR as a line terminator, so one field line can be parsed as several header fields. With the request from the issue, Visible: :/\rS...

Opengraph URL: https://github.com/python/cpython/pull/162397

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d9fae33f-86f0-a357-edfe-8203fe76da21
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFE8:26ECEB:3AE4478:4ADFCDC:6B01EC5C
html-safe-nonce2ce6ba67a788282ea556c1b06d1ba7ffbf643a706ae2cf20d0d9b7f000fd1564
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkU4OjI2RUNFQjozQUU0NDc4OjRBREZDREM6NkIwMUVDNUMiLCJ2aXNpdG9yX2lkIjoiODAwNDE5NTg5NjA4ODcxODQyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0969be304f14c289a3e59e4e3299726e5ea42bc5c7ee98ce2076ac191daa2f96
hovercard-subject-tagpull_request:5431117249
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162397/files
twitter:imagehttps://avatars.githubusercontent.com/u/126814341?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/126814341?s=400&v=4
og:image:altThe email parser used by http.client.parse_headers() treats a bare CR as a line terminator, so one field line can be parsed as several header fields. With the request from the issue, Visible: :/\rS...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162397/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162397%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162397%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162397/files
Reloadhttps://github.com/python/cpython/pull/162397/files
Reloadhttps://github.com/python/cpython/pull/162397/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
star7jshttps://github.com/star7js
python:mainhttps://github.com/python/cpython/tree/main
star7js:gh-114782-bare-crhttps://github.com/star7js/cpython/tree/gh-114782-bare-cr
Conversation 1 https://github.com/python/cpython/pull/162397
Commits 1 https://github.com/python/cpython/pull/162397/commits
Checks 54 https://github.com/python/cpython/pull/162397/checks
Files changed 4 https://github.com/python/cpython/pull/162397/files
gh-114782: Fix http.client splitting header lines on a bare CR https://github.com/python/cpython/pull/162397/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/162397/files
c5b63a1 gh-114782: Fix http.client splitting header lines on a bare CR star7js Nov 15, 2026 https://github.com/python/cpython/pull/162397/commits/c5b63a1ea893081680aadefb2f7dc96f79175ca7
Clear filters https://github.com/python/cpython/pull/162397/files
Please reload this pagehttps://github.com/python/cpython/pull/162397/files
Please reload this pagehttps://github.com/python/cpython/pull/162397/files
client.py https://github.com/python/cpython/pull/162397/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
test_httplib.py https://github.com/python/cpython/pull/162397/files#diff-6202bc3817db8ca8da16747c2447a99b5cb9037cc39f05a29f4dd152d155dac2
test_httpservers.py https://github.com/python/cpython/pull/162397/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
2026-11-15-12-10-00.gh-issue-114782.bR7cQx.rst https://github.com/python/cpython/pull/162397/files#diff-d7a5dc77b0b7c41cbf9bf7adea0d4afe01f0fad757d5d3d35a8ba07f1edac87c
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L503
Lib/http/client.pyhttps://github.com/python/cpython/pull/162397/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
View file https://github.com/python/cpython/blob/c5b63a1ea893081680aadefb2f7dc96f79175ca7/Lib/http/client.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162397/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162397/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
https://github.com/python/cpython/pull/162397/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
https://github.com/python/cpython/pull/162397/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
https://github.com/python/cpython/pull/162397/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L504
Lib/test/test_httplib.pyhttps://github.com/python/cpython/pull/162397/files#diff-6202bc3817db8ca8da16747c2447a99b5cb9037cc39f05a29f4dd152d155dac2
View file https://github.com/python/cpython/blob/c5b63a1ea893081680aadefb2f7dc96f79175ca7/Lib/test/test_httplib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162397/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162397/files#diff-6202bc3817db8ca8da16747c2447a99b5cb9037cc39f05a29f4dd152d155dac2
https://github.com/python/cpython/pull/162397/files#diff-6202bc3817db8ca8da16747c2447a99b5cb9037cc39f05a29f4dd152d155dac2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L504
Lib/test/test_httpservers.pyhttps://github.com/python/cpython/pull/162397/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
View file https://github.com/python/cpython/blob/c5b63a1ea893081680aadefb2f7dc96f79175ca7/Lib/test/test_httpservers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162397/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162397/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
https://github.com/python/cpython/pull/162397/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
Misc/NEWS.d/next/Security/2026-11-15-12-10-00.gh-issue-114782.bR7cQx.rsthttps://github.com/python/cpython/pull/162397/files#diff-d7a5dc77b0b7c41cbf9bf7adea0d4afe01f0fad757d5d3d35a8ba07f1edac87c
View file https://github.com/python/cpython/blob/c5b63a1ea893081680aadefb2f7dc96f79175ca7/Misc/NEWS.d/next/Security/2026-11-15-12-10-00.gh-issue-114782.bR7cQx.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162397/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/162397/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.