René's URL Explorer Experiment


Title: gh-162219: Provide explicit SIMD defaults for HACL streaming HMAC by tamaki0575-cloud · Pull Request #162393 · python/cpython · GitHub

Open Graph Title: gh-162219: Provide explicit SIMD defaults for HACL streaming HMAC by tamaki0575-cloud · Pull Request #162393 · python/cpython

X Title: gh-162219: Provide explicit SIMD defaults for HACL streaming HMAC by tamaki0575-cloud · Pull Request #162393 · python/cpython

Description: Compile the vendored HACL* streaming HMAC implementation through a CPython wrapper. The wrapper defaults HACL_CAN_COMPILE_VEC128 and HACL_CAN_COMPILE_VEC256 to 0 only when they are undefined. The Makefile and Windows project both use the wrapper, so the vendored source stays untouched. Fixes #162219. Testing Debian Bookworm (Docker), GCC 12.2: make Modules/_hacl/Hacl_Streaming_HMAC.o CC='gcc -Wundef' reproduced both warnings before the patch and emitted neither after it. Built CPython from main at 1822ff5 and ran ./python -m test test_hmac test_hashlib. Both test modules passed (241 tests run, 17 skipped). Checked the compile entries in both Windows project files. No Windows build was run. Codex was used to verify the patch and prepare this PR description. Issue: gh-162219

Open Graph Description: Compile the vendored HACL* streaming HMAC implementation through a CPython wrapper. The wrapper defaults HACL_CAN_COMPILE_VEC128 and HACL_CAN_COMPILE_VEC256 to 0 only when they are undefined. The M...

X Description: Compile the vendored HACL* streaming HMAC implementation through a CPython wrapper. The wrapper defaults HACL_CAN_COMPILE_VEC128 and HACL_CAN_COMPILE_VEC256 to 0 only when they are undefined. The M...

Opengraph URL: https://github.com/python/cpython/pull/162393

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:68dd82cd-420e-6208-6744-ff29350f2098
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD56:7A60E:37401D2:46E4FBE:6B01EC69
html-safe-nonce671191e6fce6b82abb8481f342d1cf5de83924fbfc24b473f1b75f74167e4062
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDU2OjdBNjBFOjM3NDAxRDI6NDZFNEZCRTo2QjAxRUM2OSIsInZpc2l0b3JfaWQiOiI0ODQ1MDIzMTcwOTgzNDg4NjE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac275a1eb0d393a3d84c2da6b4e4b6432fce8bfb77d3442bc8ec323cf9b293e215
hovercard-subject-tagpull_request:5430079174
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162393/files
twitter:imagehttps://avatars.githubusercontent.com/u/265693791?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/265693791?s=400&v=4
og:image:altCompile the vendored HACL* streaming HMAC implementation through a CPython wrapper. The wrapper defaults HACL_CAN_COMPILE_VEC128 and HACL_CAN_COMPILE_VEC256 to 0 only when they are undefined. The M...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162393/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162393%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162393%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162393/files
Reloadhttps://github.com/python/cpython/pull/162393/files
Reloadhttps://github.com/python/cpython/pull/162393/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
tamaki0575-cloudhttps://github.com/tamaki0575-cloud
python:mainhttps://github.com/python/cpython/tree/main
tamaki0575-cloud:gh-162219-hacl-hmac-simd-defaultshttps://github.com/tamaki0575-cloud/cpython/tree/gh-162219-hacl-hmac-simd-defaults
Conversation 4 https://github.com/python/cpython/pull/162393
Commits 1 https://github.com/python/cpython/pull/162393/commits
Checks 56 https://github.com/python/cpython/pull/162393/checks
Files changed 4 https://github.com/python/cpython/pull/162393/files
gh-162219: Provide explicit SIMD defaults for HACL streaming HMAC https://github.com/python/cpython/pull/162393/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/162393/files
4e18955 gh-162219: Provide explicit SIMD defaults for HACL streaming HMAC tamaki0575-cloud Nov 21, 2026 https://github.com/python/cpython/pull/162393/commits/4e189556edf225eb76a3e829ba2cf171e4f890a2
Clear filters https://github.com/python/cpython/pull/162393/files
Please reload this pagehttps://github.com/python/cpython/pull/162393/files
Please reload this pagehttps://github.com/python/cpython/pull/162393/files
Makefile.pre.in https://github.com/python/cpython/pull/162393/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
_hmac_hacl.c https://github.com/python/cpython/pull/162393/files#diff-12925a1cbbbb296e7388ebdbfbc69538294146ff2108d76331056a0dd47902d5
pythoncore.vcxproj https://github.com/python/cpython/pull/162393/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
pythoncore.vcxproj.filters https://github.com/python/cpython/pull/162393/files#diff-9e715828befc9c50c8b483b06d4923cda0db44f57d0c20e6a6d428ba60bfa0c5
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L85
Makefile.pre.inhttps://github.com/python/cpython/pull/162393/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
View file https://github.com/python/cpython/blob/4e189556edf225eb76a3e829ba2cf171e4f890a2/Makefile.pre.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162393/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162393/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/162393/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L393
Modules/_hmac_hacl.chttps://github.com/python/cpython/pull/162393/files#diff-12925a1cbbbb296e7388ebdbfbc69538294146ff2108d76331056a0dd47902d5
View file https://github.com/python/cpython/blob/4e189556edf225eb76a3e829ba2cf171e4f890a2/Modules/_hmac_hacl.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162393/{{ revealButtonHref }}
picnixzhttps://github.com/picnixz
Nov 21, 2026https://github.com/python/cpython/pull/162393/files#r4653894024
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162393/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L190
PCbuild/pythoncore.vcxprojhttps://github.com/python/cpython/pull/162393/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
View file https://github.com/python/cpython/blob/4e189556edf225eb76a3e829ba2cf171e4f890a2/PCbuild/pythoncore.vcxproj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162393/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162393/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
https://github.com/python/cpython/pull/162393/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L190
PCbuild/pythoncore.vcxproj.filtershttps://github.com/python/cpython/pull/162393/files#diff-9e715828befc9c50c8b483b06d4923cda0db44f57d0c20e6a6d428ba60bfa0c5
View file https://github.com/python/cpython/blob/4e189556edf225eb76a3e829ba2cf171e4f890a2/PCbuild/pythoncore.vcxproj.filters
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162393/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162393/files#diff-9e715828befc9c50c8b483b06d4923cda0db44f57d0c20e6a6d428ba60bfa0c5
https://github.com/python/cpython/pull/162393/files#diff-9e715828befc9c50c8b483b06d4923cda0db44f57d0c20e6a6d428ba60bfa0c5
Please reload this pagehttps://github.com/python/cpython/pull/162393/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.