René's URL Explorer Experiment


Title: gh-162308: Check modules with target Python in native builds by Udit-Agarwal20 · Pull Request #162337 · python/cpython · GitHub

Open Graph Title: gh-162308: Check modules with target Python in native builds by Udit-Agarwal20 · Pull Request #162337 · python/cpython

X Title: gh-162308: Check modules with target Python in native builds by Udit-Agarwal20 · Pull Request #162337 · python/cpython

Description: Summary Fixes #162308. Native CPython builds configured with --with-build-python currently execute checksharedmods using the external build interpreter (PYTHON_FOR_BUILD) rather than the newly built target interpreter. When the two interpreters have different built-in extension configurations, this can result in incorrect module validation. In addition, the inherited _PYTHON_HOST_PLATFORM variable can cause native builds to skip import checks by incorrectly selecting cross-compilation mode. Changes Introduce MODULE_CHECK_COMMAND in configure.ac to select the appropriate interpreter and checking mode. Run native module checks using ./$(BUILDPYTHON) -E with --no-cross-compiling. Retain $(PYTHON_FOR_BUILD) with --cross-compiling for cross builds. Preserve $(RUNSHARED_FOR_BUILD) to avoid injecting target shared-library paths into the build interpreter during cross-compilation. Apply the selected command to both module validation and missing-stdlib information generation. Add Makefile regression tests and extend the Linux build workflow to exercise differing _bisect configurations. Testing The following local checks were reported successful: test_tools.test_makefile in a native build. test_sysconfig and test_build_details in a standard native build. Makefile tests using a simulated cross-compilation configuration. Tools/patchcheck/patchcheck.py. git diff --check. Native module validation with a target Python that builds _bisect as a built-in. Full cross-architecture build execution and official containerized Autoconf regeneration were not completed locally. These require further CI verification. Related work and attribution Builds on the approach proposed in #162311 by @superajun-wsj, with additional regression coverage and preservation of RUNSHARED_FOR_BUILD for cross-build safety. Related: #161530. The original contributor is credited through the commit's Co-authored-by trailer. Any outstanding CLA requirements will need to be resolved. AI assistance This contribution was developed with assistance from Google Antigravity. The changes were reviewed and tested locally, with remaining validation limitations described above. Issue: gh-162308

Open Graph Description: Summary Fixes #162308. Native CPython builds configured with --with-build-python currently execute checksharedmods using the external build interpreter (PYTHON_FOR_BUILD) rather than the newly buil...

X Description: Summary Fixes #162308. Native CPython builds configured with --with-build-python currently execute checksharedmods using the external build interpreter (PYTHON_FOR_BUILD) rather than the newly buil...

Opengraph URL: https://github.com/python/cpython/pull/162337

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:94ac62d8-3eff-9e80-a6a7-16d0f1abf1a8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9164:1FAE:A32FC6:DCF7D2:6B01EFC0
html-safe-noncefb560b18f525dde481fb7bac06cabe28083e1f10b7f0a347facb06aea7eba2c2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTY0OjFGQUU6QTMyRkM2OkRDRjdEMjo2QjAxRUZDMCIsInZpc2l0b3JfaWQiOiIyMTk3NjQ5NzAwMDEzOTU2NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3303aa71c36305866996503217d7ead1cbb40e8d3359a30b8a9c7a8438b01a81
hovercard-subject-tagpull_request:5419965482
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162337/files
twitter:imagehttps://avatars.githubusercontent.com/u/246970776?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/246970776?s=400&v=4
og:image:altSummary Fixes #162308. Native CPython builds configured with --with-build-python currently execute checksharedmods using the external build interpreter (PYTHON_FOR_BUILD) rather than the newly buil...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162337/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162337%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162337%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162337/files
Reloadhttps://github.com/python/cpython/pull/162337/files
Reloadhttps://github.com/python/cpython/pull/162337/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Udit-Agarwal20https://github.com/Udit-Agarwal20
python:mainhttps://github.com/python/cpython/tree/main
Udit-Agarwal20:fix-162308-native-module-checkhttps://github.com/Udit-Agarwal20/cpython/tree/fix-162308-native-module-check
Conversation 3 https://github.com/python/cpython/pull/162337
Commits 1 https://github.com/python/cpython/pull/162337/commits
Checks 60 https://github.com/python/cpython/pull/162337/checks
Files changed 6 https://github.com/python/cpython/pull/162337/files
gh-162308: Check modules with target Python in native builds https://github.com/python/cpython/pull/162337/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/162337/files
76a19c8 gh-162308: Check modules with target Python in native builds Udit-Agarwal20 Nov 20, 2026 https://github.com/python/cpython/pull/162337/commits/76a19c852043467ec281a9d0da709f5fe002fa9b
Clear filters https://github.com/python/cpython/pull/162337/files
Please reload this pagehttps://github.com/python/cpython/pull/162337/files
Please reload this pagehttps://github.com/python/cpython/pull/162337/files
build.yml https://github.com/python/cpython/pull/162337/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721
test_makefile.py https://github.com/python/cpython/pull/162337/files#diff-dca63a13c37dcfa958141d0eb201347dbb5a37ec081db27a3b5d42f097573b1b
Makefile.pre.in https://github.com/python/cpython/pull/162337/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
2026-11-20-16-30-00.gh-issue-162308.Mk7pQ2.rst https://github.com/python/cpython/pull/162337/files#diff-d50f86c4e5fe894a378715962afd46bc7a398f14afec65983e2fd46cc4c74587
configure https://github.com/python/cpython/pull/162337/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.ac https://github.com/python/cpython/pull/162337/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L66
.github/workflows/build.ymlhttps://github.com/python/cpython/pull/162337/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721
View file https://github.com/python/cpython/blob/76a19c852043467ec281a9d0da709f5fe002fa9b/.github/workflows/build.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162337/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162337/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721
https://github.com/python/cpython/pull/162337/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721
Lib/test/test_tools/test_makefile.pyhttps://github.com/python/cpython/pull/162337/files#diff-dca63a13c37dcfa958141d0eb201347dbb5a37ec081db27a3b5d42f097573b1b
View file https://github.com/python/cpython/blob/76a19c852043467ec281a9d0da709f5fe002fa9b/Lib/test/test_tools/test_makefile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162337/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162337/files#diff-dca63a13c37dcfa958141d0eb201347dbb5a37ec081db27a3b5d42f097573b1b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L85
Makefile.pre.inhttps://github.com/python/cpython/pull/162337/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
View file https://github.com/python/cpython/blob/76a19c852043467ec281a9d0da709f5fe002fa9b/Makefile.pre.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162337/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162337/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/162337/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/162337/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/162337/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
Misc/NEWS.d/next/Build/2026-11-20-16-30-00.gh-issue-162308.Mk7pQ2.rsthttps://github.com/python/cpython/pull/162337/files#diff-d50f86c4e5fe894a378715962afd46bc7a398f14afec65983e2fd46cc4c74587
View file https://github.com/python/cpython/blob/76a19c852043467ec281a9d0da709f5fe002fa9b/Misc/NEWS.d/next/Build/2026-11-20-16-30-00.gh-issue-162308.Mk7pQ2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162337/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L84
configurehttps://github.com/python/cpython/pull/162337/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
View file https://github.com/python/cpython/blob/76a19c852043467ec281a9d0da709f5fe002fa9b/configure
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/162337/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L84
configure.achttps://github.com/python/cpython/pull/162337/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
View file https://github.com/python/cpython/blob/76a19c852043467ec281a9d0da709f5fe002fa9b/configure.ac
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162337/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162337/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/pull/162337/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
Please reload this pagehttps://github.com/python/cpython/pull/162337/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.