René's URL Explorer Experiment


Title: gh-111066: Preserve Unpickler memo state on assignment by Sauvi72 · Pull Request #162329 · python/cpython · GitHub

Open Graph Title: gh-111066: Preserve Unpickler memo state on assignment by Sauvi72 · Pull Request #162329 · python/cpython

X Title: gh-111066: Preserve Unpickler memo state on assignment by Sauvi72 · Pull Request #162329 · python/cpython

Description: Assigning a dictionary to the C Unpickler's memo populated the old memo and then discarded its array. Copying another unpickler's memo also omitted its sequential index and sparse entries, so continuing a pickle stream could raise UnpicklingError or retrieve stale objects. Build and validate the replacement memo before installing it, copy the complete state from memo proxies, and install the replacement before releasing the old entries. Include sparse entries in memo snapshots so dictionary-based transfers retain them too. Invalid assignments leave the previous memo intact. The regression tests cover dictionary and proxy assignments, protocol 4/5 continuation with shared references, sparse indexes, empty and self assignments, rejected keys, independent dictionary copies, and reentrant finalizers. Fixes #111066. Validation: Debug build on macOS arm64. test_pickle, test_pickletools, test_copy, test_shelve, test_marshal: 1,865 tests run; 72 skipped; success. 19 memo-related tests with -R 3:3: no reference leaks. Repository pre-commit hooks and patchcheck: passed. Full suite: 51,480 tests run, 17 failures across eight test modules, 3,869 skipped. The failing modules match the earlier unmodified baseline: test_audit, multiprocessing forkserver/spawn test_misc and test_processes, test_os.test_os, test_sys, and test_termios. This environment lacks permissions for some OS/debugger operations and several optional extension dependencies. The full suite is not green locally. Issue: gh-111066

Open Graph Description: Assigning a dictionary to the C Unpickler's memo populated the old memo and then discarded its array. Copying another unpickler's memo also omitted its sequential index and sparse entries, ...

X Description: Assigning a dictionary to the C Unpickler's memo populated the old memo and then discarded its array. Copying another unpickler's memo also omitted its sequential index and sparse e...

Opengraph URL: https://github.com/python/cpython/pull/162329

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8378a120-1772-75c0-0dcf-0d2c34c1e505
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6D2:14EB6E:14F188B:1B912B3:6B01F484
html-safe-nonceeec2e40d2c3adb6276ba6c637faa9895fd5a79da4b71d5e0aa4eefd6e1d8d1a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkQyOjE0RUI2RToxNEYxODhCOjFCOTEyQjM6NkIwMUY0ODQiLCJ2aXNpdG9yX2lkIjoiNzQ4NjU2OTI2OTU5ODMyMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd40b796a5638b6ad5f9f218a0c6cd0c880ad657da68c125b0c292caba1d6dca3
hovercard-subject-tagpull_request:5416619606
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162329/files
twitter:imagehttps://avatars.githubusercontent.com/u/230492797?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/230492797?s=400&v=4
og:image:altAssigning a dictionary to the C Unpickler's memo populated the old memo and then discarded its array. Copying another unpickler's memo also omitted its sequential index and sparse entries, ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162329/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162329%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162329%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162329/files
Reloadhttps://github.com/python/cpython/pull/162329/files
Reloadhttps://github.com/python/cpython/pull/162329/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Sauvi72https://github.com/Sauvi72
python:mainhttps://github.com/python/cpython/tree/main
Sauvi72:fix/gh-111066-unpickler-memohttps://github.com/Sauvi72/cpython/tree/fix/gh-111066-unpickler-memo
Conversation 1 https://github.com/python/cpython/pull/162329
Commits 2 https://github.com/python/cpython/pull/162329/commits
Checks 53 https://github.com/python/cpython/pull/162329/checks
Files changed 4 https://github.com/python/cpython/pull/162329/files
gh-111066: Preserve Unpickler memo state on assignment https://github.com/python/cpython/pull/162329/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/162329/files
2b47fc3 gh-111066: Preserve Unpickler memo state on assignment Sauvi72 Nov 20, 2026 https://github.com/python/cpython/pull/162329/commits/2b47fc32f5959a438c04cc79794651e9abac140a
9feed03 Merge branch 'main' into fix/gh-111066-unpickler-memo Sauvi72 Nov 20, 2026 https://github.com/python/cpython/pull/162329/commits/9feed0390ffa7489b62af4166f136b848efeebdb
Clear filters https://github.com/python/cpython/pull/162329/files
Please reload this pagehttps://github.com/python/cpython/pull/162329/files
Please reload this pagehttps://github.com/python/cpython/pull/162329/files
pickletester.py https://github.com/python/cpython/pull/162329/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
test_pickle.py https://github.com/python/cpython/pull/162329/files#diff-eabc91c9e7a2586ffc6ca849d6636e74e28825a4515745c280b045dbdf857e39
2026-11-20-12-00-00.gh-issue-111066.memo.rst https://github.com/python/cpython/pull/162329/files#diff-71c9362f411af262e0ee0ddf580ed2ffeb067329e42fd94bfdbc3a745c4cb8b5
_pickle.c https://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
Lib/test/pickletester.pyhttps://github.com/python/cpython/pull/162329/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
View file https://github.com/python/cpython/blob/9feed0390ffa7489b62af4166f136b848efeebdb/Lib/test/pickletester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162329/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162329/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
https://github.com/python/cpython/pull/162329/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
Lib/test/test_pickle.pyhttps://github.com/python/cpython/pull/162329/files#diff-eabc91c9e7a2586ffc6ca849d6636e74e28825a4515745c280b045dbdf857e39
View file https://github.com/python/cpython/blob/9feed0390ffa7489b62af4166f136b848efeebdb/Lib/test/test_pickle.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162329/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162329/files#diff-eabc91c9e7a2586ffc6ca849d6636e74e28825a4515745c280b045dbdf857e39
https://github.com/python/cpython/pull/162329/files#diff-eabc91c9e7a2586ffc6ca849d6636e74e28825a4515745c280b045dbdf857e39
Misc/NEWS.d/next/Library/2026-11-20-12-00-00.gh-issue-111066.memo.rsthttps://github.com/python/cpython/pull/162329/files#diff-71c9362f411af262e0ee0ddf580ed2ffeb067329e42fd94bfdbc3a745c4cb8b5
View file https://github.com/python/cpython/blob/9feed0390ffa7489b62af4166f136b848efeebdb/Misc/NEWS.d/next/Library/2026-11-20-12-00-00.gh-issue-111066.memo.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162329/{{ revealButtonHref }}
Modules/_pickle.chttps://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
View file https://github.com/python/cpython/blob/9feed0390ffa7489b62af4166f136b848efeebdb/Modules/_pickle.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162329/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com/python/cpython/pull/162329/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
Please reload this pagehttps://github.com/python/cpython/pull/162329/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.