René's URL Explorer Experiment


Title: gh-162306: Reject day 0 and year 0 with a 24:00 time in datetime.fromisoformat() by choam2426 · Pull Request #162307 · python/cpython · GitHub

Open Graph Title: gh-162306: Reject day 0 and year 0 with a 24:00 time in datetime.fromisoformat() by choam2426 · Pull Request #162307 · python/cpython

X Title: gh-162306: Reject day 0 and year 0 with a 24:00 time in datetime.fromisoformat() by choam2426 · Pull Request #162307 · python/cpython

Description: datetime.fromisoformat() rolled a 24:00 time over to the next day even when the day was 0 or the year was 0, so "2026-06-00T24:00" returned 2026-06-01 00:00 and "0000-12-31T24:00" returned 0001-01-01 00:00 instead of raising ValueError. The rollover guard already checks the month range and the upper day bound (the month lower bound came with gh-151770). This adds the missing day >= 1 and year >= MINYEAR bounds in both Modules/_datetimemodule.c and Lib/_pydatetime.py. With the guard skipped, the constructor raises its usual ValueError for these inputs. Tests: "0000-12-31T24:00:00" is added to test_fromisoformat_fails_datetime_valueerror, and the existing day-32 check now also covers day 0. I used an AI coding assistant to help with this change. I reviewed the analysis, the patch and the tests. Issue: gh-162306

Open Graph Description: datetime.fromisoformat() rolled a 24:00 time over to the next day even when the day was 0 or the year was 0, so "2026-06-00T24:00" returned 2026-06-01 00:00 and "0000-12-31T24:00&quo...

X Description: datetime.fromisoformat() rolled a 24:00 time over to the next day even when the day was 0 or the year was 0, so "2026-06-00T24:00" returned 2026-06-01 00:00 and "0000-12-...

Opengraph URL: https://github.com/python/cpython/pull/162307

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:308b9672-f2c8-95ad-bfef-4f04befcea6d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD75E:20AA01:3BCB87A:4BEC9BF:6B01EFE6
html-safe-nonced785bf8f3f03f31511c567e4096c965f2b220a3270793c447a52d2c2af5c07eb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzVFOjIwQUEwMTozQkNCODdBOjRCRUM5QkY6NkIwMUVGRTYiLCJ2aXNpdG9yX2lkIjoiNDE5MjM2MTczMTY4NDY5MTk0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac18a3f7f3e355fe0566f4acfda0d9dad20b5045d076602b5c9e887efbac359761
hovercard-subject-tagpull_request:5407955553
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162307/files
twitter:imagehttps://avatars.githubusercontent.com/u/117963215?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/117963215?s=400&v=4
og:image:altdatetime.fromisoformat() rolled a 24:00 time over to the next day even when the day was 0 or the year was 0, so "2026-06-00T24:00" returned 2026-06-01 00:00 and "0000-12-31T24:00&quo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162307/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162307%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162307%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162307/files
Reloadhttps://github.com/python/cpython/pull/162307/files
Reloadhttps://github.com/python/cpython/pull/162307/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
choam2426https://github.com/choam2426
python:mainhttps://github.com/python/cpython/tree/main
choam2426:fromisoformat-24-lower-boundshttps://github.com/choam2426/cpython/tree/fromisoformat-24-lower-bounds
Conversation 7 https://github.com/python/cpython/pull/162307
Commits 3 https://github.com/python/cpython/pull/162307/commits
Checks 53 https://github.com/python/cpython/pull/162307/checks
Files changed https://github.com/python/cpython/pull/162307/files
Please reload this pagehttps://github.com/python/cpython/pull/162307/files
gh-162306: Reject day 0 and year 0 with a 24:00 time in datetime.fromisoformat() https://github.com/python/cpython/pull/162307/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/162307/files
7b3f68d gh-162306: Reject day 0 and year 0 with a 24:00 time in datetime.from… choam2426 Nov 20, 2026 https://github.com/python/cpython/pull/162307/commits/7b3f68d7ae5fc390b9014cfa8969201dc1ff136f
e5134a0 Keep accepting year 0 with a 24:00 time that rolls over into year 1 choam2426 Nov 21, 2026 https://github.com/python/cpython/pull/162307/commits/e5134a08d05b0c016dc35146ee8be3287bc7259f
420be25 Test that year 0 with a 24:00 time rolls over into year 1 choam2426 Nov 21, 2026 https://github.com/python/cpython/pull/162307/commits/420be2589a804001c21b9eb05ee256a5483c4a07
Clear filters https://github.com/python/cpython/pull/162307/files
Please reload this pagehttps://github.com/python/cpython/pull/162307/files
Please reload this pagehttps://github.com/python/cpython/pull/162307/files
_pydatetime.py https://github.com/python/cpython/pull/162307/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
datetimetester.py https://github.com/python/cpython/pull/162307/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
2026-11-20-13-51-31.gh-issue-162306.ys64EX.rst https://github.com/python/cpython/pull/162307/files#diff-0473e3a6e6c122e6f110e22ecd031abd5928d09dda7f176aef245e3b47bb1fd8
_datetimemodule.c https://github.com/python/cpython/pull/162307/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L433
Lib/_pydatetime.pyhttps://github.com/python/cpython/pull/162307/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
View file https://github.com/python/cpython/blob/420be2589a804001c21b9eb05ee256a5483c4a07/Lib/_pydatetime.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162307/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/pull/162307/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L434
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/162307/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
View file https://github.com/python/cpython/blob/420be2589a804001c21b9eb05ee256a5483c4a07/Lib/test/datetimetester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162307/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/162307/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/162307/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/162307/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
Misc/NEWS.d/next/Library/2026-11-20-13-51-31.gh-issue-162306.ys64EX.rsthttps://github.com/python/cpython/pull/162307/files#diff-0473e3a6e6c122e6f110e22ecd031abd5928d09dda7f176aef245e3b47bb1fd8
View file https://github.com/python/cpython/blob/420be2589a804001c21b9eb05ee256a5483c4a07/Misc/NEWS.d/next/Library/2026-11-20-13-51-31.gh-issue-162306.ys64EX.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162307/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L437
Modules/_datetimemodule.chttps://github.com/python/cpython/pull/162307/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
View file https://github.com/python/cpython/blob/420be2589a804001c21b9eb05ee256a5483c4a07/Modules/_datetimemodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162307/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/162307/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
Please reload this pagehttps://github.com/python/cpython/pull/162307/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.