René's URL Explorer Experiment


Title: gh-162306: Reject day 0 and year 0 with a 24:00 time in datetime.fromisoformat() by choam2426 · Pull Request #162307 · python/cpython · GitHub

Open Graph Title: gh-162306: Reject day 0 and year 0 with a 24:00 time in datetime.fromisoformat() by choam2426 · Pull Request #162307 · python/cpython

X Title: gh-162306: Reject day 0 and year 0 with a 24:00 time in datetime.fromisoformat() by choam2426 · Pull Request #162307 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: datetime.fromisoformat() rolled a 24:00 time over to the next day even when the day was 0 or the year was 0, so "2026-06-00T24:00" returned 2026-06-01 00:00 and "0000-12-31T24:00&quo...

X Description: datetime.fromisoformat() rolled a 24:00 time over to the next day even when the day was 0 or the year was 0, so "2026-06-00T24:00" returned 2026-06-01 00:00 and "0000-12-...

Opengraph URL: https://github.com/python/cpython/pull/162307

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:af6e785a-fa7a-5f58-1504-4dd66beec489
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC2C:299992:12F1171:19087B4:6B01EBCF
html-safe-noncee11071d04ee0394b640f6b7ad5d602ccc9634e9e344a6c7ec7a7435d709230be
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzJDOjI5OTk5MjoxMkYxMTcxOjE5MDg3QjQ6NkIwMUVCQ0YiLCJ2aXNpdG9yX2lkIjoiMjkwMjM2MTk1MjA3NDQ2MDExMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9e254538680966fa9b80731f86573fdd0898a0ae57fe579dfba7f8b047961062
hovercard-subject-tagpull_request:5407955553
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/162307/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f1ffc74a32eab9a6442680c6b7564f30af36cbcc0c2275f7f533c516ddb6b045/python/cpython/pull/162307
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f1ffc74a32eab9a6442680c6b7564f30af36cbcc0c2275f7f533c516ddb6b045/python/cpython/pull/162307
og:image:altdatetime.fromisoformat() rolled a 24:00 time over to the next day even when the day was 0 or the year was 0, so "2026-06-00T24:00" returned 2026-06-01 00:00 and "0000-12-31T24:00&quo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechoam2426
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/162307#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162307
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162307
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162307
Reloadhttps://github.com/python/cpython/pull/162307
Reloadhttps://github.com/python/cpython/pull/162307
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
choam2426https://github.com/choam2426
python:mainhttps://github.com/python/cpython/tree/main
choam2426:fromisoformat-24-lower-boundshttps://github.com/choam2426/cpython/tree/fromisoformat-24-lower-bounds
Conversationhttps://github.com/python/cpython/pull/162307
Commits3 (3)https://github.com/python/cpython/pull/162307/commits
Checkshttps://github.com/python/cpython/pull/162307/checks
Files changedhttps://github.com/python/cpython/pull/162307/files
gh-162306: Reject day 0 and year 0 with a 24:00 time in datetime.fromisoformat()https://github.com/python/cpython/pull/162307#top
choam2426https://github.com/choam2426
python:mainhttps://github.com/python/cpython/tree/main
choam2426:fromisoformat-24-lower-boundshttps://github.com/choam2426/cpython/tree/fromisoformat-24-lower-bounds
https://github.com/choam2426
choam2426https://github.com/choam2426
Nov 20, 2026https://github.com/python/cpython/pull/162307#issue-6505051307
gh-151770https://github.com/python/cpython/issues/151770
datetime.fromisoformat() accepts day 0 and year 0 combined with a 24:00 time #162306https://github.com/python/cpython/issues/162306
Please reload this pagehttps://github.com/python/cpython/pull/162307
https://github.com/choam2426
pythongh-162306https://github.com/python/cpython/issues/162306
: Reject day 0 and year 0 with a 24:00 time in datetim…https://github.com/python/cpython/pull/162307/commits/7b3f68d7ae5fc390b9014cfa8969201dc1ff136f
7b3f68dhttps://github.com/python/cpython/pull/162307/commits/7b3f68d7ae5fc390b9014cfa8969201dc1ff136f
https://github.com/choam2426
choam2426https://github.com/choam2426
StanFromIrelandhttps://github.com/StanFromIreland
pgansslehttps://github.com/pganssle
code ownershttps://github.com/python/cpython/blob/b09a7e92fb0ab958a52ad94e376402cdd3da09b2/.github/CODEOWNERS#L433
November 20, 2026 04:51https://github.com/python/cpython/pull/162307#event-36733283162
https://github.com/apps/python-cla-bot
python-cla-bothttps://github.com/apps/python-cla-bot
Nov 20, 2026https://github.com/python/cpython/pull/162307#issuecomment-7030774002
Please reload this pagehttps://github.com/python/cpython/pull/162307
https://cla.python.org/
Please reload this pagehttps://github.com/python/cpython/pull/162307
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 20, 2026 https://github.com/python/cpython/pull/162307#ref-issue-6505045315
datetime.fromisoformat() accepts day 0 and year 0 combined with a 24:00 time #162306 https://github.com/python/cpython/issues/162306
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 20, 2026https://github.com/python/cpython/pull/162307#event-36733291030
https://github.com/gabrielrbl
gabrielrblhttps://github.com/gabrielrbl
Nov 20, 2026https://github.com/python/cpython/pull/162307#issuecomment-7033727612
7b3f68dhttps://github.com/python/cpython/commit/7b3f68d7ae5fc390b9014cfa8969201dc1ff136f
Please reload this pagehttps://github.com/python/cpython/pull/162307
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
Nov 20, 2026 https://github.com/python/cpython/pull/162307#pullrequestreview-5998764303
View reviewed changes https://github.com/python/cpython/pull/162307/files/7b3f68d7ae5fc390b9014cfa8969201dc1ff136f
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/162307/files/7b3f68d7ae5fc390b9014cfa8969201dc1ff136f#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
eendebakpthttps://github.com/eendebakpt
Nov 20, 2026https://github.com/python/cpython/pull/162307#discussion_r4647194697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
gh-102450https://github.com/python/cpython/issues/102450
@pgansslehttps://github.com/pganssle
Please reload this pagehttps://github.com/python/cpython/pull/162307
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Nov 21, 2026https://github.com/python/cpython/pull/162307#issuecomment-7057477141
Please reload this pagehttps://github.com/python/cpython/pull/162307
https://github.com/choam2426
choam2426https://github.com/choam2426
Nov 21, 2026https://github.com/python/cpython/pull/162307#issuecomment-7058082402
Please reload this pagehttps://github.com/python/cpython/pull/162307
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Nov 21, 2026https://github.com/python/cpython/pull/162307#issuecomment-7058436911
@choam2426https://github.com/choam2426
Please reload this pagehttps://github.com/python/cpython/pull/162307
choam2426https://github.com/choam2426
November 21, 2026 16:49https://github.com/python/cpython/pull/162307#commits-pushed-e5134a0
https://github.com/choam2426
Keep accepting year 0 with a 24:00 time that rolls over into year 1https://github.com/python/cpython/pull/162307/commits/e5134a08d05b0c016dc35146ee8be3287bc7259f
e5134a0https://github.com/python/cpython/pull/162307/commits/e5134a08d05b0c016dc35146ee8be3287bc7259f
https://github.com/choam2426
Test that year 0 with a 24:00 time rolls over into year 1https://github.com/python/cpython/pull/162307/commits/420be2589a804001c21b9eb05ee256a5483c4a07
420be25https://github.com/python/cpython/pull/162307/commits/420be2589a804001c21b9eb05ee256a5483c4a07
https://github.com/choam2426
choam2426https://github.com/choam2426
Nov 21, 2026https://github.com/python/cpython/pull/162307#issuecomment-7059576334
Please reload this pagehttps://github.com/python/cpython/pull/162307
@pgansslehttps://github.com/pganssle
Please reload this pagehttps://github.com/python/cpython/pull/162307
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162307
https://github.com/eendebakpt
eendebakpt https://github.com/eendebakpt
https://github.com/python/cpython/pull/162307/files/7b3f68d7ae5fc390b9014cfa8969201dc1ff136f
https://github.com/pganssle
pganssle https://github.com/pganssle
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
Please reload this pagehttps://github.com/python/cpython/pull/162307
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/162307
https://github.com/choam2426
https://github.com/gabrielrbl
https://github.com/pganssle
https://github.com/eendebakpt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.