René's URL Explorer Experiment


Title: gh-162246: Fix lost writes on `BufferedRWPair` dealloc by maurycy · Pull Request #162295 · python/cpython · GitHub

Open Graph Title: gh-162246: Fix lost writes on `BufferedRWPair` dealloc by maurycy · Pull Request #162295 · python/cpython

X Title: gh-162246: Fix lost writes on `BufferedRWPair` dealloc by maurycy · Pull Request #162295 · python/cpython

Description: socket.makefile("rwb") passes the same raw stream to both sides of a BufferedRWPair. When the pair is deallocated, the reader closes the stream before the writer can flush its buffer. Release the writer first, matching the order in BufferedRWPair.close(). Issue: gh-162246

Open Graph Description: socket.makefile("rwb") passes the same raw stream to both sides of a BufferedRWPair. When the pair is deallocated, the reader closes the stream before the writer can flush its buffer. Rel...

X Description: socket.makefile("rwb") passes the same raw stream to both sides of a BufferedRWPair. When the pair is deallocated, the reader closes the stream before the writer can flush its buf...

Opengraph URL: https://github.com/python/cpython/pull/162295

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:08ff94ec-693c-a14b-0f43-5ca639db1fd6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9306:3CBB3E:30580B1:3DB9A40:6B020E8C
html-safe-nonce76205377aa5431ee198735b496aa58807d0087a1661d85035b5a7976778ac231
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzA2OjNDQkIzRTozMDU4MEIxOjNEQjlBNDA6NkIwMjBFOEMiLCJ2aXNpdG9yX2lkIjoiNTc0OTgxNDg4NDM2Nzk5NDUwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac88e363575a4846dc01fe2128367f51f483354bb3693f2295289396edd4d0f72a
hovercard-subject-tagpull_request:5403799657
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162295/files
twitter:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
og:image:altsocket.makefile("rwb") passes the same raw stream to both sides of a BufferedRWPair. When the pair is deallocated, the reader closes the stream before the writer can flush its buffer. Rel...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162295/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162295%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162295%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162295/files
Reloadhttps://github.com/python/cpython/pull/162295/files
Reloadhttps://github.com/python/cpython/pull/162295/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
cmaloneyhttps://github.com/cmaloney
python:mainhttps://github.com/python/cpython/tree/main
maurycy:gh-162246-bufferedrwpair-data-losshttps://github.com/maurycy/cpython/tree/gh-162246-bufferedrwpair-data-loss
Conversation 12 https://github.com/python/cpython/pull/162295
Commits 7 https://github.com/python/cpython/pull/162295/commits
Checks 59 https://github.com/python/cpython/pull/162295/checks
Files changed https://github.com/python/cpython/pull/162295/files
Please reload this pagehttps://github.com/python/cpython/pull/162295/files
gh-162246: Fix lost writes on BufferedRWPair dealloc https://github.com/python/cpython/pull/162295/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/162295/files
9ed31c5 up maurycy Nov 19, 2026 https://github.com/python/cpython/pull/162295/commits/9ed31c5e8d9a738411bf545db637790d40b233b4
07e5cd4 news maurycy Nov 19, 2026 https://github.com/python/cpython/pull/162295/commits/07e5cd481bdcf459dce1c9d4f0d3f97467347179
bafcd1e test maurycy Nov 19, 2026 https://github.com/python/cpython/pull/162295/commits/bafcd1eb13e504682e232b1df473d35a0b8c1367
d617375 too verbose maurycy Nov 19, 2026 https://github.com/python/cpython/pull/162295/commits/d617375b04e09cd94546329ef1fcde94a51c4dce
bbb66e7 raw._write_stack maurycy Nov 19, 2026 https://github.com/python/cpython/pull/162295/commits/bbb66e7c9c58a77c6b9942e0684595951de1b5e5
e2aa79a comment maurycy Nov 20, 2026 https://github.com/python/cpython/pull/162295/commits/e2aa79a4d34978a53f65731073062cd10877d7af
c8ca743 Merge remote-tracking branch 'upstream/main' into pr162295 maurycy Nov 20, 2026 https://github.com/python/cpython/pull/162295/commits/c8ca7431f512c22b68c7e253ecbe699ba8974582
Clear filters https://github.com/python/cpython/pull/162295/files
Please reload this pagehttps://github.com/python/cpython/pull/162295/files
Please reload this pagehttps://github.com/python/cpython/pull/162295/files
test_bufferedio.py https://github.com/python/cpython/pull/162295/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
2026-11-19-22-01-29.gh-issue-162246.y3L8nP.rst https://github.com/python/cpython/pull/162295/files#diff-d2ebd3b6d1f6f645a78d455a11468261109c589d2784fc4d4520253229bc7411
bufferedio.c https://github.com/python/cpython/pull/162295/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L526
Lib/test/test_io/test_bufferedio.pyhttps://github.com/python/cpython/pull/162295/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
View file https://github.com/maurycy/cpython/blob/c8ca7431f512c22b68c7e253ecbe699ba8974582/Lib/test/test_io/test_bufferedio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162295/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162295/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
https://github.com/python/cpython/pull/162295/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
Misc/NEWS.d/next/Library/2026-11-19-22-01-29.gh-issue-162246.y3L8nP.rsthttps://github.com/python/cpython/pull/162295/files#diff-d2ebd3b6d1f6f645a78d455a11468261109c589d2784fc4d4520253229bc7411
View file https://github.com/maurycy/cpython/blob/c8ca7431f512c22b68c7e253ecbe699ba8974582/Misc/NEWS.d/next/Library/2026-11-19-22-01-29.gh-issue-162246.y3L8nP.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162295/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L527
Modules/_io/bufferedio.chttps://github.com/python/cpython/pull/162295/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
View file https://github.com/maurycy/cpython/blob/c8ca7431f512c22b68c7e253ecbe699ba8974582/Modules/_io/bufferedio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162295/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162295/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/162295/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
Please reload this pagehttps://github.com/python/cpython/pull/162295/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.