René's URL Explorer Experiment


Title: gh-162246: Fix lost writes on `BufferedRWPair` dealloc by maurycy · Pull Request #162295 · python/cpython · GitHub

Open Graph Title: gh-162246: Fix lost writes on `BufferedRWPair` dealloc by maurycy · Pull Request #162295 · python/cpython

X Title: gh-162246: Fix lost writes on `BufferedRWPair` dealloc by maurycy · Pull Request #162295 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: socket.makefile("rwb") passes the same raw stream to both sides of a BufferedRWPair. When the pair is deallocated, the reader closes the stream before the writer can flush its buffer. Rel...

X Description: socket.makefile("rwb") passes the same raw stream to both sides of a BufferedRWPair. When the pair is deallocated, the reader closes the stream before the writer can flush its buf...

Opengraph URL: https://github.com/python/cpython/pull/162295

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:993b0318-19be-2a6a-ed06-955811e05f25
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9702:76F02:3AC2207:4B1CD09:6B01FFD5
html-safe-nonce1042298ecfd3501e405506c5a2d887dea31115d7c91c68901c60c32c645e20d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzAyOjc2RjAyOjNBQzIyMDc6NEIxQ0QwOTo2QjAxRkZENSIsInZpc2l0b3JfaWQiOiI1NzE2MDY1ODk4OTM5NDE2NTM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2dc9ad7a330f236c994f8f2ba24b715697c6e6902c06ebad26c60409eccfba55
hovercard-subject-tagpull_request:5403799657
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/162295/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/731335eda3cafb47e775d00ea080552c06b9cf915c6d18b0394baed9e03aad6a/python/cpython/pull/162295
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/731335eda3cafb47e775d00ea080552c06b9cf915c6d18b0394baed9e03aad6a/python/cpython/pull/162295
og:image:altsocket.makefile("rwb") passes the same raw stream to both sides of a BufferedRWPair. When the pair is deallocated, the reader closes the stream before the writer can flush its buffer. Rel...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaurycy
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/162295#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162295
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162295
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162295
Reloadhttps://github.com/python/cpython/pull/162295
Reloadhttps://github.com/python/cpython/pull/162295
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
cmaloneyhttps://github.com/cmaloney
python:mainhttps://github.com/python/cpython/tree/main
maurycy:gh-162246-bufferedrwpair-data-losshttps://github.com/maurycy/cpython/tree/gh-162246-bufferedrwpair-data-loss
Conversationhttps://github.com/python/cpython/pull/162295
Commits7 (7)https://github.com/python/cpython/pull/162295/commits
Checkshttps://github.com/python/cpython/pull/162295/checks
Files changedhttps://github.com/python/cpython/pull/162295/files
gh-162246: Fix lost writes on BufferedRWPair deallochttps://github.com/python/cpython/pull/162295#top
cmaloneyhttps://github.com/cmaloney
python:mainhttps://github.com/python/cpython/tree/main
maurycy:gh-162246-bufferedrwpair-data-losshttps://github.com/maurycy/cpython/tree/gh-162246-bufferedrwpair-data-loss
https://github.com/maurycy
maurycyhttps://github.com/maurycy
Nov 19, 2026https://github.com/python/cpython/pull/162295#issue-6500039930
Please reload this pagehttps://github.com/python/cpython/pull/162295
Bring BufferedRWPair to parity with other BufferedIO code #162246https://github.com/python/cpython/issues/162246
Please reload this pagehttps://github.com/python/cpython/pull/162295
maurycyhttps://github.com/maurycy
November 19, 2026 23:05https://github.com/python/cpython/pull/162295#commits-pushed-9ed31c5
https://github.com/maurycy
uphttps://github.com/python/cpython/pull/162295/commits/9ed31c5e8d9a738411bf545db637790d40b233b4
9ed31c5https://github.com/python/cpython/pull/162295/commits/9ed31c5e8d9a738411bf545db637790d40b233b4
https://github.com/maurycy
newshttps://github.com/python/cpython/pull/162295/commits/07e5cd481bdcf459dce1c9d4f0d3f97467347179
07e5cd4https://github.com/python/cpython/pull/162295/commits/07e5cd481bdcf459dce1c9d4f0d3f97467347179
https://github.com/maurycy
testhttps://github.com/python/cpython/pull/162295/commits/bafcd1eb13e504682e232b1df473d35a0b8c1367
bafcd1ehttps://github.com/python/cpython/pull/162295/commits/bafcd1eb13e504682e232b1df473d35a0b8c1367
https://github.com/maurycy
too verbosehttps://github.com/python/cpython/pull/162295/commits/d617375b04e09cd94546329ef1fcde94a51c4dce
d617375https://github.com/python/cpython/pull/162295/commits/d617375b04e09cd94546329ef1fcde94a51c4dce
https://github.com/maurycy
maurycyhttps://github.com/maurycy
cmaloneyhttps://github.com/cmaloney
code ownerhttps://github.com/python/cpython/blob/865d8d8f890352f5bb0ff58b7707179c8b046f8e/.github/CODEOWNERS#L526
November 19, 2026 22:08https://github.com/python/cpython/pull/162295#event-36705855589
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 19, 2026 https://github.com/python/cpython/pull/162295#ref-issue-6478954026
Bring BufferedRWPair to parity with other BufferedIO code #162246 https://github.com/python/cpython/issues/162246
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 19, 2026https://github.com/python/cpython/pull/162295#event-36705867666
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Nov 19, 2026 https://github.com/python/cpython/pull/162295#pullrequestreview-5984227154
View reviewed changes https://github.com/python/cpython/pull/162295/files/d617375b04e09cd94546329ef1fcde94a51c4dce
Lib/test/test_io/test_bufferedio.pyhttps://github.com/python/cpython/pull/162295/files/d617375b04e09cd94546329ef1fcde94a51c4dce#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 19, 2026https://github.com/python/cpython/pull/162295#event-36706139439
https://github.com/maurycy
raw._write_stackhttps://github.com/python/cpython/pull/162295/commits/bbb66e7c9c58a77c6b9942e0684595951de1b5e5
bbb66e7https://github.com/python/cpython/pull/162295/commits/bbb66e7c9c58a77c6b9942e0684595951de1b5e5
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Nov 19, 2026 https://github.com/python/cpython/pull/162295#pullrequestreview-5984554700
View reviewed changes https://github.com/python/cpython/pull/162295/files/bbb66e7c9c58a77c6b9942e0684595951de1b5e5
cmaloneyhttps://github.com/cmaloney
https://github.com/python/cpython/pull/162295#pullrequestreview-5984554700
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 19, 2026https://github.com/python/cpython/pull/162295#event-36708419745
maurycyhttps://github.com/maurycy
November 20, 2026 11:37https://github.com/python/cpython/pull/162295#commits-pushed-e2aa79a
https://github.com/maurycy
commenthttps://github.com/python/cpython/pull/162295/commits/e2aa79a4d34978a53f65731073062cd10877d7af
e2aa79ahttps://github.com/python/cpython/pull/162295/commits/e2aa79a4d34978a53f65731073062cd10877d7af
https://github.com/maurycy
Merge remote-tracking branch 'upstream/main' into pr162295https://github.com/python/cpython/pull/162295/commits/c8ca7431f512c22b68c7e253ecbe699ba8974582
c8ca743https://github.com/python/cpython/pull/162295/commits/c8ca7431f512c22b68c7e253ecbe699ba8974582
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
dc222c8https://github.com/python/cpython/commit/dc222c8d6c366e3d52d4b0d0053ad7bb8a601fff
Nov 21, 2026https://github.com/python/cpython/pull/162295#event-36829396406
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 21, 2026https://github.com/python/cpython/pull/162295#issuecomment-7055148942
@maurycyhttps://github.com/maurycy
@cmaloneyhttps://github.com/cmaloney
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 21, 2026https://github.com/python/cpython/pull/162295#event-36829399951
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 21, 2026https://github.com/python/cpython/pull/162295#issuecomment-7055149797
@maurycyhttps://github.com/maurycy
@cmaloneyhttps://github.com/cmaloney
cherry_pickerhttps://pypi.org/project/cherry-picker/
devguidehttps://devguide.python.org/getting-started/git-boot-camp/#backporting-merged-changes
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
cmaloneyhttps://github.com/cmaloney
Nov 21, 2026https://github.com/python/cpython/pull/162295#event-36829404399
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 21, 2026https://github.com/python/cpython/pull/162295#issuecomment-7055150922
@maurycyhttps://github.com/maurycy
@cmaloneyhttps://github.com/cmaloney
cherry_pickerhttps://pypi.org/project/cherry-picker/
devguidehttps://devguide.python.org/getting-started/git-boot-camp/#backporting-merged-changes
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 21, 2026https://github.com/python/cpython/pull/162295#issuecomment-7055356419
dc222c8https://github.com/python/cpython/commit/dc222c8d6c366e3d52d4b0d0053ad7bb8a601fff
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#/builders/1366/builds/8615https://buildbot.python.org/#/builders/1366/builds/8615
dc222c8https://github.com/python/cpython/commit/dc222c8d6c366e3d52d4b0d0053ad7bb8a601fff
https://buildbot.python.org/#/builders/1366/builds/8615https://buildbot.python.org/#/builders/1366/builds/8615
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 21, 2026https://github.com/python/cpython/pull/162295#issuecomment-7055392364
GH-162344https://github.com/python/cpython/pull/162344
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 21, 2026https://github.com/python/cpython/pull/162295#event-36830340129
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 21, 2026https://github.com/python/cpython/pull/162295#issuecomment-7055394358
GH-162345https://github.com/python/cpython/pull/162345
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Nov 21, 2026https://github.com/python/cpython/pull/162295#event-36830346973
cmaloneyhttps://github.com/cmaloney
Nov 21, 2026 https://github.com/python/cpython/pull/162295#ref-commit-a8474ce
https://github.com/cmaloney
https://github.com/maurycy
[3.14]https://github.com/python/cpython/commit/a8474ce7a9645a9a824bf9a4a69bf2b004bb1c34
gh-162246https://github.com/python/cpython/issues/162246
: Fix lost writes onhttps://github.com/python/cpython/commit/a8474ce7a9645a9a824bf9a4a69bf2b004bb1c34
BufferedRWPairhttps://github.com/python/cpython/commit/a8474ce7a9645a9a824bf9a4a69bf2b004bb1c34
dealloc (https://github.com/python/cpython/commit/a8474ce7a9645a9a824bf9a4a69bf2b004bb1c34
GH-162295https://github.com/python/cpython/pull/162295
a8474cehttps://github.com/python/cpython/commit/a8474ce7a9645a9a824bf9a4a69bf2b004bb1c34
https://github.com/python/cpython/pull/162295
#162345https://github.com/python/cpython/pull/162345
dc222c8https://github.com/python/cpython/commit/dc222c8d6c366e3d52d4b0d0053ad7bb8a601fff
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 21, 2026https://github.com/python/cpython/pull/162295#issuecomment-7056340688
GH-162351https://github.com/python/cpython/pull/162351
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/maurycy
maurycyhttps://github.com/maurycy
November 21, 2026 04:42https://github.com/python/cpython/pull/162295#event-36838246412
https://github.com/maurycy
maurycyhttps://github.com/maurycy
Nov 21, 2026https://github.com/python/cpython/pull/162295#issuecomment-7057884788
Please reload this pagehttps://github.com/python/cpython/pull/162295
@cmaloneyhttps://github.com/cmaloney
Please reload this pagehttps://github.com/python/cpython/pull/162295
cmaloneyhttps://github.com/cmaloney
Nov 21, 2026 https://github.com/python/cpython/pull/162295#ref-commit-8a05f92
https://github.com/cmaloney
https://github.com/maurycy
[3.15]https://github.com/python/cpython/commit/8a05f92bfe23055191f7995385ef5946a9d37888
gh-162246https://github.com/python/cpython/issues/162246
: Fix lost writes onhttps://github.com/python/cpython/commit/8a05f92bfe23055191f7995385ef5946a9d37888
BufferedRWPairhttps://github.com/python/cpython/commit/8a05f92bfe23055191f7995385ef5946a9d37888
dealloc (https://github.com/python/cpython/commit/8a05f92bfe23055191f7995385ef5946a9d37888
GH-162295https://github.com/python/cpython/pull/162295
8a05f92https://github.com/python/cpython/commit/8a05f92bfe23055191f7995385ef5946a9d37888
https://github.com/python/cpython/pull/162295
#162351https://github.com/python/cpython/pull/162351
dc222c8https://github.com/python/cpython/commit/dc222c8d6c366e3d52d4b0d0053ad7bb8a601fff
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Nov 21, 2026https://github.com/python/cpython/pull/162295#issuecomment-7057966942
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162295
https://github.com/cmaloney
cmaloney https://github.com/cmaloney
https://github.com/python/cpython/pull/162295/files/bbb66e7c9c58a77c6b9942e0684595951de1b5e5
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/cmaloney
cmaloney https://github.com/cmaloney
Please reload this pagehttps://github.com/python/cpython/pull/162295
https://github.com/maurycy
https://github.com/bedevere-bot
https://github.com/cmaloney
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.