René's URL Explorer Experiment


Title: gh-129813: Use `PyBytesWriter` in `binascii` by maurycy · Pull Request #162259 · python/cpython · GitHub

Open Graph Title: gh-129813: Use `PyBytesWriter` in `binascii` by maurycy · Pull Request #162259 · python/cpython

X Title: gh-129813: Use `PyBytesWriter` in `binascii` by maurycy · Pull Request #162259 · python/cpython

Description: Use PyBytesWriter in binascii.b2a_qp() and a2b_qp(), spares a temp buffer and a copy. This extends #138825. This is mostly a simplification but there's memory improvement: Function and input Result size Baseline peak Patched peak b2a_qp text 1,048,576 2,097,185 1,048,609 b2a_qp binary 3,229,614 6,459,261 3,229,647 a2b_qp text 1,048,576 2,359,329 1,310,753 a2b_qp hex escapes 349,525 1,398,133 1,048,608 a2b_qp soft breaks 0 1,048,575 1,048,608 And pyperf improvement: Function and input Baseline 1 Patched 1 Baseline 2 Patched 2 b2a_qp 12 B 76.6 ns 74.1 ns 77 ns 75.8 ns b2a_qp 255 B 1.21 µs 1.22 µs 1.23 µs 1.24 µs b2a_qp text 4.73 ms 4.73 ms 4.72 ms 4.76 ms b2a_qp binary 2 ms 1.85 ms 2 ms 1.74 ms a2b_qp 12 B 34.4 ns 36.5 ns 35.1 ns 32.4 ns a2b_qp text 886 µs 887 µs 883 µs 898 µs a2b_qp hex escapes 447 µs 435 µs 444 µs 439 µs a2b_qp soft breaks 419 µs 420 µs 416 µs 424 µs a2b_hex control 125 ns 128 ns 127 ns 127 ns (PGO+LTO, macOS arm64) memory measure import binascii import tracemalloc for func, case, data in ( (binascii.b2a_qp, "text", b"abc def\n" * 131072), (binascii.b2a_qp, "binary", b"\xff" * 1048576), (binascii.a2b_qp, "text", b"abc=20def\n" * 131072), (binascii.a2b_qp, "hex escapes", b"=FF" * 349525), (binascii.a2b_qp, "soft breaks", b"=\r\n" * 349525), ): tracemalloc.start() result = func(data) _, peak = tracemalloc.get_traced_memory() tracemalloc.stop() print(func.__name__, case, len(result), peak) del result pyperf benchmark import binascii import pyperf runner = pyperf.Runner() for func, case, data in ( (binascii.b2a_qp, "12 B", b"Hello world!"), (binascii.b2a_qp, "255 B", b"a" * 255), (binascii.b2a_qp, "text", b"abc def\n" * 131072), (binascii.b2a_qp, "binary", b"\xff" * 1048576), (binascii.a2b_qp, "12 B", b"Hello world!"), (binascii.a2b_qp, "text", b"abc=20def\n" * 131072), (binascii.a2b_qp, "hex escapes", b"=FF" * 349525), (binascii.a2b_qp, "soft breaks", b"=\r\n" * 349525), (binascii.a2b_hex, "control", b"ab" * 128), ): runner.timeit(f"{func.__name__} {case}", "func(data)", globals={"func": func, "data": data}) Issue: gh-129813

Open Graph Description: Use PyBytesWriter in binascii.b2a_qp() and a2b_qp(), spares a temp buffer and a copy. This extends #138825. This is mostly a simplification but there's memory improvement: Function and input...

X Description: Use PyBytesWriter in binascii.b2a_qp() and a2b_qp(), spares a temp buffer and a copy. This extends #138825. This is mostly a simplification but there's memory improvement: Function and i...

Opengraph URL: https://github.com/python/cpython/pull/162259

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b28a6504-c34a-88bf-3c1b-275d4553c967
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7E4:38EE04:159DDBD:1C969CE:6B01FC2D
html-safe-noncecfbecb51caa0f5b1c94b9a77c3e13e6ab1d9142e1bac5f9ac9a0c4ef5348a9b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0U0OjM4RUUwNDoxNTlEREJEOjFDOTY5Q0U6NkIwMUZDMkQiLCJ2aXNpdG9yX2lkIjoiNzY5NjY5NjQ3MTI4NjA1MzkzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac315c7dca55c4de8f7bb27d332747f4ea1c4d9a1ecf54a8745b6e5adfcb538c7d
hovercard-subject-tagpull_request:5391569795
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162259/files
twitter:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
og:image:altUse PyBytesWriter in binascii.b2a_qp() and a2b_qp(), spares a temp buffer and a copy. This extends #138825. This is mostly a simplification but there's memory improvement: Function and input...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162259/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162259%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162259%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162259/files
Reloadhttps://github.com/python/cpython/pull/162259/files
Reloadhttps://github.com/python/cpython/pull/162259/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
maurycy:binascii-qp-pybyteswriterhttps://github.com/maurycy/cpython/tree/binascii-qp-pybyteswriter
Conversation 4 https://github.com/python/cpython/pull/162259
Commits 1 https://github.com/python/cpython/pull/162259/commits
Checks 62 https://github.com/python/cpython/pull/162259/checks
Files changed 1 https://github.com/python/cpython/pull/162259/files
gh-129813: Use PyBytesWriter in binascii https://github.com/python/cpython/pull/162259/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/162259/files
4ebffea up maurycy Nov 19, 2026 https://github.com/python/cpython/pull/162259/commits/4ebffeafde62730e4c7064f773cf1295562d9e54
Clear filters https://github.com/python/cpython/pull/162259/files
Please reload this pagehttps://github.com/python/cpython/pull/162259/files
Please reload this pagehttps://github.com/python/cpython/pull/162259/files
Modules/binascii.chttps://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
View file https://github.com/maurycy/cpython/blob/4ebffeafde62730e4c7064f773cf1295562d9e54/Modules/binascii.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162259/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
https://github.com/python/cpython/pull/162259/files#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
Please reload this pagehttps://github.com/python/cpython/pull/162259/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.