Title: gh-129813: Use `PyBytesWriter` for strided mmap slices by maurycy · Pull Request #162257 · python/cpython · GitHub
Open Graph Title: gh-129813: Use `PyBytesWriter` for strided mmap slices by maurycy · Pull Request #162257 · python/cpython
X Title: gh-129813: Use `PyBytesWriter` for strided mmap slices by maurycy · Pull Request #162257 · python/cpython
Description: Write large strided slices directly to the result, saving one alloc + copy. The PR extends #138831 to slices such as m[::2]. This is mostly a simplification but it's good on the memory front: Slice Result size Peak before (bytes) Peak after (bytes) m[::2] 4 KiB 8,225 4,129 m[::2] 8 MiB 16,777,249 8,388,641 m[::-1] 8 MiB 16,777,249 8,388,641 m[::1] (control) 8 MiB 8,388,641 8,388,641 No regression on the performance front: Slice Result size Round 1 baseline Round 1 patched Round 2 baseline Round 2 patched m[::2] 32 B 31.3 ns 30.4 ns 31.7 ns 30.5 ns m[::2] 4 KiB 1.14 µs 1.07 µs 1.15 µs 1.12 µs m[::2] 8 MiB 2.34 ms 2.10 ms 2.38 ms 2.12 ms m[::-1] 8 MiB 2.30 ms 2.15 ms 2.28 ms 2.08 ms m[::1] (control) 8 MiB 123 µs 126 µs 118 µs 159 µs (both on macOS arm64) Reproduce memory measurements import mmap import tracemalloc def measure(size, step): with mmap.mmap(-1, size * abs(step)) as m: key = slice(None, None, step) tracemalloc.start() result = m[key] current, peak = tracemalloc.get_traced_memory() tracemalloc.stop() assert len(result) == size print(size, step, current, peak) for size, step in [(4096, 2), (8 << 20, 2), (8 << 20, -1), (8 << 20, 1)]: measure(size, step) pyperf import mmap import pyperf runner = pyperf.Runner() runner.metadata["mmap_module"] = mmap.__file__ for size, step in ((32, 2), (4096, 2), (8 << 20, 2), (8 << 20, -1), (8 << 20, 1)): length = size * abs(step) with mmap.mmap(-1, length) as mapping: mapping[:] = b"x" * length runner.timeit( f"mmap[::{step}], {size} output bytes", stmt=f"mapping[::{step}]", globals={"mapping": mapping}, ) Issue: gh-129813
Open Graph Description: Write large strided slices directly to the result, saving one alloc + copy. The PR extends #138831 to slices such as m[::2]. This is mostly a simplification but it's good on the memory front: ...
X Description: Write large strided slices directly to the result, saving one alloc + copy. The PR extends #138831 to slices such as m[::2]. This is mostly a simplification but it's good on the memory fron...
Opengraph URL: https://github.com/python/cpython/pull/162257
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cf61bff2-5766-f177-f937-c514b8c7f356 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C5FC:FC5BE:348DCC6:45D51E9:6B01FC10 |
| html-safe-nonce | f4433baf08b0632931be4334094651a5a83157623ac9c7646a04fdfbce76be0c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUZDOkZDNUJFOjM0OERDQzY6NDVENTFFOTo2QjAxRkMxMCIsInZpc2l0b3JfaWQiOiI2MTIwNjgzMzY0NzU3NDA0Njg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 17210344b7579c6727c155b400d0e15c422a22548add057947dab7c2f71c0221 |
| hovercard-subject-tag | pull_request:5391023696 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/162257/files |
| twitter:image | https://avatars.githubusercontent.com/u/5383?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5383?s=400&v=4 |
| og:image:alt | Write large strided slices directly to the result, saving one alloc + copy. The PR extends #138831 to slices such as m[::2]. This is mostly a simplification but it's good on the memory front: ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width