René's URL Explorer Experiment


Title: gh-135122: Raise NotADirectoryError in ntpath.realpath(strict=ALLOW_MISSING) by zaidwhy · Pull Request #162102 · python/cpython · GitHub

Open Graph Title: gh-135122: Raise NotADirectoryError in ntpath.realpath(strict=ALLOW_MISSING) by zaidwhy · Pull Request #162102 · python/cpython

X Title: gh-135122: Raise NotADirectoryError in ntpath.realpath(strict=ALLOW_MISSING) by zaidwhy · Pull Request #162102 · python/cpython

Description: On Windows, ntpath.realpath() was treating paths that go through a file as if the parent folder was missing. This happens because Windows returns ERROR_PATH_NOT_FOUND for both a missing parent and a parent that is actually a file. Since ALLOW_MISSING ignores this error, it wasn't catching this case. I added a check to make sure the deepest existing parent is actually a directory when there's still part of the path left to resolve. This check only runs in strict modes and on paths that have already failed. With this change, file\x, file\x\y, and link-to-file\x now raise NotADirectoryError for both str and bytes paths. This matches POSIX behaviour and what the documentation already describes. Non-strict mode, strict=True, and ALL_BUT_LAST are unchanged. I also updated some existing assertions in test_realpath_mode that were expecting the old behaviour. The two ALLOW_MISSING cases for file/file2 and link/file2 previously asserted the old result. test_posixpath.py already expects NotADirectoryError for these same cases. Changing the Windows tests is part of fixing the inconsistency. This also means tarfile rejects archive paths that go through a file at the safety filter stage instead of failing later during extraction, matching POSIX behaviour. Testing Tested on a Windows build of main with Developer Mode enabled, so the symlink cases ran. test_ntpath: 112 run, 3 skipped, 0 failures. The new test and updated ALLOW_MISSING cases fail without the fix and pass with it. Ran 12 related test suites covering 5,333 tests. Both versions had the same 4 unrelated failures. AI assistance: I used AI assistance while working on this change and reviewing the implementation and tests. I reviewed and tested the final changes myself. Issue: gh-135122

Open Graph Description: On Windows, ntpath.realpath() was treating paths that go through a file as if the parent folder was missing. This happens because Windows returns ERROR_PATH_NOT_FOUND for both a missing parent and ...

X Description: On Windows, ntpath.realpath() was treating paths that go through a file as if the parent folder was missing. This happens because Windows returns ERROR_PATH_NOT_FOUND for both a missing parent and ...

Opengraph URL: https://github.com/python/cpython/pull/162102

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5d1d3f27-0db8-c486-8765-e2aa750a105a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC79E:213839:3E19375:4F43997:6B020803
html-safe-nonceaf203044d8afed0535af1f528415289747c6fd1cddea92c75d9c2803f92f16f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzlFOjIxMzgzOTozRTE5Mzc1OjRGNDM5OTc6NkIwMjA4MDMiLCJ2aXNpdG9yX2lkIjoiMTk3OTc1OTY3MDczODQyMTc2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3aec6860d63eb7eb83e73ecd1f8b04a7ca379e19ad60ea2577fb1820eff99c32
hovercard-subject-tagpull_request:5335527163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162102/files
twitter:imagehttps://avatars.githubusercontent.com/u/98871217?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/98871217?s=400&v=4
og:image:altOn Windows, ntpath.realpath() was treating paths that go through a file as if the parent folder was missing. This happens because Windows returns ERROR_PATH_NOT_FOUND for both a missing parent and ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162102/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162102%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162102%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162102/files
Reloadhttps://github.com/python/cpython/pull/162102/files
Reloadhttps://github.com/python/cpython/pull/162102/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zaidwhyhttps://github.com/zaidwhy
python:mainhttps://github.com/python/cpython/tree/main
zaidwhy:gh-135122-ntpath-realpath-allow-missinghttps://github.com/zaidwhy/cpython/tree/gh-135122-ntpath-realpath-allow-missing
Conversation 2 https://github.com/python/cpython/pull/162102
Commits 1 https://github.com/python/cpython/pull/162102/commits
Checks 52 https://github.com/python/cpython/pull/162102/checks
Files changed https://github.com/python/cpython/pull/162102/files
Please reload this pagehttps://github.com/python/cpython/pull/162102/files
gh-135122: Raise NotADirectoryError in ntpath.realpath(strict=ALLOW_MISSING) https://github.com/python/cpython/pull/162102/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/162102/files
a8d4f06 gh-135122: Raise NotADirectoryError in ntpath.realpath(strict=ALLOW_M… zaidwhy Nov 15, 2026 https://github.com/python/cpython/pull/162102/commits/a8d4f066ae15da7277c34377768a4ecfea48241d
Clear filters https://github.com/python/cpython/pull/162102/files
Please reload this pagehttps://github.com/python/cpython/pull/162102/files
Please reload this pagehttps://github.com/python/cpython/pull/162102/files
ntpath.py https://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
test_ntpath.py https://github.com/python/cpython/pull/162102/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
2026-11-15-20-06-52.gh-issue-135122.uchDVu.rst https://github.com/python/cpython/pull/162102/files#diff-0ffc3ccc4a24180d40d300c1191414d93ccc77b6ec9035f938059e69c347912e
Lib/ntpath.pyhttps://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
View file https://github.com/python/cpython/blob/a8d4f066ae15da7277c34377768a4ecfea48241d/Lib/ntpath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162102/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/pull/162102/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
Lib/test/test_ntpath.pyhttps://github.com/python/cpython/pull/162102/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
View file https://github.com/python/cpython/blob/a8d4f066ae15da7277c34377768a4ecfea48241d/Lib/test/test_ntpath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162102/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162102/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
https://github.com/python/cpython/pull/162102/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
https://github.com/python/cpython/pull/162102/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
https://github.com/python/cpython/pull/162102/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
https://github.com/python/cpython/pull/162102/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
Misc/NEWS.d/next/Library/2026-11-15-20-06-52.gh-issue-135122.uchDVu.rsthttps://github.com/python/cpython/pull/162102/files#diff-0ffc3ccc4a24180d40d300c1191414d93ccc77b6ec9035f938059e69c347912e
View file https://github.com/python/cpython/blob/a8d4f066ae15da7277c34377768a4ecfea48241d/Misc/NEWS.d/next/Library/2026-11-15-20-06-52.gh-issue-135122.uchDVu.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162102/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/162102/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.