René's URL Explorer Experiment


Title: gh-162087: Release the first mutex of a two-mutex critical section that begins during stop-the-world by maikschulze · Pull Request #162088 · python/cpython · GitHub

Open Graph Title: gh-162087: Release the first mutex of a two-mutex critical section that begins during stop-the-world by maikschulze · Pull Request #162088 · python/cpython

X Title: gh-162087: Release the first mutex of a two-mutex critical section that begins during stop-the-world by maikschulze · Pull Request #162088 · python/cpython

Description: _PyCriticalSection2_BeginSlow() returns early while the interpreter's world is stopped (added for gh-144513) and records no mutexes, so _PyCriticalSection2_End() unlocks nothing. When the inline fast path calls it with is_m1_locked, the first mutex is already locked, and it stayed locked after the section had ended. As suggested in the issue, the early return now records the first mutex in the critical section in that case, so that _PyCriticalSection2_End() unlocks it. The new test in _testinternalcapi begins a two-object critical section during a stop-the-world while the second object's mutex is held (standing in for a mutex handed off to a suspended thread), and checks that the first mutex is unlocked afterwards. It aborts on main and passes with the change. With the change the full test suite passes on macOS (free-threaded build). The early return is in 3.15 and, since 3.14.4, in 3.14, so this may want backports. I couldn't find code that reaches this path today; details are in the issue. I used an AI assistant to investigate this and draft the patch; I reviewed and tested the changes myself. Issue: gh-162087

Open Graph Description: _PyCriticalSection2_BeginSlow() returns early while the interpreter's world is stopped (added for gh-144513) and records no mutexes, so _PyCriticalSection2_End() unlocks nothing. When the inlin...

X Description: _PyCriticalSection2_BeginSlow() returns early while the interpreter's world is stopped (added for gh-144513) and records no mutexes, so _PyCriticalSection2_End() unlocks nothing. When the i...

Opengraph URL: https://github.com/python/cpython/pull/162088

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e8cefe2a-21cd-9d1f-fa76-773c211cb326
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD974:311640:3EC9022:4FC1D5B:6B0219A0
html-safe-noncecccb84e7a435cc66db94dd8384371ef139164889da8d5fdd87525bb7fcfb6e31
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTc0OjMxMTY0MDozRUM5MDIyOjRGQzFENUI6NkIwMjE5QTAiLCJ2aXNpdG9yX2lkIjoiMTUxNTE1MjI1MjQ4NjM1Mjk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac89c7969045d823e6719e143f6382ec95534a122853c208d57bf7d9250333b996
hovercard-subject-tagpull_request:5333181511
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162088/files
twitter:imagehttps://avatars.githubusercontent.com/u/4232812?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4232812?s=400&v=4
og:image:alt_PyCriticalSection2_BeginSlow() returns early while the interpreter's world is stopped (added for gh-144513) and records no mutexes, so _PyCriticalSection2_End() unlocks nothing. When the inlin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162088/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162088%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162088%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162088/files
Reloadhttps://github.com/python/cpython/pull/162088/files
Reloadhttps://github.com/python/cpython/pull/162088/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
maikschulzehttps://github.com/maikschulze
python:mainhttps://github.com/python/cpython/tree/main
maikschulze:gh-162087-critical-section2-stwhttps://github.com/maikschulze/cpython/tree/gh-162087-critical-section2-stw
Conversation 0 https://github.com/python/cpython/pull/162088
Commits 2 https://github.com/python/cpython/pull/162088/commits
Checks 70 https://github.com/python/cpython/pull/162088/checks
Files changed https://github.com/python/cpython/pull/162088/files
Please reload this pagehttps://github.com/python/cpython/pull/162088/files
gh-162087: Release the first mutex of a two-mutex critical section that begins during stop-the-world https://github.com/python/cpython/pull/162088/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/162088/files
9e7f901 gh-162087: Unlock the first mutex when a two-mutex critical section i… maikschulze Nov 16, 2026 https://github.com/python/cpython/pull/162088/commits/9e7f901f985dc9dac63a3d83b3cdd04fd9a1f6c9
b041c7d gh-162087: Record the first mutex instead of unlocking it early maikschulze Nov 16, 2026 https://github.com/python/cpython/pull/162088/commits/b041c7d0337a650e8c411c2bb04182c2605a11b3
Clear filters https://github.com/python/cpython/pull/162088/files
Please reload this pagehttps://github.com/python/cpython/pull/162088/files
Please reload this pagehttps://github.com/python/cpython/pull/162088/files
2026-11-16-09-00-00.gh-issue-162087.c2StwL.rst https://github.com/python/cpython/pull/162088/files#diff-7ef6760ed42621aae441ad9315b260ce828ae3d91f9d7094f6948f94166592d1
test_critical_sections.c https://github.com/python/cpython/pull/162088/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
critical_section.c https://github.com/python/cpython/pull/162088/files#diff-c66c2b2954abc99cf6954a83564904dcecf9ea2f44f8a032f246861875041ff9
Misc/NEWS.d/next/Core_and_Builtins/2026-11-16-09-00-00.gh-issue-162087.c2StwL.rsthttps://github.com/python/cpython/pull/162088/files#diff-7ef6760ed42621aae441ad9315b260ce828ae3d91f9d7094f6948f94166592d1
View file https://github.com/python/cpython/blob/b041c7d0337a650e8c411c2bb04182c2605a11b3/Misc/NEWS.d/next/Core_and_Builtins/2026-11-16-09-00-00.gh-issue-162087.c2StwL.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162088/{{ revealButtonHref }}
Modules/_testinternalcapi/test_critical_sections.chttps://github.com/python/cpython/pull/162088/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
View file https://github.com/python/cpython/blob/b041c7d0337a650e8c411c2bb04182c2605a11b3/Modules/_testinternalcapi/test_critical_sections.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162088/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162088/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
https://github.com/python/cpython/pull/162088/files#diff-902110173393c3f9b7f311a058506a57b9c77fb0c1cb853aeb63ad19d53479a9
Python/critical_section.chttps://github.com/python/cpython/pull/162088/files#diff-c66c2b2954abc99cf6954a83564904dcecf9ea2f44f8a032f246861875041ff9
View file https://github.com/python/cpython/blob/b041c7d0337a650e8c411c2bb04182c2605a11b3/Python/critical_section.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162088/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162088/files#diff-c66c2b2954abc99cf6954a83564904dcecf9ea2f44f8a032f246861875041ff9
https://github.com/python/cpython/pull/162088/files#diff-c66c2b2954abc99cf6954a83564904dcecf9ea2f44f8a032f246861875041ff9
Please reload this pagehttps://github.com/python/cpython/pull/162088/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.