René's URL Explorer Experiment


Title: bpo-29110: Fix file object leak in `aifc.open`. by Uberi · Pull Request #162 · python/cpython · GitHub

Open Graph Title: bpo-29110: Fix file object leak in `aifc.open`. by Uberi · Pull Request #162 · python/cpython

X Title: bpo-29110: Fix file object leak in `aifc.open`. by Uberi · Pull Request #162 · python/cpython

Description: When given an invalid AIFF file, aifc.open doesn't clean up after itself. This patch makes it close the file object if it was opened by the library. Also, it adds one unit test, test.aifc_test.AifcMiscTest.test_close_opened_files_on_error. The patch can be verified with ./python -m test -j0 test_aifc.

Open Graph Description: When given an invalid AIFF file, aifc.open doesn't clean up after itself. This patch makes it close the file object if it was opened by the library. Also, it adds one unit test, test.aifc_test....

X Description: When given an invalid AIFF file, aifc.open doesn't clean up after itself. This patch makes it close the file object if it was opened by the library. Also, it adds one unit test, test.aifc_t...

Opengraph URL: https://github.com/python/cpython/pull/162

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:15a8dc5e-6e35-3160-5ed4-5e47615e8356
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC176:251AC0:6F9303:93F7A8:6B0036F5
html-safe-nonce0bfaa822113849196a5571f8fc12abf20e08be046271b74978582d319b0b8044
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTc2OjI1MUFDMDo2RjkzMDM6OTNGN0E4OjZCMDAzNkY1IiwidmlzaXRvcl9pZCI6Ijc5MTYzNDUzMTIxNjYyOTUyODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace5fef16022eb999eef7025acc34fb90e1fff2d5b9b7efcc01429d2ffe333135c
hovercard-subject-tagpull_request:106881524
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/162/files
twitter:imagehttps://avatars.githubusercontent.com/u/437196?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/437196?s=400&v=4
og:image:altWhen given an invalid AIFF file, aifc.open doesn't clean up after itself. This patch makes it close the file object if it was opened by the library. Also, it adds one unit test, test.aifc_test....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/162/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F162%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/162/files
Reloadhttps://github.com/python/cpython/pull/162/files
Reloadhttps://github.com/python/cpython/pull/162/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
methanehttps://github.com/methane
python:masterhttps://github.com/python/cpython/tree/master
Uberi:bpo-29110https://github.com/Uberi/cpython/tree/bpo-29110
Conversation 17 https://github.com/python/cpython/pull/162
Commits 1 https://github.com/python/cpython/pull/162/commits
Checks 0 https://github.com/python/cpython/pull/162/checks
Files changed https://github.com/python/cpython/pull/162/files
Please reload this pagehttps://github.com/python/cpython/pull/162/files
bpo-29110: Fix file object leak in aifc.open. https://github.com/python/cpython/pull/162/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/162/files
e09c582 bpo-29110: Fix file object leak in `aifc.open` when given invalid AIF… Uberi Feb 18, 2017 https://github.com/python/cpython/pull/162/commits/e09c582d908b697035b3a63287f0c670dea67039
Clear filters https://github.com/python/cpython/pull/162/files
Please reload this pagehttps://github.com/python/cpython/pull/162/files
Please reload this pagehttps://github.com/python/cpython/pull/162/files
aifc.py https://github.com/python/cpython/pull/162/files#diff-cf443688c22475838e5ff7d1a7a267e4b75bc2e980b4809d0afad4090751f446
test_aifc.py https://github.com/python/cpython/pull/162/files#diff-2317a83b9982b0390dfcbacbcf319929100c98400da36aefaa4723e7aa2d36d1
NEWS https://github.com/python/cpython/pull/162/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
Lib/aifc.pyhttps://github.com/python/cpython/pull/162/files#diff-cf443688c22475838e5ff7d1a7a267e4b75bc2e980b4809d0afad4090751f446
View file https://github.com/Uberi/cpython/blob/e09c582d908b697035b3a63287f0c670dea67039/Lib/aifc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162/files#diff-cf443688c22475838e5ff7d1a7a267e4b75bc2e980b4809d0afad4090751f446
https://github.com/python/cpython/pull/162/files#diff-cf443688c22475838e5ff7d1a7a267e4b75bc2e980b4809d0afad4090751f446
https://github.com/python/cpython/pull/162/files#diff-cf443688c22475838e5ff7d1a7a267e4b75bc2e980b4809d0afad4090751f446
serhiy-storchakahttps://github.com/serhiy-storchaka
Feb 23, 2017https://github.com/python/cpython/pull/162/files#r102687429
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162/files
methanehttps://github.com/methane
Feb 23, 2017https://github.com/python/cpython/pull/162/files#r102766082
Please reload this pagehttps://github.com/python/cpython/pull/162/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Feb 23, 2017https://github.com/python/cpython/pull/162/files#r102768147
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162/files
methanehttps://github.com/methane
Feb 23, 2017https://github.com/python/cpython/pull/162/files#r102771690
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162/files
https://github.com/python/cpython/pull/162/files#diff-cf443688c22475838e5ff7d1a7a267e4b75bc2e980b4809d0afad4090751f446
Lib/test/test_aifc.pyhttps://github.com/python/cpython/pull/162/files#diff-2317a83b9982b0390dfcbacbcf319929100c98400da36aefaa4723e7aa2d36d1
View file https://github.com/Uberi/cpython/blob/e09c582d908b697035b3a63287f0c670dea67039/Lib/test/test_aifc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162/{{ revealButtonHref }}
methanehttps://github.com/methane
Feb 22, 2017https://github.com/python/cpython/pull/162/files#r102376565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162/files
Uberihttps://github.com/Uberi
Feb 22, 2017https://github.com/python/cpython/pull/162/files#r102384112
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162/files
methanehttps://github.com/methane
Feb 22, 2017https://github.com/python/cpython/pull/162/files#r102384882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162/files
https://github.com/python/cpython/pull/162/files#diff-2317a83b9982b0390dfcbacbcf319929100c98400da36aefaa4723e7aa2d36d1
https://github.com/python/cpython/pull/162/files#diff-2317a83b9982b0390dfcbacbcf319929100c98400da36aefaa4723e7aa2d36d1
serhiy-storchakahttps://github.com/serhiy-storchaka
Feb 23, 2017https://github.com/python/cpython/pull/162/files#r102688420
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/162/files
methanehttps://github.com/methane
Feb 25, 2017https://github.com/python/cpython/pull/162/files#r103084750
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#293https://github.com/python/cpython/pull/293
Please reload this pagehttps://github.com/python/cpython/pull/162/files
https://github.com/python/cpython/pull/162/files#diff-2317a83b9982b0390dfcbacbcf319929100c98400da36aefaa4723e7aa2d36d1
Misc/NEWShttps://github.com/python/cpython/pull/162/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
View file https://github.com/Uberi/cpython/blob/e09c582d908b697035b3a63287f0c670dea67039/Misc/NEWS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/162/{{ revealButtonHref }}
https://github.com/python/cpython/pull/162/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
https://github.com/python/cpython/pull/162/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.