René's URL Explorer Experiment


Title: bpo-38136: Updates await_count and call_count to be different things by lisroach · Pull Request #16192 · python/cpython · GitHub

Open Graph Title: bpo-38136: Updates await_count and call_count to be different things by lisroach · Pull Request #16192 · python/cpython

X Title: bpo-38136: Updates await_count and call_count to be different things by lisroach · Pull Request #16192 · python/cpython

Description: After a lot of discussion we have decided that "calls" and "awaits" should be counted as two different things. To accomplish this I separated the call counting from the actual execution of the call, that way they are counted at two different times. For synchronous calls the increment and execute calls happen one immediately after another, but for asynchronous calls the increment count for call count happens first, and then only after await is called does the call execute and increment the await counters. https://bugs.python.org/issue38136

Open Graph Description: After a lot of discussion we have decided that "calls" and "awaits" should be counted as two different things. To accomplish this I separated the call counting from the actual e...

X Description: After a lot of discussion we have decided that "calls" and "awaits" should be counted as two different things. To accomplish this I separated the call counting f...

Opengraph URL: https://github.com/python/cpython/pull/16192

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3cbeaf44-4d7a-0b78-f74a-25e196567124
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8380:2511D4:6C1B5C:9393A7:6A55A450
html-safe-nonce653893303ef0df3511eeeed78f47517b5f2ced1ccc737b42434ef4e0317a9e4d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzgwOjI1MTFENDo2QzFCNUM6OTM5M0E3OjZBNTVBNDUwIiwidmlzaXRvcl9pZCI6IjMzODY1NDc0NDA4NDA5NzU0NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac35f094ad461b198a73c32f30535195291578a1ed9a4b2c123ddc0e3c072c6ff8
hovercard-subject-tagpull_request:317972208
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/16192/files
twitter:imagehttps://avatars.githubusercontent.com/u/11097768?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11097768?s=400&v=4
og:image:altAfter a lot of discussion we have decided that "calls" and "awaits" should be counted as two different things. To accomplish this I separated the call counting from the actual e...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release653fccf1e27344851c0d3de3fa6faa526197f072
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/16192/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16192%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F16192%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/16192/files
Reloadhttps://github.com/python/cpython/pull/16192/files
Reloadhttps://github.com/python/cpython/pull/16192/files
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
lisroachhttps://github.com/lisroach
python:masterhttps://github.com/python/cpython/tree/master
lisroach:fix_call_counthttps://github.com/lisroach/cpython/tree/fix_call_count
Conversation 36 https://github.com/python/cpython/pull/16192
Commits 8 https://github.com/python/cpython/pull/16192/commits
Checks 0 https://github.com/python/cpython/pull/16192/checks
Files changed https://github.com/python/cpython/pull/16192/files
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
bpo-38136: Updates await_count and call_count to be different things https://github.com/python/cpython/pull/16192/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/16192/files
bba68c0 Increment and execute call seperatly to support awaitable counts. lisroach Sep 13, 2019 https://github.com/python/cpython/pull/16192/commits/bba68c0ca935fcc4840bde7f44142b0ae0bf58f9
ab5341d Adds tests. lisroach Sep 13, 2019 https://github.com/python/cpython/pull/16192/commits/ab5341da5fae693652ccece5a60569ef5f8c70e1
c366bf1 Adds upstream changes. lisroach Sep 16, 2019 https://github.com/python/cpython/pull/16192/commits/c366bf1f54683ad8e50835a5623c16109112b7c9
076b84b Merge branch 'master' into fix_call_count lisroach Sep 16, 2019 https://github.com/python/cpython/pull/16192/commits/076b84b2d4accde82cfa80ec6b5a8ab7218810b5
d4a9315 Adds news entry. lisroach Sep 16, 2019 https://github.com/python/cpython/pull/16192/commits/d4a9315ca500f3119510c6828a711b842fd9dae8
48b803d Removes bad doc and space. lisroach Sep 16, 2019 https://github.com/python/cpython/pull/16192/commits/48b803d30d96c7fa91134d5ba5efefb39172ae9a
fbd83bc Updates the tests based on comments. lisroach Sep 18, 2019 https://github.com/python/cpython/pull/16192/commits/fbd83bc35e5856c890b913d7ee84017d5c659de1
564adc4 Adds docs, fixes up tests. lisroach Sep 20, 2019 https://github.com/python/cpython/pull/16192/commits/564adc432d50b9bcf891800a3c49aff155eee841
Clear filters https://github.com/python/cpython/pull/16192/files
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
unittest.mock.rst https://github.com/python/cpython/pull/16192/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
mock.py https://github.com/python/cpython/pull/16192/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
testasync.py https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
testmock.py https://github.com/python/cpython/pull/16192/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
2019-09-16-09-54-42.bpo-38136.MdI-Zb.rst https://github.com/python/cpython/pull/16192/files#diff-19ef344b6e613967318a8ab1dc8c641b8af342f781f2d21b8d6297f569f096e8
Doc/library/unittest.mock.rsthttps://github.com/python/cpython/pull/16192/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
View file https://github.com/lisroach/cpython/blob/564adc432d50b9bcf891800a3c49aff155eee841/Doc/library/unittest.mock.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/16192/{{ revealButtonHref }}
https://github.com/python/cpython/pull/16192/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
https://github.com/python/cpython/pull/16192/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
https://github.com/python/cpython/pull/16192/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
https://github.com/python/cpython/pull/16192/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
https://github.com/python/cpython/pull/16192/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
https://github.com/python/cpython/pull/16192/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
Lib/unittest/mock.pyhttps://github.com/python/cpython/pull/16192/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
View file https://github.com/lisroach/cpython/blob/564adc432d50b9bcf891800a3c49aff155eee841/Lib/unittest/mock.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/16192/{{ revealButtonHref }}
https://github.com/python/cpython/pull/16192/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/16192/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/16192/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/16192/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
Lib/unittest/test/testmock/testasync.pyhttps://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
View file https://github.com/lisroach/cpython/blob/564adc432d50b9bcf891800a3c49aff155eee841/Lib/unittest/test/testmock/testasync.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/16192/{{ revealButtonHref }}
https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/16192/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
Lib/unittest/test/testmock/testmock.pyhttps://github.com/python/cpython/pull/16192/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
View file https://github.com/lisroach/cpython/blob/564adc432d50b9bcf891800a3c49aff155eee841/Lib/unittest/test/testmock/testmock.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/16192/{{ revealButtonHref }}
https://github.com/python/cpython/pull/16192/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
https://github.com/python/cpython/pull/16192/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
https://github.com/python/cpython/pull/16192/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
tirkarthihttps://github.com/tirkarthi
Sep 16, 2019https://github.com/python/cpython/pull/16192/files#r324825081
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
https://github.com/python/cpython/pull/16192/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
Misc/NEWS.d/next/Library/2019-09-16-09-54-42.bpo-38136.MdI-Zb.rsthttps://github.com/python/cpython/pull/16192/files#diff-19ef344b6e613967318a8ab1dc8c641b8af342f781f2d21b8d6297f569f096e8
View file https://github.com/lisroach/cpython/blob/564adc432d50b9bcf891800a3c49aff155eee841/Misc/NEWS.d/next/Library/2019-09-16-09-54-42.bpo-38136.MdI-Zb.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/16192/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/16192/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.