René's URL Explorer Experiment


Title: gh-161809: Fix itertext() skipping elements with QName tags by Aareevs · Pull Request #161878 · python/cpython · GitHub

Open Graph Title: gh-161809: Fix itertext() skipping elements with QName tags by Aareevs · Pull Request #161878 · python/cpython

X Title: gh-161809: Fix itertext() skipping elements with QName tags by Aareevs · Pull Request #161878 · python/cpython

Description: Fixes #161809. Element.itertext(), and therefore tostring(method="text"), skipped elements whose tag was not a str in order to leave out comments and processing instructions. This check also matched QName tags, causing their text to be lost. The pure-Python implementation returned no text for the affected subtree, while the C implementation dropped the element's own text. Update both implementations to skip only elements with a callable tag, which is how comments, processing instructions and elements from custom comment_factory/pi_factory are represented. A QName tag is not callable, so its text is now preserved. Added regression tests for QName tags and for custom comment/PI factories, checking that comments and processing instructions are still skipped. Validation: Checked the pure-Python behavior manually before and after the change: QName element text was lost before and is preserved after, and comments and PIs are still skipped. CI is re-running on the latest commit; Both test_xml_etree and test_xml_etree_c run. AI assistance (Claude) was used to investigate the issue and prepare the patch and regression tests. I have reviewed the changes.

Open Graph Description: Fixes #161809. Element.itertext(), and therefore tostring(method="text"), skipped elements whose tag was not a str in order to leave out comments and processing instructions. This check a...

X Description: Fixes #161809. Element.itertext(), and therefore tostring(method="text"), skipped elements whose tag was not a str in order to leave out comments and processing instructions. This...

Opengraph URL: https://github.com/python/cpython/pull/161878

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9c54afcd-7c06-a0d3-391a-d2baf0eee2c8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE30A:172B92:3809548:4AA4C13:6B0216CA
html-safe-nonce6daba62a71ff5090a93d23f9f80c13416437490a0f61d69d66e1dcfd373f41ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzBBOjE3MkI5MjozODA5NTQ4OjRBQTRDMTM6NkIwMjE2Q0EiLCJ2aXNpdG9yX2lkIjoiODk5MzY3MzgzMzI5MDUzNjY1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac499d10c1f0aabbb77476fba623161dcd3d816b321c09bc7659b9c70dcf645947
hovercard-subject-tagpull_request:5280294180
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/161878/files
twitter:imagehttps://avatars.githubusercontent.com/u/157673536?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/157673536?s=400&v=4
og:image:altFixes #161809. Element.itertext(), and therefore tostring(method="text"), skipped elements whose tag was not a str in order to leave out comments and processing instructions. This check a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/161878/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161878%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161878%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/161878/files
Reloadhttps://github.com/python/cpython/pull/161878/files
Reloadhttps://github.com/python/cpython/pull/161878/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Aareevshttps://github.com/Aareevs
python:mainhttps://github.com/python/cpython/tree/main
Aareevs:gh-161809-itertext-qnamehttps://github.com/Aareevs/cpython/tree/gh-161809-itertext-qname
Conversation 3 https://github.com/python/cpython/pull/161878
Commits 2 https://github.com/python/cpython/pull/161878/commits
Checks 54 https://github.com/python/cpython/pull/161878/checks
Files changed https://github.com/python/cpython/pull/161878/files
Please reload this pagehttps://github.com/python/cpython/pull/161878/files
gh-161809: Fix itertext() skipping elements with QName tags https://github.com/python/cpython/pull/161878/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/161878/files
9a8bc08 gh-161809: Fix itertext() skipping elements with QName tags Aareevs Nov 12, 2026 https://github.com/python/cpython/pull/161878/commits/9a8bc08809eaea67f075f23906d4e5a34975786c
5cb5b95 gh-161809: Skip callable tags in itertext() instead of non-str ones Aareevs Nov 13, 2026 https://github.com/python/cpython/pull/161878/commits/5cb5b9572c75acf63f5369110f46a3e6c36e9247
Clear filters https://github.com/python/cpython/pull/161878/files
Please reload this pagehttps://github.com/python/cpython/pull/161878/files
Please reload this pagehttps://github.com/python/cpython/pull/161878/files
test_xml_etree.py https://github.com/python/cpython/pull/161878/files#diff-cd2315ff25ab49e653d363de2d213e390ecb1b01bbc86e2be3b700db4b0bf454
ElementTree.py https://github.com/python/cpython/pull/161878/files#diff-6cc017478b4d1fa353b3869176b34a540106a61462417ba0ee1a77fc64eef673
2026-11-12-12-00-00.gh-issue-161809.Qn4mEt.rst https://github.com/python/cpython/pull/161878/files#diff-a5cabcce03e841b887c1349675f4d8181644f95383be6a3c883e0bbde526c65d
_elementtree.c https://github.com/python/cpython/pull/161878/files#diff-72f80c6ac0294ae74c7b014c12bcf229e9df089ab19018ea35fd61c58fdb69ac
Lib/test/test_xml_etree.pyhttps://github.com/python/cpython/pull/161878/files#diff-cd2315ff25ab49e653d363de2d213e390ecb1b01bbc86e2be3b700db4b0bf454
View file https://github.com/python/cpython/blob/5cb5b9572c75acf63f5369110f46a3e6c36e9247/Lib/test/test_xml_etree.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161878/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161878/files#diff-cd2315ff25ab49e653d363de2d213e390ecb1b01bbc86e2be3b700db4b0bf454
https://github.com/python/cpython/pull/161878/files#diff-cd2315ff25ab49e653d363de2d213e390ecb1b01bbc86e2be3b700db4b0bf454
Lib/xml/etree/ElementTree.pyhttps://github.com/python/cpython/pull/161878/files#diff-6cc017478b4d1fa353b3869176b34a540106a61462417ba0ee1a77fc64eef673
View file https://github.com/python/cpython/blob/5cb5b9572c75acf63f5369110f46a3e6c36e9247/Lib/xml/etree/ElementTree.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161878/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161878/files#diff-6cc017478b4d1fa353b3869176b34a540106a61462417ba0ee1a77fc64eef673
https://github.com/python/cpython/pull/161878/files#diff-6cc017478b4d1fa353b3869176b34a540106a61462417ba0ee1a77fc64eef673
Misc/NEWS.d/next/Library/2026-11-12-12-00-00.gh-issue-161809.Qn4mEt.rsthttps://github.com/python/cpython/pull/161878/files#diff-a5cabcce03e841b887c1349675f4d8181644f95383be6a3c883e0bbde526c65d
View file https://github.com/python/cpython/blob/5cb5b9572c75acf63f5369110f46a3e6c36e9247/Misc/NEWS.d/next/Library/2026-11-12-12-00-00.gh-issue-161809.Qn4mEt.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161878/{{ revealButtonHref }}
Modules/_elementtree.chttps://github.com/python/cpython/pull/161878/files#diff-72f80c6ac0294ae74c7b014c12bcf229e9df089ab19018ea35fd61c58fdb69ac
View file https://github.com/python/cpython/blob/5cb5b9572c75acf63f5369110f46a3e6c36e9247/Modules/_elementtree.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161878/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161878/files#diff-72f80c6ac0294ae74c7b014c12bcf229e9df089ab19018ea35fd61c58fdb69ac
https://github.com/python/cpython/pull/161878/files#diff-72f80c6ac0294ae74c7b014c12bcf229e9df089ab19018ea35fd61c58fdb69ac
Please reload this pagehttps://github.com/python/cpython/pull/161878/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.