René's URL Explorer Experiment


Title: gh-161792: Fix crashes in the callable iterator by nascheme · Pull Request #161793 · python/cpython · GitHub

Open Graph Title: gh-161792: Fix crashes in the callable iterator by nascheme · Pull Request #161793 · python/cpython

X Title: gh-161792: Fix crashes in the callable iterator by nascheme · Pull Request #161793 · python/cpython

Description: calliter_iternext() called it_callable and compared the result against it_sentinel through borrowed pointers. In all builds, the sentinel's __eq__ can call __setstate__() and free the sentinel while the comparison is using it (gh-158031). In the free-threaded build, another thread can free the fields by exhausting the iterator or calling __setstate__(), and two threads exhausting the iterator can both DECREF the callable (gh-161792). Sharing a callable iterator between threads, or calling __setstate__() on one that is in use, is not supported: the values produced are unspecified. It must not crash, though. That lets the fix avoid a lock: Readers load a field (acquire) and take a strong reference right away, before any code can run. The callable is held across the call and the sentinel across the comparison. Writers (exhaustion and __setstate__()) swap the field with an atomic exchange, so only one thread gets the old value, and release it with _PyObject_XDecRefDelayed(). In the free-threaded build that defers the DECREF until no thread can still be between its load and its incref; in the default build it is a plain Py_XDECREF(). This also covers gh-158031, so it overlaps with #158046, which takes a strong reference to the sentinel only. Performance Release builds (Clang 20, no PGO/LTO), single thread pinned to one CPU, ns per item including consumption overhead (deque(islice(it, N), maxlen=0)), best of 7, mean of two runs. Free-threaded build: Workload main PR iter(int, 1) 9.2 9.9 Python function, sentinel 1 24.4 25.5 Python function, object() sentinel 29.7 30.6 Python function, no sentinel 19.1 19.8 bound __next__ of itertools.repeat, sentinel 1 13.1 14.1 Default (GIL) build: Workload main PR iter(int, 1) 7.8 9.5 Python function, sentinel 1 21.0 21.7 Python function, object() sentinel 22.4 25.2 Python function, no sentinel 16.6 16.6 bound __next__ of itertools.repeat, sentinel 1 12.1 13.7 The cost is about 1 ns per item in the free-threaded build and 0-3 ns in the default build, from the strong references to the callable and sentinel. It is only visible when the callable is trivially cheap.

Open Graph Description: calliter_iternext() called it_callable and compared the result against it_sentinel through borrowed pointers. In all builds, the sentinel's __eq__ can call __setstate__() and free the sentinel...

X Description: calliter_iternext() called it_callable and compared the result against it_sentinel through borrowed pointers. In all builds, the sentinel's __eq__ can call __setstate__() and free the sent...

Opengraph URL: https://github.com/python/cpython/pull/161793

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c8a27338-0fab-ebf6-7af0-cbf17cbb0cc8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD372:D4E59:AF71D7:DD26FE:6B021954
html-safe-nonceb2fafaf35f86a8da5495701a3cf40840fcc793c3ab012e4cc9672bcd12706afe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzcyOkQ0RTU5OkFGNzFENzpERDI2RkU6NkIwMjE5NTQiLCJ2aXNpdG9yX2lkIjoiODU2NjMwNTE4MjY3NjI5Mzk3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfc814bac12f0b284615406a8d01e89279d112c9910de91dde5123fad91936f8d
hovercard-subject-tagpull_request:5254204774
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/161793/files
twitter:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
og:image:altcalliter_iternext() called it_callable and compared the result against it_sentinel through borrowed pointers. In all builds, the sentinel's __eq__ can call __setstate__() and free the sentinel...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/161793/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161793%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161793%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/161793/files
Reloadhttps://github.com/python/cpython/pull/161793/files
Reloadhttps://github.com/python/cpython/pull/161793/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
nascheme:gh-161792-calliter-ft-fixhttps://github.com/nascheme/cpython/tree/gh-161792-calliter-ft-fix
Conversation 1 https://github.com/python/cpython/pull/161793
Commits 1 https://github.com/python/cpython/pull/161793/commits
Checks 62 https://github.com/python/cpython/pull/161793/checks
Files changed https://github.com/python/cpython/pull/161793/files
Please reload this pagehttps://github.com/python/cpython/pull/161793/files
gh-161792: Fix crashes in the callable iterator https://github.com/python/cpython/pull/161793/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/161793/files
814a28b gh-161792: Fix crashes in the callable iterator nascheme Nov 11, 2026 https://github.com/python/cpython/pull/161793/commits/814a28bfe9e0e3b4372e4d17b5ab4fd5c3a5d204
Clear filters https://github.com/python/cpython/pull/161793/files
Please reload this pagehttps://github.com/python/cpython/pull/161793/files
Please reload this pagehttps://github.com/python/cpython/pull/161793/files
test_iteration.py https://github.com/python/cpython/pull/161793/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
test_iter.py https://github.com/python/cpython/pull/161793/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
2026-11-11-04-58-51.gh-issue-161792.42EcBI8x.rst https://github.com/python/cpython/pull/161793/files#diff-8bb371d3f1cc6cef86b712302c94ca80e6db70655005a2327e7a67a5524efbab
iterobject.c https://github.com/python/cpython/pull/161793/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
Lib/test/test_free_threading/test_iteration.pyhttps://github.com/python/cpython/pull/161793/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
View file https://github.com/nascheme/cpython/blob/814a28bfe9e0e3b4372e4d17b5ab4fd5c3a5d204/Lib/test/test_free_threading/test_iteration.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161793/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161793/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
https://github.com/python/cpython/pull/161793/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
https://github.com/python/cpython/pull/161793/files#diff-2e51e17906bce15fef8803cdb5f9a05036e37b6540f8a06cef4e8f5014ac3d2f
Lib/test/test_iter.pyhttps://github.com/python/cpython/pull/161793/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
View file https://github.com/nascheme/cpython/blob/814a28bfe9e0e3b4372e4d17b5ab4fd5c3a5d204/Lib/test/test_iter.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161793/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161793/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
https://github.com/python/cpython/pull/161793/files#diff-93cc7e37c1465586584a0a609ad2f7282c28ea4f19f0686f16a776a5ccf716a9
.../NEWS.d/next/Core_and_Builtins/2026-11-11-04-58-51.gh-issue-161792.42EcBI8x.rsthttps://github.com/python/cpython/pull/161793/files#diff-8bb371d3f1cc6cef86b712302c94ca80e6db70655005a2327e7a67a5524efbab
View file https://github.com/nascheme/cpython/blob/814a28bfe9e0e3b4372e4d17b5ab4fd5c3a5d204/Misc/NEWS.d/next/Core_and_Builtins/2026-11-11-04-58-51.gh-issue-161792.42EcBI8x.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161793/{{ revealButtonHref }}
Objects/iterobject.chttps://github.com/python/cpython/pull/161793/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
View file https://github.com/nascheme/cpython/blob/814a28bfe9e0e3b4372e4d17b5ab4fd5c3a5d204/Objects/iterobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161793/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161793/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/161793/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/161793/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/161793/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/161793/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/161793/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
https://github.com/python/cpython/pull/161793/files#diff-e0923aa0ec18bd667c33e79ede96b408e9bca3e9e0af262028722d7f23928723
Please reload this pagehttps://github.com/python/cpython/pull/161793/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.