René's URL Explorer Experiment


Title: [3.14] gh-161503: Check hostname in `ssl.get_server_certificate` with custom `ca_certs` (GH-161507) by miss-islington · Pull Request #161575 · python/cpython · GitHub

Open Graph Title: [3.14] gh-161503: Check hostname in `ssl.get_server_certificate` with custom `ca_certs` (GH-161507) by miss-islington · Pull Request #161575 · python/cpython

X Title: [3.14] gh-161503: Check hostname in `ssl.get_server_certificate` with custom `ca_certs` (GH-161507) by miss-islington · Pull Request #161575 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: (cherry picked from commit 8dde46e) Co-authored-by: Brett Smith brett.smith@python.org Issue: ssl.get_server_certificate(addr, ca_certs=...) verifies the chain but never the identity #161503

X Description: (cherry picked from commit 8dde46e) Co-authored-by: Brett Smith brett.smith@python.org Issue: ssl.get_server_certificate(addr, ca_certs=...) verifies the chain but never the identity #161503

Mail addresses
brett.smith@python.org

Opengraph URL: https://github.com/python/cpython/pull/161575

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:85043124-a766-a408-2636-ef914512f3b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F14:2454CC:3AC5406:4A8E55B:6B0201C6
html-safe-nonceb3e59d41d0632c29e2f62ba596c778289f441227f5f8bf4a0f147cc3d1f38195
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjE0OjI0NTRDQzozQUM1NDA2OjRBOEU1NUI6NkIwMjAxQzYiLCJ2aXNpdG9yX2lkIjoiODM1NjA5Nzc1MzY1NDM2MjU2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc463bdb9577ec89cd995700d2b29a8c98f2aa0aafb147005dcec61cef920f34e
hovercard-subject-tagpull_request:5204957069
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/161575/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/33d7d2fa141f8bcb1fff944ffa23dd8b7dac921f3cc66d3ff29dff4135a7a262/python/cpython/pull/161575
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/33d7d2fa141f8bcb1fff944ffa23dd8b7dac921f3cc66d3ff29dff4135a7a262/python/cpython/pull/161575
og:image:alt(cherry picked from commit 8dde46e) Co-authored-by: Brett Smith brett.smith@python.org Issue: ssl.get_server_certificate(addr, ca_certs=...) verifies the chain but never the identity #161503
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/161575#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161575
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161575
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/161575
Reloadhttps://github.com/python/cpython/pull/161575
Reloadhttps://github.com/python/cpython/pull/161575
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
miss-islingtonhttps://github.com/miss-islington
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-8dde46e-3.14https://github.com/miss-islington/cpython/tree/backport-8dde46e-3.14
Conversationhttps://github.com/python/cpython/pull/161575
Commits1 (1)https://github.com/python/cpython/pull/161575/commits
Checkshttps://github.com/python/cpython/pull/161575/checks
Files changedhttps://github.com/python/cpython/pull/161575/files
[3.14] gh-161503: Check hostname in ssl.get_server_certificate with custom ca_certs (GH-161507)https://github.com/python/cpython/pull/161575#top
miss-islingtonhttps://github.com/miss-islington
python:3.14https://github.com/python/cpython/tree/3.14
miss-islington:backport-8dde46e-3.14https://github.com/miss-islington/cpython/tree/backport-8dde46e-3.14
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 7, 2026https://github.com/python/cpython/pull/161575#issue-6263096966
Please reload this pagehttps://github.com/python/cpython/pull/161575
8dde46ehttps://github.com/python/cpython/commit/8dde46eaa6baf5f027a7234845b20d50b509624e
ssl.get_server_certificate(addr, ca_certs=...) verifies the chain but never the identity #161503https://github.com/python/cpython/issues/161503
Please reload this pagehttps://github.com/python/cpython/pull/161575
https://github.com/brettcs
https://github.com/miss-islington
pythongh-161503https://github.com/python/cpython/issues/161503
: Check hostname inhttps://github.com/python/cpython/pull/161575/commits/c02f192de40a27387937a5acc08d97de0905b472
ssl.get_server_certificatehttps://github.com/python/cpython/pull/161575/commits/c02f192de40a27387937a5acc08d97de0905b472
with …https://github.com/python/cpython/pull/161575/commits/c02f192de40a27387937a5acc08d97de0905b472
c02f192https://github.com/python/cpython/pull/161575/commits/c02f192de40a27387937a5acc08d97de0905b472
pythonGH-161507https://github.com/python/cpython/pull/161507
8dde46ehttps://github.com/miss-islington/cpython/commit/8dde46eaa6baf5f027a7234845b20d50b509624e
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
gpsheadhttps://github.com/gpshead
picnixzhttps://github.com/picnixz
code ownershttps://github.com/python/cpython/blob/f3eb3ccc6a554cb18ce8ca4a45e94fe211e1693f/.github/CODEOWNERS#L127
November 7, 2026 19:08https://github.com/python/cpython/pull/161575#event-35454231926
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 7, 2026https://github.com/python/cpython/pull/161575#event-35454235917
ssl.get_server_certificate(addr, ca_certs=...) verifies the chain but never the identity #161503 https://github.com/python/cpython/issues/161503
gh-161503: Check hostname in ssl.get_server_certificate with custom ca_certs #161507 https://github.com/python/cpython/pull/161507
https://github.com/apps/read-the-docs-community
read-the-docs-communityhttps://github.com/apps/read-the-docs-community
Nov 7, 2026https://github.com/python/cpython/pull/161575#issuecomment-6711859273
cpython-previewshttps://app.readthedocs.org/projects/cpython-previews/
#35723128https://app.readthedocs.org/projects/cpython-previews/builds/35723128/
c02f192https://github.com/python/cpython/commit/c02f192de40a27387937a5acc08d97de0905b472
mainhttps://cpython-previews.readthedocs.io/en/main/
8dde46ehttps://github.com/python/cpython/commit/8dde46eaa6baf5f027a7234845b20d50b509624e
  🔍 Preview build   https://cpython-previews--161575.org.readthedocs.build/en/161575/
library/asyncio-policy.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/library/asyncio-policy.html
about.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/about.html
bugs.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/bugs.html
glossary.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/glossary.html
index.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/index.html
license.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/license.html
py-modindex.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/py-modindex.html
builtins/exceptions.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/builtins/exceptions.html
builtins/functions.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/builtins/functions.html
builtins/stdtypes.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/builtins/stdtypes.html
builtins/threadsafety.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/builtins/threadsafety.html
_static/tachyon-example-flamegraph.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/_static/tachyon-example-flamegraph.html
_static/tachyon-example-heatmap.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/_static/tachyon-example-heatmap.html
c-api/sentinel.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/c-api/sentinel.html
c-api/slots.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/c-api/slots.html
deprecations/c-api-pending-removal-in-3.19.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/deprecations/c-api-pending-removal-in-3.19.html
deprecations/c-api-pending-removal-in-3.20.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/deprecations/c-api-pending-removal-in-3.20.html
deprecations/pending-removal-in-3.20.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/deprecations/pending-removal-in-3.20.html
deprecations/pending-removal-in-3.21.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/deprecations/pending-removal-in-3.21.html
deprecations/soft-deprecations.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/deprecations/soft-deprecations.html
extending/first-extension-module.htmlhttps://cpython-previews--161575.org.readthedocs.build/en/161575/extending/first-extension-module.html
Please reload this pagehttps://github.com/python/cpython/pull/161575
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161575
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/picnixz
picnixz https://github.com/picnixz
Please reload this pagehttps://github.com/python/cpython/pull/161575
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/161575
https://github.com/miss-islington
https://github.com/brettcs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.