René's URL Explorer Experiment


Title: gh-161503: Check hostname in `ssl.get_server_certificate` with custom `ca_certs` by brettcs · Pull Request #161507 · python/cpython · GitHub

Open Graph Title: gh-161503: Check hostname in `ssl.get_server_certificate` with custom `ca_certs` by brettcs · Pull Request #161507 · python/cpython

X Title: gh-161503: Check hostname in `ssl.get_server_certificate` with custom `ca_certs` by brettcs · Pull Request #161507 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This branch implements the suggested fix along with a test that fails on current main. CC @sethmlarson @StanFromIreland Issue: ssl.get_server_certificate(addr, ca_certs=...) verifies the chain bu...

X Description: This branch implements the suggested fix along with a test that fails on current main. CC @sethmlarson @StanFromIreland Issue: ssl.get_server_certificate(addr, ca_certs=...) verifies the chain bu...

Opengraph URL: https://github.com/python/cpython/pull/161507

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:b2022875-0428-01d8-82b7-ccabc8189c3e
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id8DC6:3DCD28:19121BF:2132AE4:6B021337
html-safe-nonce2b3b9f937b94286d6461da216b377e111331dbebe618a855db468fe22b71be88
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REM2OjNEQ0QyODoxOTEyMUJGOjIxMzJBRTQ6NkIwMjEzMzciLCJ2aXNpdG9yX2lkIjoiMTE5MTgyMjA4OTMzMTcyMDIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9a9499e76854c3f6895ac0a101f67debc76f057d4eb38715eedc7ed4447d4b20
hovercard-subject-tagpull_request:5191525669
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/161507/checks
twitter:imagehttps://opengraph.githubassets.com/4c5023c61ca2556acba9db52bccff1f66135e64eeac68a4e086d64427a0f9521/python/cpython/pull/161507
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c5023c61ca2556acba9db52bccff1f66135e64eeac68a4e086d64427a0f9521/python/cpython/pull/161507
og:image:altThis branch implements the suggested fix along with a test that fails on current main. CC @sethmlarson @StanFromIreland Issue: ssl.get_server_certificate(addr, ca_certs=...) verifies the chain bu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrettcs
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/161507/checks#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161507%2Fchecks
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161507%2Fchecks
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/161507/checks
Reloadhttps://github.com/python/cpython/pull/161507/checks
Reloadhttps://github.com/python/cpython/pull/161507/checks
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
StanFromIrelandhttps://github.com/StanFromIreland
python:mainhttps://github.com/python/cpython/tree/main
brettcs:ssl-check-hostname-with-ca-certshttps://github.com/brettcs/cpython/tree/ssl-check-hostname-with-ca-certs
Conversationhttps://github.com/python/cpython/pull/161507
Commits3 (3)https://github.com/python/cpython/pull/161507/commits
Checkshttps://github.com/python/cpython/pull/161507/checks
Files changedhttps://github.com/python/cpython/pull/161507/files
gh-161503: Check hostname in ssl.get_server_certificate with custom ca_certshttps://github.com/python/cpython/pull/161507/checks#top
StanFromIrelandhttps://github.com/StanFromIreland
python:mainhttps://github.com/python/cpython/tree/main
brettcs:ssl-check-hostname-with-ca-certshttps://github.com/brettcs/cpython/tree/ssl-check-hostname-with-ca-certs
Please reload this pagehttps://github.com/python/cpython/pull/161507/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161507%2Fchecks
Lint on: pull_request https://github.com/python/cpython/actions/runs/42289488604
lint https://github.com/python/cpython/actions/runs/42289488604/job/128138857175?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42289488688
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42289488688/job/128138856251?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42289488688/job/128138856861?pr=161507
Tests on: pull_request https://github.com/python/cpython/actions/runs/42289488778
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/42289488778/job/128138857564?pr=161507
Docs / Docs https://github.com/python/cpython/actions/runs/42289488778/job/128138978487?pr=161507
Docs / Doctest https://github.com/python/cpython/actions/runs/42289488778/job/128138978632?pr=161507
Docs / Check EPUB https://github.com/python/cpython/actions/runs/42289488778/job/128138978393?pr=161507
Docs / Check for removed HTML IDs / Check for removed HTML IDs https://github.com/python/cpython/actions/runs/42289488778/job/128140148065?pr=161507
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/42289488778/job/128138975042?pr=161507
Check if generated files are up to date https://github.com/python/cpython/actions/runs/42289488778/job/128138975186?pr=161507
C API Docs / Check if all C APIs are documented https://github.com/python/cpython/actions/runs/42289488778/job/128138976131?pr=161507
Windows / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/42289488778/job/128138977248?pr=161507
Windows (free-threading) / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/42289488778/job/128138977383?pr=161507
Windows / Build and test (Win32, switch-case) https://github.com/python/cpython/actions/runs/42289488778/job/128138977250?pr=161507
Windows / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/42289488778/job/128138977506?pr=161507
Windows (free-threading) / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/42289488778/job/128138977390?pr=161507
Windows / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/42289488778/job/128138977346?pr=161507
Windows (free-threading) / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/42289488778/job/128138977477?pr=161507
macOS / build and test (macos-26) https://github.com/python/cpython/actions/runs/42289488778/job/128138977836?pr=161507
macOS (free-threading) / build and test (macos-26) https://github.com/python/cpython/actions/runs/42289488778/job/128138978022?pr=161507
macOS / build and test (macos-26-intel) https://github.com/python/cpython/actions/runs/42289488778/job/128138978068?pr=161507
Ubuntu / build and test (ubuntu-26.04) https://github.com/python/cpython/actions/runs/42289488778/job/128138977624?pr=161507
Ubuntu / build and test (ubuntu-26.04-arm) https://github.com/python/cpython/actions/runs/42289488778/job/128138977741?pr=161507
Ubuntu (free-threading) / build and test (ubuntu-26.04) https://github.com/python/cpython/actions/runs/42289488778/job/128138977700?pr=161507
Ubuntu (free-threading) / build and test (ubuntu-26.04-arm) https://github.com/python/cpython/actions/runs/42289488778/job/128138977622?pr=161507
Ubuntu (bolt) / build and test (ubuntu-26.04) https://github.com/python/cpython/actions/runs/42289488778/job/128138977695?pr=161507
Ubuntu (installed) / build, install and test https://github.com/python/cpython/actions/runs/42289488778/job/128138976644?pr=161507
Ubuntu SSL tests (ubuntu-26.04, openssl, 1.1.1w) https://github.com/python/cpython/actions/runs/42289488778/job/128138975747?pr=161507
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.4.8) https://github.com/python/cpython/actions/runs/42289488778/job/128138975772?pr=161507
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.5.9) https://github.com/python/cpython/actions/runs/42289488778/job/128138975763?pr=161507
Ubuntu SSL tests (ubuntu-26.04, openssl, 3.6.5) https://github.com/python/cpython/actions/runs/42289488778/job/128138975783?pr=161507
Ubuntu SSL tests (ubuntu-26.04, openssl, 4.0.3) https://github.com/python/cpython/actions/runs/42289488778/job/128138976041?pr=161507
Ubuntu SSL tests (ubuntu-26.04, aws-lc, 5.10.0) https://github.com/python/cpython/actions/runs/42289488778/job/128138975830?pr=161507
Android (aarch64) https://github.com/python/cpython/actions/runs/42289488778/job/128138975614?pr=161507
Android (x86_64) https://github.com/python/cpython/actions/runs/42289488778/job/128138975866?pr=161507
iOS https://github.com/python/cpython/actions/runs/42289488778/job/128138975534?pr=161507
iOS (free-threading) https://github.com/python/cpython/actions/runs/42289488778/job/128138975689?pr=161507
Emscripten / build and test https://github.com/python/cpython/actions/runs/42289488778/job/128138977028?pr=161507
WASI / build and test https://github.com/python/cpython/actions/runs/42289488778/job/128138976724?pr=161507
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/42289488778/job/128138975319?pr=161507
Lazy imports enabled / Run Tests with lazy_imports=all https://github.com/python/cpython/actions/runs/42289488778/job/128138976780?pr=161507
Sanitizers / TSan https://github.com/python/cpython/actions/runs/42289488778/job/128138978087?pr=161507
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/42289488778/job/128138978172?pr=161507
Sanitizers / ASan https://github.com/python/cpython/actions/runs/42289488778/job/128138978256?pr=161507
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/42289488778/job/128138978101?pr=161507
Sanitizers / MSan https://github.com/python/cpython/actions/runs/42289488778/job/128138978133?pr=161507
Cross build Linux https://github.com/python/cpython/actions/runs/42289488778/job/128138975455?pr=161507
CIFuzz${{ '' }} https://github.com/python/cpython/actions/runs/42289488778/job/128138977310?pr=161507
All required checks pass https://github.com/python/cpython/actions/runs/42289488778/job/128157409103?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42308209691
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42308209691/job/128202847060?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42308209691/job/128202846716?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42308210636
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42308210636/job/128202851356?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42308210636/job/128202851104?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42356716563
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42356716563/job/128356287899?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42356716563/job/128356287721?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42356716592
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42356716592/job/128356287823?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42356716592/job/128356287786?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42356716777
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42356716777/job/128356288558?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42356716777/job/128356288408?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42356716882
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42356716882/job/128356288338?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42356716882/job/128356288568?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42356717264
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42356717264/job/128356289959?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42356717264/job/128356289777?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42356723689
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42356723689/job/128356308199?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42356723689/job/128356307976?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42404705185
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42404705185/job/128499788296?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42404705185/job/128499788046?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42404729618
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42404729618/job/128499861525?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42404729618/job/128499861789?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42404737264
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42404737264/job/128499885019?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42404737264/job/128499884807?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42404744669
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42404744669/job/128499907650?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42404744669/job/128499907373?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42636429483
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42636429483/job/129225671411?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42636429483/job/129225671679?pr=161507
Check labels on: pull_request https://github.com/python/cpython/actions/runs/42636755243
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/42636755243/job/129226819674?pr=161507
Unresolved review https://github.com/python/cpython/actions/runs/42636755243/job/129226818969?pr=161507
.github/workflows/lint.yml#L1 https://github.com/python/cpython/actions/runs/42289488604/workflow
https://github.com/python/cpython/actions/runs/42289488604/job/128138857175
https://github.com/actions/runner-images/issues/14748https://github.com/actions/runner-images/issues/14748
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.