René's URL Explorer Experiment


Title: gh-160978: Return the same ctypes array type when created concurrently by thalesmourabh · Pull Request #161494 · python/cpython · GitHub

Open Graph Title: gh-160978: Return the same ctypes array type when created concurrently by thalesmourabh · Pull Request #161494 · python/cpython

X Title: gh-160978: Return the same ctypes array type when created concurrently by thalesmourabh · Pull Request #161494 · python/cpython

Description: PyCArrayType_from_ctype() looked the array type up in array_cache, created it on a miss, and only then stored it: if (_PyDict_GetItemProxy(st->array_cache, key, &result) != 0) { Py_DECREF(key); return result; } /* not found */ ... result = PyObject_CallFunction((PyObject *)st->PyCArrayType_Type, ...); ... if (PyDict_SetItemProxy(st, st->array_cache, key, result) < 0) { ... } return result; Creating the type runs Python code, so two threads can both miss the cache, both create a type, and each return its own. The second one overwrites the first in the cache, and callers end up holding distinct types for the same item type and length — hence the TypeError: expected c_int_Array_1 instance instead of c_int_Array_1 in the issue. Why not hold a lock around the whole miss path: the type is created by PyObject_CallFunction(), which can run arbitrary Python code — the __set_name__ reproducer in the issue is exactly that. Holding a lock across it invites re-entrancy and deadlock. So this serialises the insertion instead: _PyDict_SetDefaultItemProxy() uses PyDict_SetDefaultRef() so the first type to reach the cache wins, and a thread that loses the race drops the type it built and returns the cached one. Two threads may still both build a type, but they now agree on which one is canonical. If the cached entry has already been cleared by its DictRemover, the new type is installed instead, as before. Tests. Two, because they fail on different builds: default build free-threaded test_concurrent_creation_with_set_name fails without the fix fails without the fix test_concurrent_creation_returns_identical_types passes fails without the fix The first one is the only one that guards the fix on the default build, which is why it is there even though the issue is about free-threading. Checked. Built and tested on --with-pydebug and --with-pydebug --disable-gil at the same commit: full test_ctypes passes on both (648 tests), and passes under -R 3:3 on the free-threaded build. The reproducer in the issue goes from 397/400 failures to 0/400 there. Not covered: I did not audit the other proxy caches in _ctypes (st->cache for pointer types, for instance) for the same pattern. They look similar, but I have not reproduced anything there, so this change is limited to the array cache. Issue: gh-160978

Open Graph Description: PyCArrayType_from_ctype() looked the array type up in array_cache, created it on a miss, and only then stored it: if (_PyDict_GetItemProxy(st->array_cache, key, &result) != 0) { Py_DECRE...

X Description: PyCArrayType_from_ctype() looked the array type up in array_cache, created it on a miss, and only then stored it: if (_PyDict_GetItemProxy(st-&gt;array_cache, key, &amp;result) != 0) { ...

Opengraph URL: https://github.com/python/cpython/pull/161494

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f316b354-df02-c789-935e-7dbdf0b9bacd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBCC6:313081:1B90CED:2450EF5:6B0219B0
html-safe-nonce06f745721f2babafd051f14c359bb46d33b201928985a0365a42dd61c5d1c9da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0M2OjMxMzA4MToxQjkwQ0VEOjI0NTBFRjU6NkIwMjE5QjAiLCJ2aXNpdG9yX2lkIjoiODU1NTQ2Njg2Mjc2OTYwOTEzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2893f59da346e38762ec09172866e4d0a20fd631d7007c757e9ea9a594c07780
hovercard-subject-tagpull_request:5189684676
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/161494/files
twitter:imagehttps://avatars.githubusercontent.com/u/219891155?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/219891155?s=400&v=4
og:image:altPyCArrayType_from_ctype() looked the array type up in array_cache, created it on a miss, and only then stored it: if (_PyDict_GetItemProxy(st->array_cache, key, &result) != 0) { Py_DECRE...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/161494/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161494%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161494%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/161494/files
Reloadhttps://github.com/python/cpython/pull/161494/files
Reloadhttps://github.com/python/cpython/pull/161494/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
thalesmourabh:gh-160978-ctypes-array-cachehttps://github.com/thalesmourabh/cpython/tree/gh-160978-ctypes-array-cache
Conversation 6 https://github.com/python/cpython/pull/161494
Commits 4 https://github.com/python/cpython/pull/161494/commits
Checks 69 https://github.com/python/cpython/pull/161494/checks
Files changed 3 https://github.com/python/cpython/pull/161494/files
gh-160978: Return the same ctypes array type when created concurrently https://github.com/python/cpython/pull/161494/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/161494/files
5ed12c7 gh-160978: Return the same ctypes array type when created concurrently thalesmourabh Nov 6, 2026 https://github.com/python/cpython/pull/161494/commits/5ed12c7d340fedc75d741907933c70bde5ff2ec5
183e57d Skip the new ctypes array cache tests without working threads thalesmourabh Nov 6, 2026 https://github.com/python/cpython/pull/161494/commits/183e57d831429556bb21bed3e17b2cd0f8501fd7
e4fb73a Address review: remove PyDict_SetItemProxy and redundant comment kumaraditya303 Nov 13, 2026 https://github.com/python/cpython/pull/161494/commits/e4fb73a520150f7e01848683a9c4408c965ee1b6
1d3babb Keep array cache entries consistent when a dead entry is replaced kumaraditya303 Nov 13, 2026 https://github.com/python/cpython/pull/161494/commits/1d3babb66008672ded35fa28b31d71dc1d37e2cf
Clear filters https://github.com/python/cpython/pull/161494/files
Please reload this pagehttps://github.com/python/cpython/pull/161494/files
Please reload this pagehttps://github.com/python/cpython/pull/161494/files
test_arrays.py https://github.com/python/cpython/pull/161494/files#diff-d13e55d9a263d0a00ab95cf8098b581526a9e7cda4076a1704bde347033a41fa
2026-11-06-12-00-00.gh-issue-160978.Kx7mQa.rst https://github.com/python/cpython/pull/161494/files#diff-058ea1e1917083de55a4dbb2610b7727fb4327884442f45f46e034519ac4dedd
_ctypes.c https://github.com/python/cpython/pull/161494/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
Lib/test/test_ctypes/test_arrays.pyhttps://github.com/python/cpython/pull/161494/files#diff-d13e55d9a263d0a00ab95cf8098b581526a9e7cda4076a1704bde347033a41fa
View file https://github.com/thalesmourabh/cpython/blob/1d3babb66008672ded35fa28b31d71dc1d37e2cf/Lib/test/test_ctypes/test_arrays.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161494/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161494/files#diff-d13e55d9a263d0a00ab95cf8098b581526a9e7cda4076a1704bde347033a41fa
https://github.com/python/cpython/pull/161494/files#diff-d13e55d9a263d0a00ab95cf8098b581526a9e7cda4076a1704bde347033a41fa
Misc/NEWS.d/next/Library/2026-11-06-12-00-00.gh-issue-160978.Kx7mQa.rsthttps://github.com/python/cpython/pull/161494/files#diff-058ea1e1917083de55a4dbb2610b7727fb4327884442f45f46e034519ac4dedd
View file https://github.com/thalesmourabh/cpython/blob/1d3babb66008672ded35fa28b31d71dc1d37e2cf/Misc/NEWS.d/next/Library/2026-11-06-12-00-00.gh-issue-160978.Kx7mQa.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161494/{{ revealButtonHref }}
Modules/_ctypes/_ctypes.chttps://github.com/python/cpython/pull/161494/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
View file https://github.com/thalesmourabh/cpython/blob/1d3babb66008672ded35fa28b31d71dc1d37e2cf/Modules/_ctypes/_ctypes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161494/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161494/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/161494/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/161494/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/161494/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/161494/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/161494/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
Please reload this pagehttps://github.com/python/cpython/pull/161494/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.