René's URL Explorer Experiment


Title: gh-161242: Cache strerror() messages per errno by cmaloney · Pull Request #161455 · python/cpython · GitHub

Open Graph Title: gh-161242: Cache strerror() messages per errno by cmaloney · Pull Request #161455 · python/cpython

X Title: gh-161242: Cache strerror() messages per errno by cmaloney · Pull Request #161455 · python/cpython

Description: _Py_strerror decodes strerror_r with the locale codec on every call, a large part of the cost of raising OSError. Cache the result for codes 0-255 in a per-interpreter dict; 256 just to keep things from growing unbounded. Error strings are locale specific so _locale.setlocale clears it. EDIT: Updated Perf numbers with tuple cache key: PGO+LTO, main vs this change: Benchmark main strerror cache os.strerror(2) 128 ns 29.1 ns: 4.41x faster stat_missing() 948 ns 766 ns: 1.24x faster open_missing() 1.35 us 1.16 us: 1.16x faster raise_oserror() was not significantly different. import os import pyperf def stat_missing(): try: os.stat('/nonexistent') except OSError: pass def open_missing(): try: open('/nonexistent', 'rb') except OSError: pass def raise_oserror(): try: raise OSError(2, 'No such file or directory') except OSError: pass runner = pyperf.Runner() runner.bench_func("stat_missing()", stat_missing) runner.bench_func("open_missing()", open_missing) runner.bench_func("raise_oserror()", raise_oserror) runner.bench_func("os.strerror(2)", os.strerror, 2) Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com Issue: gh-161242

Open Graph Description: _Py_strerror decodes strerror_r with the locale codec on every call, a large part of the cost of raising OSError. Cache the result for codes 0-255 in a per-interpreter dict; 256 just to keep thing...

X Description: _Py_strerror decodes strerror_r with the locale codec on every call, a large part of the cost of raising OSError. Cache the result for codes 0-255 in a per-interpreter dict; 256 just to keep thing...

Opengraph URL: https://github.com/python/cpython/pull/161455

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4c51ef69-92a0-65da-66bb-f439d38347cf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82F8:11EACE:3883020:4B668F7:6B0216C3
html-safe-nonceb963bae9bcc8deafda67d6371ded1adbc65690b557c1cd6de223e6e7d966ba3f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkY4OjExRUFDRTozODgzMDIwOjRCNjY4Rjc6NkIwMjE2QzMiLCJ2aXNpdG9yX2lkIjoiODI4NzE3NzgwMDcyOTg5MjU0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5fee1c5ee501c020c71445725fad81a4e97671a32efa3aa453e2afba5411aa7c
hovercard-subject-tagpull_request:5180977564
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/161455/files
twitter:imagehttps://avatars.githubusercontent.com/u/751088?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/751088?s=400&v=4
og:image:alt_Py_strerror decodes strerror_r with the locale codec on every call, a large part of the cost of raising OSError. Cache the result for codes 0-255 in a per-interpreter dict; 256 just to keep thing...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/161455/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161455%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161455%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/161455/files
Reloadhttps://github.com/python/cpython/pull/161455/files
Reloadhttps://github.com/python/cpython/pull/161455/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
cmaloneyhttps://github.com/cmaloney
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:oserror_sterror_cachehttps://github.com/cmaloney/cpython/tree/oserror_sterror_cache
Conversation 30 https://github.com/python/cpython/pull/161455
Commits 7 https://github.com/python/cpython/pull/161455/commits
Checks 50 https://github.com/python/cpython/pull/161455/checks
Files changed https://github.com/python/cpython/pull/161455/files
Please reload this pagehttps://github.com/python/cpython/pull/161455/files
gh-161242: Cache strerror() messages per errno https://github.com/python/cpython/pull/161455/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/161455/files
98e6d6e gh-161242: Cache strerror() messages per errno cmaloney Nov 5, 2026 https://github.com/python/cpython/pull/161455/commits/98e6d6e8e0c152ea4284b64e185d06ad996ac38f
1629843 Use open() of a missing file in test_strerror_cached cmaloney Nov 6, 2026 https://github.com/python/cpython/pull/161455/commits/162984394811df1fb705f95554d14f203a04a2f2
53d9206 Clear cache when LC_MESSAGES changes. cmaloney Nov 6, 2026 https://github.com/python/cpython/pull/161455/commits/53d92060fe1164b117bfd2ab1aff174ff1806dd0
ffcbf0f Validate the strerror cache against the current locale cmaloney Nov 10, 2026 https://github.com/python/cpython/pull/161455/commits/ffcbf0f39ce8583316f3cf046248deb3af204551
98bfddf Test a real locale change in test_strerror_cached cmaloney Nov 10, 2026 https://github.com/python/cpython/pull/161455/commits/98bfddfeff8a3da77a9aa935a147b76205570471
47944d3 Address strerror cache review cmaloney Nov 15, 2026 https://github.com/python/cpython/pull/161455/commits/47944d332e9d622edd2560aa4e810d495c7a296d
6389031 Keep the strerror comment in place cmaloney Nov 15, 2026 https://github.com/python/cpython/pull/161455/commits/6389031d14aac82956b5bda7bc4350f241faeaec
Clear filters https://github.com/python/cpython/pull/161455/files
Please reload this pagehttps://github.com/python/cpython/pull/161455/files
Please reload this pagehttps://github.com/python/cpython/pull/161455/files
pycore_exceptions.h https://github.com/python/cpython/pull/161455/files#diff-2cac35b305bce1670ae206e37215070dae3f4e9480ca6e61512fe3d05b066396
test_exception_hierarchy.py https://github.com/python/cpython/pull/161455/files#diff-769168b1ad67e36ad371f32f7e2e4238ca48764dc10d8b6b807a9223fa78b36f
exceptions.c https://github.com/python/cpython/pull/161455/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
fileutils.c https://github.com/python/cpython/pull/161455/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
Include/internal/pycore_exceptions.hhttps://github.com/python/cpython/pull/161455/files#diff-2cac35b305bce1670ae206e37215070dae3f4e9480ca6e61512fe3d05b066396
View file https://github.com/python/cpython/blob/6389031d14aac82956b5bda7bc4350f241faeaec/Include/internal/pycore_exceptions.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161455/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161455/files#diff-2cac35b305bce1670ae206e37215070dae3f4e9480ca6e61512fe3d05b066396
https://github.com/python/cpython/pull/161455/files#diff-2cac35b305bce1670ae206e37215070dae3f4e9480ca6e61512fe3d05b066396
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L247
Lib/test/test_exception_hierarchy.pyhttps://github.com/python/cpython/pull/161455/files#diff-769168b1ad67e36ad371f32f7e2e4238ca48764dc10d8b6b807a9223fa78b36f
View file https://github.com/python/cpython/blob/6389031d14aac82956b5bda7bc4350f241faeaec/Lib/test/test_exception_hierarchy.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161455/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161455/files#diff-769168b1ad67e36ad371f32f7e2e4238ca48764dc10d8b6b807a9223fa78b36f
https://github.com/python/cpython/pull/161455/files#diff-769168b1ad67e36ad371f32f7e2e4238ca48764dc10d8b6b807a9223fa78b36f
https://github.com/python/cpython/pull/161455/files#diff-769168b1ad67e36ad371f32f7e2e4238ca48764dc10d8b6b807a9223fa78b36f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L248
Objects/exceptions.chttps://github.com/python/cpython/pull/161455/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
View file https://github.com/python/cpython/blob/6389031d14aac82956b5bda7bc4350f241faeaec/Objects/exceptions.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161455/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161455/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
https://github.com/python/cpython/pull/161455/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
https://github.com/python/cpython/pull/161455/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
https://github.com/python/cpython/pull/161455/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
Python/fileutils.chttps://github.com/python/cpython/pull/161455/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
View file https://github.com/python/cpython/blob/6389031d14aac82956b5bda7bc4350f241faeaec/Python/fileutils.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161455/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161455/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
vstinnerhttps://github.com/vstinner
Nov 10, 2026https://github.com/python/cpython/pull/161455/files#r4525739111
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/161455/files
https://github.com/python/cpython/pull/161455/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
https://github.com/python/cpython/pull/161455/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
cmaloneyhttps://github.com/cmaloney
Nov 15, 2026https://github.com/python/cpython/pull/161455/files#r4577065501
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/161455/files
Please reload this pagehttps://github.com/python/cpython/pull/161455/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.