René's URL Explorer Experiment


Title: gh-161387: Check the type of the decimal context ContextVar by 0z5a · Pull Request #161399 · python/cpython · GitHub

Open Graph Title: gh-161387: Check the type of the decimal context ContextVar by 0z5a · Pull Request #161399 · python/cpython

X Title: gh-161387: Check the type of the decimal context ContextVar by 0z5a · Pull Request #161399 · python/cpython

Description: Refs gh-161387. _decimal.current_context() returned whatever the internal decimal_context ContextVar held, without checking PyDecContext_Check. Callers immediately cast the value to PyDecContextObject *, so setting the variable to a non-context (for example 1) segfaults on the next decimal operation. Raise TypeError from current_context() when the stored value is not a context. CURRENT_CONTEXT already propagates NULL, so callers fail cleanly. Tests: new CContextAPItests.test_current_context_var_wrong_type. Built current main (5aa2f705) with the C _decimal extension (libmpdec 2.5.1): the reproducer exits with SIGSEGV (rc=139) before the change and raises TypeError after. The new test and the full test_decimal suite (751 tests, 9 skipped) pass.

Open Graph Description: Refs gh-161387. _decimal.current_context() returned whatever the internal decimal_context ContextVar held, without checking PyDecContext_Check. Callers immediately cast the value to PyDecContextObj...

X Description: Refs gh-161387. _decimal.current_context() returned whatever the internal decimal_context ContextVar held, without checking PyDecContext_Check. Callers immediately cast the value to PyDecContextObj...

Opengraph URL: https://github.com/python/cpython/pull/161399

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3f7240aa-f005-b1a7-a84b-801d880ea2c2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE350:3DD488:3E7C1E6:4F63DEC:6B02183D
html-safe-nonce846dddf4d2fceb3b209ae39a85490deb6f63c683c9ea65a77416b23b2e4ac33a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzUwOjNERDQ4ODozRTdDMUU2OjRGNjNERUM6NkIwMjE4M0QiLCJ2aXNpdG9yX2lkIjoiNTUyNjk5NDQ4ODI5MDI0MzE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0cbd0c96a6c75dfcdd9333c81908cb1fefd93de8bc711c82b3fcf448bfddc44b
hovercard-subject-tagpull_request:5169449717
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/161399/files
twitter:imagehttps://avatars.githubusercontent.com/u/192209249?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/192209249?s=400&v=4
og:image:altRefs gh-161387. _decimal.current_context() returned whatever the internal decimal_context ContextVar held, without checking PyDecContext_Check. Callers immediately cast the value to PyDecContextObj...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/161399/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161399%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161399%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/161399/files
Reloadhttps://github.com/python/cpython/pull/161399/files
Reloadhttps://github.com/python/cpython/pull/161399/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
0z5a:fix-decimal-contextvar-typehttps://github.com/0z5a/cpython/tree/fix-decimal-contextvar-type
Conversation 17 https://github.com/python/cpython/pull/161399
Commits 8 https://github.com/python/cpython/pull/161399/commits
Checks 66 https://github.com/python/cpython/pull/161399/checks
Files changed https://github.com/python/cpython/pull/161399/files
Please reload this pagehttps://github.com/python/cpython/pull/161399/files
gh-161387: Check the type of the decimal context ContextVar https://github.com/python/cpython/pull/161399/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/161399/files
cd34ce8 gh-161387: Check the type of the decimal context ContextVar 0z5a Nov 5, 2026 https://github.com/python/cpython/pull/161399/commits/cd34ce8a6ff1fd1c2bba038fb41f395bd8be9ca3
0254fa8 Fix test isolation for the duplicate decimal_context var 0z5a Nov 5, 2026 https://github.com/python/cpython/pull/161399/commits/0254fa8b5667ade46832379c9a2eaced1ed829d0
c10e2e7 Address review: report the received type, tidy the test 0z5a Nov 5, 2026 https://github.com/python/cpython/pull/161399/commits/c10e2e7b9e88df2ce4cbd6c5852d7f8739727e45
18682f0 Skip the test when _decimal has no context variables 0z5a Nov 5, 2026 https://github.com/python/cpython/pull/161399/commits/18682f0a016469c942598ecc41572cfbe012cf4b
6c4cfcb Update Modules/_decimal/_decimal.c 0z5a Nov 5, 2026 https://github.com/python/cpython/pull/161399/commits/6c4cfcb91dbd53bfa86f9152f86cc580ef17efdb
360d166 Update Lib/test/test_decimal.py 0z5a Nov 5, 2026 https://github.com/python/cpython/pull/161399/commits/360d1667639a68178add5311bd9b231d9a1a710a
589b9f2 Test that the wrong-typed context is not leaked 0z5a Nov 5, 2026 https://github.com/python/cpython/pull/161399/commits/589b9f2ef7c8ab55fff7d58b8cf438bda2320ed1
7bbee0d Assert the context var is unchanged and check the error message 0z5a Nov 5, 2026 https://github.com/python/cpython/pull/161399/commits/7bbee0df95dd9b48234bf2d0d2fe5d64b07eac8e
Clear filters https://github.com/python/cpython/pull/161399/files
Please reload this pagehttps://github.com/python/cpython/pull/161399/files
Please reload this pagehttps://github.com/python/cpython/pull/161399/files
test_decimal.py https://github.com/python/cpython/pull/161399/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
2026-11-05-10-05-00.gh-issue-161387.def456.rst https://github.com/python/cpython/pull/161399/files#diff-e75506e19fdb1d65c6304872b67709fd5816e69306e9375f3bc47b1e93bf5a1e
_decimal.c https://github.com/python/cpython/pull/161399/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
Lib/test/test_decimal.pyhttps://github.com/python/cpython/pull/161399/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
View file https://github.com/0z5a/cpython/blob/7bbee0df95dd9b48234bf2d0d2fe5d64b07eac8e/Lib/test/test_decimal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161399/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161399/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
Please reload this pagehttps://github.com/python/cpython/pull/161399/files
https://github.com/python/cpython/pull/161399/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
Misc/NEWS.d/next/Library/2026-11-05-10-05-00.gh-issue-161387.def456.rsthttps://github.com/python/cpython/pull/161399/files#diff-e75506e19fdb1d65c6304872b67709fd5816e69306e9375f3bc47b1e93bf5a1e
View file https://github.com/0z5a/cpython/blob/7bbee0df95dd9b48234bf2d0d2fe5d64b07eac8e/Misc/NEWS.d/next/Library/2026-11-05-10-05-00.gh-issue-161387.def456.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161399/{{ revealButtonHref }}
Modules/_decimal/_decimal.chttps://github.com/python/cpython/pull/161399/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
View file https://github.com/0z5a/cpython/blob/7bbee0df95dd9b48234bf2d0d2fe5d64b07eac8e/Modules/_decimal/_decimal.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161399/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161399/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
Please reload this pagehttps://github.com/python/cpython/pull/161399/files
https://github.com/python/cpython/pull/161399/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
Please reload this pagehttps://github.com/python/cpython/pull/161399/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.