René's URL Explorer Experiment


Title: gh-159184: Do not intern NaN constants on the free-threaded build by cmaloney · Pull Request #161276 · python/cpython · GitHub

Open Graph Title: gh-159184: Do not intern NaN constants on the free-threaded build by cmaloney · Pull Request #161276 · python/cpython

X Title: gh-159184: Do not intern NaN constants on the free-threaded build by cmaloney · Pull Request #161276 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: compare_constants() matches floats by bits, but hash_const() uses the object hash, which for a NaN depends on its address, so each NaN loaded by marshal.loads() added an immortal entry to the const...

X Description: compare_constants() matches floats by bits, but hash_const() uses the object hash, which for a NaN depends on its address, so each NaN loaded by marshal.loads() added an immortal entry to the const...

Opengraph URL: https://github.com/python/cpython/pull/161276

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:c6fc85cb-833b-2fa3-0252-833f6d350749
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE56:20AA01:40AF242:521272F:6B0208F3
html-safe-nonce19512107c2f79e25da70b3c4f36c9f60c5385323493a0a71df7acd3a5bea0f42
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTU2OjIwQUEwMTo0MEFGMjQyOjUyMTI3MkY6NkIwMjA4RjMiLCJ2aXNpdG9yX2lkIjoiMzY2NjkyNTYxNjA1OTUxNzE3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbc4da09f5d201859ec590204575c7ded671711483134c6d4889fb4fb0b69dfb1
hovercard-subject-tagpull_request:5145593919
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/161276
twitter:imagehttps://opengraph.githubassets.com/2c6197586cd14871671d2e5bf8cb9b9d2eea6d3442b6cbfa96a6f0513a56f70d/python/cpython/pull/161276
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2c6197586cd14871671d2e5bf8cb9b9d2eea6d3442b6cbfa96a6f0513a56f70d/python/cpython/pull/161276
og:image:altcompare_constants() matches floats by bits, but hash_const() uses the object hash, which for a NaN depends on its address, so each NaN loaded by marshal.loads() added an immortal entry to the const...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecmaloney
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/161276#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161276
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161276
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/161276
Reloadhttps://github.com/python/cpython/pull/161276
Reloadhttps://github.com/python/cpython/pull/161276
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:gh-159184-ft-nan-constantshttps://github.com/cmaloney/cpython/tree/gh-159184-ft-nan-constants
Conversationhttps://github.com/python/cpython/pull/161276
Commits1 (1)https://github.com/python/cpython/pull/161276/commits
Checkshttps://github.com/python/cpython/pull/161276/checks
Files changedhttps://github.com/python/cpython/pull/161276/files
gh-159184: Do not intern NaN constants on the free-threaded buildhttps://github.com/python/cpython/pull/161276#top
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:gh-159184-ft-nan-constantshttps://github.com/cmaloney/cpython/tree/gh-159184-ft-nan-constants
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Nov 3, 2026https://github.com/python/cpython/pull/161276#issue-6192421785
Please reload this pagehttps://github.com/python/cpython/pull/161276
marshal.dumps() raises TypeError for a set containing several complex NaNs #159184https://github.com/python/cpython/issues/159184
Please reload this pagehttps://github.com/python/cpython/pull/161276
https://github.com/cmaloney
https://github.com/claude
pythongh-159184https://github.com/python/cpython/issues/159184
: Do not intern NaN constants on the free-threaded buildhttps://github.com/python/cpython/pull/161276/commits/aba373ccdeb6a5e14bcfd9e452ca1b499126fbe8
aba373chttps://github.com/python/cpython/pull/161276/commits/aba373ccdeb6a5e14bcfd9e452ca1b499126fbe8
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/9c37326308f7583eb921d4a03c2b8012d402b3e0/.github/CODEOWNERS#L207
November 3, 2026 22:37https://github.com/python/cpython/pull/161276#event-35072173037
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 3, 2026https://github.com/python/cpython/pull/161276#event-35072176962
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 3, 2026 https://github.com/python/cpython/pull/161276#ref-issue-5803459096
marshal.dumps() raises TypeError for a set containing several complex NaNs #159184 https://github.com/python/cpython/issues/159184
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Nov 3, 2026https://github.com/python/cpython/pull/161276#issuecomment-6617329419
Please reload this pagehttps://github.com/python/cpython/pull/161276
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 3, 2026https://github.com/python/cpython/pull/161276#issuecomment-6617330342
@cmaloneyhttps://github.com/cmaloney
aba373chttps://github.com/python/cpython/commit/aba373ccdeb6a5e14bcfd9e452ca1b499126fbe8
https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F161276%2Fmergehttps://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F161276%2Fmerge
Please reload this pagehttps://github.com/python/cpython/pull/161276
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Nov 4, 2026 https://github.com/python/cpython/pull/161276#pullrequestreview-5761614132
View reviewed changes https://github.com/python/cpython/pull/161276/files/aba373ccdeb6a5e14bcfd9e452ca1b499126fbe8
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 4, 2026https://github.com/python/cpython/pull/161276#event-35080640591
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
1db5966https://github.com/python/cpython/commit/1db5966141a9ca736add1a9699dde926e8099b14
Nov 4, 2026https://github.com/python/cpython/pull/161276#event-35080663791
Please reload this pagehttps://github.com/python/cpython/pull/161276
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 4, 2026https://github.com/python/cpython/pull/161276#event-35080667884
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 4, 2026https://github.com/python/cpython/pull/161276#event-35080740161
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 4, 2026https://github.com/python/cpython/pull/161276#issuecomment-6619431932
@cmaloneyhttps://github.com/cmaloney
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/161276
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 4, 2026https://github.com/python/cpython/pull/161276#issuecomment-6619431997
@cmaloneyhttps://github.com/cmaloney
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/161276
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 4, 2026https://github.com/python/cpython/pull/161276#issuecomment-6619436120
GH-161286https://github.com/python/cpython/pull/161286
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/161276
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Nov 4, 2026https://github.com/python/cpython/pull/161276#event-35080760648
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 4, 2026https://github.com/python/cpython/pull/161276#issuecomment-6619437896
GH-161287https://github.com/python/cpython/pull/161287
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/161276
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 4, 2026https://github.com/python/cpython/pull/161276#event-35080767440
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
November 4, 2026 01:59https://github.com/python/cpython/pull/161276#event-35084790029
gpsheadhttps://github.com/gpshead
Nov 5, 2026 https://github.com/python/cpython/pull/161276#ref-commit-476b725
https://github.com/miss-islington
https://github.com/cmaloney
https://github.com/claude
[3.15]https://github.com/python/cpython/commit/476b725e461c43145b51700f080a58f302ed3dfb
gh-159184https://github.com/python/cpython/issues/159184
: Do not intern NaN constants on the free-threaded bu…https://github.com/python/cpython/commit/476b725e461c43145b51700f080a58f302ed3dfb
476b725https://github.com/python/cpython/commit/476b725e461c43145b51700f080a58f302ed3dfb
GH-161276https://github.com/python/cpython/pull/161276
#161287https://github.com/python/cpython/pull/161287
gh-159184https://github.com/python/cpython/issues/159184
GH-161276https://github.com/python/cpython/pull/161276
1db5966https://github.com/python/cpython/commit/1db5966141a9ca736add1a9699dde926e8099b14
gpsheadhttps://github.com/gpshead
Nov 5, 2026 https://github.com/python/cpython/pull/161276#ref-commit-a2be2bf
https://github.com/miss-islington
https://github.com/cmaloney
https://github.com/claude
[3.14]https://github.com/python/cpython/commit/a2be2bf8535bf93fe6c0c28ca64f56df9ca4b80a
gh-159184https://github.com/python/cpython/issues/159184
: Do not intern NaN constants on the free-threaded bu…https://github.com/python/cpython/commit/a2be2bf8535bf93fe6c0c28ca64f56df9ca4b80a
a2be2bfhttps://github.com/python/cpython/commit/a2be2bf8535bf93fe6c0c28ca64f56df9ca4b80a
GH-161276https://github.com/python/cpython/pull/161276
#161286https://github.com/python/cpython/pull/161286
gh-159184https://github.com/python/cpython/issues/159184
GH-161276https://github.com/python/cpython/pull/161276
1db5966https://github.com/python/cpython/commit/1db5966141a9ca736add1a9699dde926e8099b14
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161276
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/161276/files/aba373ccdeb6a5e14bcfd9e452ca1b499126fbe8
https://github.com/markshannon
markshannon https://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/161276
Please reload this pagehttps://github.com/python/cpython/pull/161276
https://github.com/cmaloney
https://github.com/bedevere-bot
https://github.com/gpshead
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.