René's URL Explorer Experiment


Title: gh-156910: Add free-threading regression test for type_set_abstractmethods() deadlock by davidwelling2 · Pull Request #161195 · python/cpython · GitHub

Open Graph Title: gh-156910: Add free-threading regression test for type_set_abstractmethods() deadlock by davidwelling2 · Pull Request #161195 · python/cpython

X Title: gh-156910: Add free-threading regression test for type_set_abstractmethods() deadlock by davidwelling2 · Pull Request #161195 · python/cpython

Description: Follow-up to gh-156948, which fixed the deadlock but didn't add a test. This adds test_abstractmethods_and_register to test_free_threading/test_type.py. It races ABC class creation (type_set_abstractmethods() stops the world under TYPE_LOCK) against collections.abc.Sequence.register() (_PyType_SetFlagsRecursive() stops the world with TYPE_LOCK pinned), with a gc.collect() thread to add contention on the stop-the-world mutex. Tested on a --disable-gil --with-pydebug build: on main before gh-159972, reverting the Objects/typeobject.c change from gh-156948 made the test hang in 7/7 runs (killed at 120s); with it, it passed 20/20 (~2s each). It also passes 20/20 on current main after gh-159972 (gh-158195), which reworked how TYPE_LOCK interacts with stop-the-world, so the test now guards both fixes. This should be backported to 3.15 only. 3.14's type_set_abstractmethods() doesn't stop the world, so it doesn't have this bug. AI assistance was used in preparing this change; I have reviewed and tested it. Issue: gh-156910

Open Graph Description: Follow-up to gh-156948, which fixed the deadlock but didn't add a test. This adds test_abstractmethods_and_register to test_free_threading/test_type.py. It races ABC class creation (type_set_ab...

X Description: Follow-up to gh-156948, which fixed the deadlock but didn't add a test. This adds test_abstractmethods_and_register to test_free_threading/test_type.py. It races ABC class creation (type_se...

Opengraph URL: https://github.com/python/cpython/pull/161195

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c62ed773-84cd-faf7-6e77-f0ca6efbc702
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA54:1F2F:1CAC33A:2611A85:6B021626
html-safe-nonce5cb56e9d950ef6be8fc322858e812c9ea9c119d5547c85d6d382a9130867869d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTU0OjFGMkY6MUNBQzMzQToyNjExQTg1OjZCMDIxNjI2IiwidmlzaXRvcl9pZCI6Ijc5NTk1ODA1MTAyNTcyODg3NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac17657e8d812a52c7177df65341226b0ae8fd6281ef65d3fd304267eea28fe8e3
hovercard-subject-tagpull_request:5123800870
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/161195/files
twitter:imagehttps://avatars.githubusercontent.com/u/351580647?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/351580647?s=400&v=4
og:image:altFollow-up to gh-156948, which fixed the deadlock but didn't add a test. This adds test_abstractmethods_and_register to test_free_threading/test_type.py. It races ABC class creation (type_set_ab...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/161195/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161195%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F161195%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/161195/files
Reloadhttps://github.com/python/cpython/pull/161195/files
Reloadhttps://github.com/python/cpython/pull/161195/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
davidwelling2https://github.com/davidwelling2
python:mainhttps://github.com/python/cpython/tree/main
davidwelling2:gh-156910-abstractmethods-testhttps://github.com/davidwelling2/cpython/tree/gh-156910-abstractmethods-test
Conversation 1 https://github.com/python/cpython/pull/161195
Commits 1 https://github.com/python/cpython/pull/161195/commits
Checks 0 https://github.com/python/cpython/pull/161195/checks
Files changed https://github.com/python/cpython/pull/161195/files
Please reload this pagehttps://github.com/python/cpython/pull/161195/files
gh-156910: Add free-threading regression test for type_set_abstractmethods() deadlock https://github.com/python/cpython/pull/161195/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/161195/files
c3d4f27 gh-156910: Add free-threading regression test for type_set_abstractme… davidwelling2 Nov 2, 2026 https://github.com/python/cpython/pull/161195/commits/c3d4f2784c6fe7a7f555127a22ff7d9bc16aad19
Clear filters https://github.com/python/cpython/pull/161195/files
Please reload this pagehttps://github.com/python/cpython/pull/161195/files
Please reload this pagehttps://github.com/python/cpython/pull/161195/files
test_type.py https://github.com/python/cpython/pull/161195/files#diff-3c426450792efb85491fe7c8888758e54cbef12bcc110ba6a1a460e400a3a901
2026-11-02-16-28-30.gh-issue-156910.wGcXXy.rst https://github.com/python/cpython/pull/161195/files#diff-cffad79058d91a36208884f4aa2410e5623d5207a811856dbdbaafe83f691da1
Lib/test/test_free_threading/test_type.pyhttps://github.com/python/cpython/pull/161195/files#diff-3c426450792efb85491fe7c8888758e54cbef12bcc110ba6a1a460e400a3a901
View file https://github.com/python/cpython/blob/c3d4f2784c6fe7a7f555127a22ff7d9bc16aad19/Lib/test/test_free_threading/test_type.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/161195/files#diff-3c426450792efb85491fe7c8888758e54cbef12bcc110ba6a1a460e400a3a901
https://github.com/python/cpython/pull/161195/files#diff-3c426450792efb85491fe7c8888758e54cbef12bcc110ba6a1a460e400a3a901
https://github.com/python/cpython/pull/161195/files#diff-3c426450792efb85491fe7c8888758e54cbef12bcc110ba6a1a460e400a3a901
Misc/NEWS.d/next/Tests/2026-11-02-16-28-30.gh-issue-156910.wGcXXy.rsthttps://github.com/python/cpython/pull/161195/files#diff-cffad79058d91a36208884f4aa2410e5623d5207a811856dbdbaafe83f691da1
View file https://github.com/python/cpython/blob/c3d4f2784c6fe7a7f555127a22ff7d9bc16aad19/Misc/NEWS.d/next/Tests/2026-11-02-16-28-30.gh-issue-156910.wGcXXy.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/161195/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.