René's URL Explorer Experiment


Title: gh-160864: Clean up refused native thread starts by GriffinCanCode · Pull Request #160865 · python/cpython · GitHub

Open Graph Title: gh-160864: Clean up refused native thread starts by GriffinCanCode · Pull Request #160865 · python/cpython

X Title: gh-160864: Clean up refused native thread starts by GriffinCanCode · Pull Request #160865 · python/cpython

Description: Fixes #160864. Remove a thread from _limbo when the native-start call refuses creation with a BaseException, including KeyboardInterrupt and SystemExit. The original exception still propagates. Check the native handle before cleanup. An exception can arrive as the native call returns after creating an OS thread; that thread must keep its registration until bootstrap consumes it. The handle check runs only on the exceptional path. Tests exercise real audit-hook refusal for RuntimeError, KeyboardInterrupt and SystemExit, plus a profiler interruption immediately after native creation. The latter checks that the child still completes without bootstrap errors. This leaves context initialization and child-bootstrap failures outside the scope of this fix. Related work in #140746 and #153776 addresses failures after OS-thread creation. Validation: Both focused tests pass. Original code fails the two new audit-refusal cases; an unconditional BaseException cleanup fails the post-native test with a child-bootstrap KeyError. The full debug-build suite ran 52,062 tests, with 4 failures and 2,873 skips. The failures are test_chown_gid and three pathlib test_glob_dotdot assertions; all four reproduce with original threading.py. Threading, thread pools and subprocess tests pass, as do the multiprocessing modules that ran. Pinned pre-commit hooks pass on both Python files. Sphinx lint passes on the NEWS text. All four changed executable lines were profiled, including both guard outcomes. The successful path executes the same 60 Python instructions. Timing on the busy macOS host was noisy: normal-start CPU medians rose 3.3% initially and 0.4% in one bounded follow-up; wall medians rose 50.1% and 3.5%. I am not claiming a speedup. Refused-start CPU medians were 2.858 to 2.807 microseconds for RuntimeError, 2.657 to 2.897 for KeyboardInterrupt, and 2.564 to 2.914 for SystemExit; the latter two now perform cleanup that the baseline omits. After 1,000 real audit-hook refusals, the baseline retained 1,000 thread objects and the fix retained none. Tracemalloc recorded 2,449,950 versus 88,960 current bytes, including the harness's weak-reference bookkeeping. AI tools helped investigate the failure, prepare the patch and tests, and run the checks. Issue: gh-160864

Open Graph Description: Fixes #160864. Remove a thread from _limbo when the native-start call refuses creation with a BaseException, including KeyboardInterrupt and SystemExit. The original exception still propagates. Che...

X Description: Fixes #160864. Remove a thread from _limbo when the native-start call refuses creation with a BaseException, including KeyboardInterrupt and SystemExit. The original exception still propagates. Che...

Opengraph URL: https://github.com/python/cpython/pull/160865

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c2557f12-4eec-dd6e-d8c7-43fb05880185
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8484:3CBB3E:37806B0:46BD777:6B0236C4
html-safe-nonce2482acc213cd8b788507a278b534f650aa2566e60dcaf9381f5ab6c4372147ce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDg0OjNDQkIzRTozNzgwNkIwOjQ2QkQ3Nzc6NkIwMjM2QzQiLCJ2aXNpdG9yX2lkIjoiMjgwNDE2Nzc1OTc1ODUwNTY2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac570d7161c2dae79af4cb43dbcf54e036bd197ad293c792682582063a4eda1ba7
hovercard-subject-tagpull_request:5062046308
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/160865/files
twitter:imagehttps://avatars.githubusercontent.com/u/176360130?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/176360130?s=400&v=4
og:image:altFixes #160864. Remove a thread from _limbo when the native-start call refuses creation with a BaseException, including KeyboardInterrupt and SystemExit. The original exception still propagates. Che...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/160865/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160865%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160865%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160865/files
Reloadhttps://github.com/python/cpython/pull/160865/files
Reloadhttps://github.com/python/cpython/pull/160865/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
GriffinCanCodehttps://github.com/GriffinCanCode
python:mainhttps://github.com/python/cpython/tree/main
GriffinCanCode:codex/thread-start-base-exception-cleanuphttps://github.com/GriffinCanCode/cpython/tree/codex/thread-start-base-exception-cleanup
Conversation 8 https://github.com/python/cpython/pull/160865
Commits 4 https://github.com/python/cpython/pull/160865/commits
Checks 55 https://github.com/python/cpython/pull/160865/checks
Files changed https://github.com/python/cpython/pull/160865/files
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
gh-160864: Clean up refused native thread starts https://github.com/python/cpython/pull/160865/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/160865/files
93d0581 fix: Clean up refused native thread starts GriffinCanCode Oct 29, 2026 https://github.com/python/cpython/pull/160865/commits/93d0581f62deb96f825fc7ba5483bf288e2cff66
14224f9 refactor: Fit thread test condition to PEP 8 GriffinCanCode Oct 29, 2026 https://github.com/python/cpython/pull/160865/commits/14224f9cd51c900ae444d014063cbf81264f551b
7de1182 gh-160864: Note refused native thread startup cleanup GriffinCanCode Oct 29, 2026 https://github.com/python/cpython/pull/160865/commits/7de11820ded6d976999172116d9d5ebd45fb840c
785af1a gh-160864: Retry CI after known sampling flake GriffinCanCode Oct 29, 2026 https://github.com/python/cpython/pull/160865/commits/785af1a8d64c71309f77e4278f5dea2da8a0f92b
Clear filters https://github.com/python/cpython/pull/160865/files
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
test_threading.py https://github.com/python/cpython/pull/160865/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
threading.py https://github.com/python/cpython/pull/160865/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
2026-10-28-21-13-15.gh-issue-160864.3924f7.rst https://github.com/python/cpython/pull/160865/files#diff-2a6af00f099a69cf9fb5562a63fbe2b5df128a4ed34fe94620d172b892b17fe2
Lib/test/test_threading.pyhttps://github.com/python/cpython/pull/160865/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
View file https://github.com/python/cpython/blob/785af1a8d64c71309f77e4278f5dea2da8a0f92b/Lib/test/test_threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160865/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160865/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
NekoAsakurahttps://github.com/NekoAsakura
Oct 29, 2026https://github.com/python/cpython/pull/160865/files#r4409004084
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
GriffinCanCodehttps://github.com/GriffinCanCode
Oct 29, 2026https://github.com/python/cpython/pull/160865/files#r4416337612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
NekoAsakurahttps://github.com/NekoAsakura
Oct 29, 2026https://github.com/python/cpython/pull/160865/files#r4409005422
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
GriffinCanCodehttps://github.com/GriffinCanCode
Oct 29, 2026https://github.com/python/cpython/pull/160865/files#r4416337338
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
NekoAsakurahttps://github.com/NekoAsakura
Oct 29, 2026https://github.com/python/cpython/pull/160865/files#r4409018340
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
GriffinCanCodehttps://github.com/GriffinCanCode
Oct 29, 2026https://github.com/python/cpython/pull/160865/files#r4416337127
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
https://github.com/python/cpython/pull/160865/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
Lib/threading.pyhttps://github.com/python/cpython/pull/160865/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
View file https://github.com/python/cpython/blob/785af1a8d64c71309f77e4278f5dea2da8a0f92b/Lib/threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160865/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160865/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/160865/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
Misc/NEWS.d/next/Library/2026-10-28-21-13-15.gh-issue-160864.3924f7.rsthttps://github.com/python/cpython/pull/160865/files#diff-2a6af00f099a69cf9fb5562a63fbe2b5df128a4ed34fe94620d172b892b17fe2
View file https://github.com/python/cpython/blob/785af1a8d64c71309f77e4278f5dea2da8a0f92b/Misc/NEWS.d/next/Library/2026-10-28-21-13-15.gh-issue-160864.3924f7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160865/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/160865/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.