René's URL Explorer Experiment


Title: gh-158780: Preserve defects in unstructured email headers by GriffinCanCode · Pull Request #160862 · python/cpython · GitHub

Open Graph Title: gh-158780: Preserve defects in unstructured email headers by GriffinCanCode · Pull Request #160862 · python/cpython

X Title: gh-158780: Preserve defects in unstructured email headers by GriffinCanCode · Pull Request #160862 · python/cpython

Description: Fixes #158780. Unstructured headers discard the defects already recorded in their parse tree. For example, HeaderRegistry()('Subject', '=?utf-8?b?YQ?=') decodes to 'a' but reports no InvalidBase64PaddingDefect through its public defects attribute. Propagate those defects and avoid repeated sibling-list concatenation in the existing collector. Keep defect order, duplicate object identity, and empty-tree behavior. The existing parameterized tests now check decoding, defects, and folding for both Subject and custom headers. This omission also appears in catalog item 34b. The collector is listed in #136063, alongside the active parser work in #152521 and #152710. Neither PR currently implements these two changes; this is a small fix in the same area, with that prior work acknowledged. Validation on macOS arm64, CPython 3.16 debug: ./python.exe -m test test_email test_mailbox test_smtplib: 2,305 tests, 5 skips. make patchcheck and the applicable pinned pre-commit hooks pass. Decoding and folding match in 78 comparisons across three policies. All five added runtime lines were profiled; bounded measurements checked CPU, wall time, and traced allocations without claiming universal speed improvements. The full 561-module run completed with local failures in test_chown_gid, three test_glob_dotdot cases, and test_fast_path_avoid_busy_loop. The first two reproduce with the original email package; the subprocess assertion passes in a focused rerun. The full run is not clean. AI assistance: Codex helped investigate the behavior, prepare the patch and tests, and run the checks and profiling. Issue: gh-158780

Open Graph Description: Fixes #158780. Unstructured headers discard the defects already recorded in their parse tree. For example, HeaderRegistry()('Subject', '=?utf-8?b?YQ?=') decodes to 'a' but r...

X Description: Fixes #158780. Unstructured headers discard the defects already recorded in their parse tree. For example, HeaderRegistry()('Subject', '=?utf-8?b?YQ?=') decodes to &...

Opengraph URL: https://github.com/python/cpython/pull/160862

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8a62c22b-0ac0-6923-6cbb-82f76d76ca52
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9ACC:3B07B3:9158F1:B62CAF:6B0217EA
html-safe-nonce19ce7155524cbad594c5ecc049d3f78e79032ee72ebc312c63cad031cfb35c60
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUNDOjNCMDdCMzo5MTU4RjE6QjYyQ0FGOjZCMDIxN0VBIiwidmlzaXRvcl9pZCI6Ijc3NTYxMDU5NDkyNzc5ODQ3NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb84076a0610335a17e42962237ba7621a51f14b08ca7d49695d7a2b8417021ab
hovercard-subject-tagpull_request:5061568737
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/160862/files
twitter:imagehttps://avatars.githubusercontent.com/u/176360130?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/176360130?s=400&v=4
og:image:altFixes #158780. Unstructured headers discard the defects already recorded in their parse tree. For example, HeaderRegistry()('Subject', '=?utf-8?b?YQ?=') decodes to 'a' but r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/160862/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160862%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160862%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160862/files
Reloadhttps://github.com/python/cpython/pull/160862/files
Reloadhttps://github.com/python/cpython/pull/160862/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
GriffinCanCodehttps://github.com/GriffinCanCode
python:mainhttps://github.com/python/cpython/tree/main
GriffinCanCode:codex/email-unstructured-header-defectshttps://github.com/GriffinCanCode/cpython/tree/codex/email-unstructured-header-defects
Conversation 2 https://github.com/python/cpython/pull/160862
Commits 5 https://github.com/python/cpython/pull/160862/commits
Checks 54 https://github.com/python/cpython/pull/160862/checks
Files changed https://github.com/python/cpython/pull/160862/files
Please reload this pagehttps://github.com/python/cpython/pull/160862/files
gh-158780: Preserve defects in unstructured email headers https://github.com/python/cpython/pull/160862/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/160862/files
7bc5723 gh-158780: Preserve defects in unstructured email headers GriffinCanCode Oct 29, 2026 https://github.com/python/cpython/pull/160862/commits/7bc5723657574f906a6928a74723178427a744c6
fa54a1a gh-158780: Cover text and combined header defects GriffinCanCode Oct 29, 2026 https://github.com/python/cpython/pull/160862/commits/fa54a1acd760a6c659b7b1d6295dca1af519d9fa
69efd73 gh-158780: Reuse unstructured header test cases GriffinCanCode Oct 29, 2026 https://github.com/python/cpython/pull/160862/commits/69efd73a1dd4c0112e7882dde1b8d4a00e190d43
8d10a01 gh-158780: Collect header defects without repeated copying GriffinCanCode Oct 29, 2026 https://github.com/python/cpython/pull/160862/commits/8d10a015e302fe5d953a59a2d581bf49bfe3aa7e
712db7d gh-158780: Match surrounding header test layout GriffinCanCode Oct 29, 2026 https://github.com/python/cpython/pull/160862/commits/712db7d7cc8820acdbf2ead9c44cbbc2f9ae9beb
Clear filters https://github.com/python/cpython/pull/160862/files
Please reload this pagehttps://github.com/python/cpython/pull/160862/files
Please reload this pagehttps://github.com/python/cpython/pull/160862/files
_header_value_parser.py https://github.com/python/cpython/pull/160862/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
headerregistry.py https://github.com/python/cpython/pull/160862/files#diff-f85d622b1a28a4b95e7c002fa4d122fa17432857826708d2febd0033a2848d9c
test__header_value_parser.py https://github.com/python/cpython/pull/160862/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
test_headerregistry.py https://github.com/python/cpython/pull/160862/files#diff-dc8bbb38fe110368deddc8c037f2898646059fe5b3299da68159ba5ef4721c2b
2026-10-28-18-44-59.gh-issue-158780.J9qR4s.rst https://github.com/python/cpython/pull/160862/files#diff-760cffad3a8c027799b19ae0f7a4209932c662b72071ad7c9b16648eb7c7d286
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/email/_header_value_parser.pyhttps://github.com/python/cpython/pull/160862/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
View file https://github.com/GriffinCanCode/cpython/blob/712db7d7cc8820acdbf2ead9c44cbbc2f9ae9beb/Lib/email/_header_value_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160862/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160862/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/160862/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/email/headerregistry.pyhttps://github.com/python/cpython/pull/160862/files#diff-f85d622b1a28a4b95e7c002fa4d122fa17432857826708d2febd0033a2848d9c
View file https://github.com/GriffinCanCode/cpython/blob/712db7d7cc8820acdbf2ead9c44cbbc2f9ae9beb/Lib/email/headerregistry.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160862/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160862/files#diff-f85d622b1a28a4b95e7c002fa4d122fa17432857826708d2febd0033a2848d9c
https://github.com/python/cpython/pull/160862/files#diff-f85d622b1a28a4b95e7c002fa4d122fa17432857826708d2febd0033a2848d9c
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/test/test_email/test__header_value_parser.pyhttps://github.com/python/cpython/pull/160862/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
View file https://github.com/GriffinCanCode/cpython/blob/712db7d7cc8820acdbf2ead9c44cbbc2f9ae9beb/Lib/test/test_email/test__header_value_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160862/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160862/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
https://github.com/python/cpython/pull/160862/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/test/test_email/test_headerregistry.pyhttps://github.com/python/cpython/pull/160862/files#diff-dc8bbb38fe110368deddc8c037f2898646059fe5b3299da68159ba5ef4721c2b
View file https://github.com/GriffinCanCode/cpython/blob/712db7d7cc8820acdbf2ead9c44cbbc2f9ae9beb/Lib/test/test_email/test_headerregistry.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160862/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160862/files#diff-dc8bbb38fe110368deddc8c037f2898646059fe5b3299da68159ba5ef4721c2b
https://github.com/python/cpython/pull/160862/files#diff-dc8bbb38fe110368deddc8c037f2898646059fe5b3299da68159ba5ef4721c2b
Misc/NEWS.d/next/Library/2026-10-28-18-44-59.gh-issue-158780.J9qR4s.rsthttps://github.com/python/cpython/pull/160862/files#diff-760cffad3a8c027799b19ae0f7a4209932c662b72071ad7c9b16648eb7c7d286
View file https://github.com/GriffinCanCode/cpython/blob/712db7d7cc8820acdbf2ead9c44cbbc2f9ae9beb/Misc/NEWS.d/next/Library/2026-10-28-18-44-59.gh-issue-158780.J9qR4s.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160862/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/160862/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.