René's URL Explorer Experiment


Title: gh-59515: Support multiple challenges in urllib Digest Auth by orsenthil · Pull Request #160828 · python/cpython · GitHub

Open Graph Title: gh-59515: Support multiple challenges in urllib Digest Auth by orsenthil · Pull Request #160828 · python/cpython

X Title: gh-59515: Support multiple challenges in urllib Digest Auth by orsenthil · Pull Request #160828 · python/cpython

Description: HTTPDigestAuthHandler and ProxyDigestAuthHandler only looked at the first WWW-Authenticate / Proxy-Authenticate header and took its first word as the scheme. As a result: A Digest challenge was ignored if a Basic challenge came first, in the same header or in an earlier one. An unsupported scheme listed first (for example Kerberos, Basic realm="x") raised ValueError. Because the Digest handler runs before the Basic handler, that also blocked HTTPBasicAuthHandler. This PR changes only AbstractDigestAuthHandler. AbstractBasicAuthHandler already handles multiple challenges since GH-18284 and is not modified. http_error_auth_reqed() now reads all headers (get_all()) and uses the first Digest challenge found. It raises ValueError only when neither Digest nor Basic is offered; otherwise it returns None so the next handler can try. A new private _parse_challenges() splits a header into challenges per RFC 9110 §11.6.1. A comma-separated element that starts with a word not followed by = begins a new challenge. Its quote/escape handling matches parse_http_list(). It makes a single linear pass with no regex. retry_http_digest_auth() is unchanged. It receives the original text of the Digest challenge, so escapes are not processed twice. For a single-challenge header the string is the same as before. 🤖 Generated with Claude Code I have reviewed the logic and changes done by claude. This is the most compact way to address requirement in the long pending issue gh-59515 Issue: gh-59515

Open Graph Description: HTTPDigestAuthHandler and ProxyDigestAuthHandler only looked at the first WWW-Authenticate / Proxy-Authenticate header and took its first word as the scheme. As a result: A Digest challenge was i...

X Description: HTTPDigestAuthHandler and ProxyDigestAuthHandler only looked at the first WWW-Authenticate / Proxy-Authenticate header and took its first word as the scheme. As a result: A Digest challenge was i...

Opengraph URL: https://github.com/python/cpython/pull/160828

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:90fe8b15-834c-09f8-4261-4978685b5002
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE54C:8AE25:17EFAE0:1FB0AF2:6B020D8E
html-safe-nonce50a22876036cc7a557b322ad758e103a52c97463ec02c2cbfaabb5feb79aa1e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTRDOjhBRTI1OjE3RUZBRTA6MUZCMEFGMjo2QjAyMEQ4RSIsInZpc2l0b3JfaWQiOiI2NDkwNzA2NDU4MTQ0MDE3ODA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac024340ce6b27d180e3acb53c095f8cfdd8440105854b962564f011c8362cb829
hovercard-subject-tagpull_request:5052955844
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/160828/files
twitter:imagehttps://avatars.githubusercontent.com/u/332330?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/332330?s=400&v=4
og:image:altHTTPDigestAuthHandler and ProxyDigestAuthHandler only looked at the first WWW-Authenticate / Proxy-Authenticate header and took its first word as the scheme. As a result: A Digest challenge was i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/160828/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160828%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160828%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160828/files
Reloadhttps://github.com/python/cpython/pull/160828/files
Reloadhttps://github.com/python/cpython/pull/160828/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
orsenthilhttps://github.com/orsenthil
python:mainhttps://github.com/python/cpython/tree/main
orsenthil:issues/59515https://github.com/orsenthil/cpython/tree/issues/59515
Conversation 8 https://github.com/python/cpython/pull/160828
Commits 2 https://github.com/python/cpython/pull/160828/commits
Checks 75 https://github.com/python/cpython/pull/160828/checks
Files changed https://github.com/python/cpython/pull/160828/files
Please reload this pagehttps://github.com/python/cpython/pull/160828/files
gh-59515: Support multiple challenges in urllib Digest Auth https://github.com/python/cpython/pull/160828/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/160828/files
13ec2a0 gh-59515: Support multiple challenges in urllib Digest Auth orsenthil Oct 28, 2026 https://github.com/python/cpython/pull/160828/commits/13ec2a0d4265bab15ed6b7b15689ca7bf0a99d66
90fcc99 Merge branch 'main' into issues/59515 orsenthil Oct 29, 2026 https://github.com/python/cpython/pull/160828/commits/90fcc995d5fdadac4ccef099b7f5ab2faddd793a
Clear filters https://github.com/python/cpython/pull/160828/files
Please reload this pagehttps://github.com/python/cpython/pull/160828/files
Please reload this pagehttps://github.com/python/cpython/pull/160828/files
test_urllib2.py https://github.com/python/cpython/pull/160828/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
request.py https://github.com/python/cpython/pull/160828/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
2026-10-28-13-23-28.gh-issue-59515.wt31yNN4.rst https://github.com/python/cpython/pull/160828/files#diff-1c4d45461e3a4b6e4fa69c6b5388cebca7c2ac96a2f3165fca05d194b28aa97d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L644
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/160828/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
View file https://github.com/orsenthil/cpython/blob/90fcc995d5fdadac4ccef099b7f5ab2faddd793a/Lib/test/test_urllib2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160828/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160828/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
https://github.com/python/cpython/pull/160828/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L643
Lib/urllib/request.pyhttps://github.com/python/cpython/pull/160828/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
View file https://github.com/orsenthil/cpython/blob/90fcc995d5fdadac4ccef099b7f5ab2faddd793a/Lib/urllib/request.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160828/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160828/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/160828/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
https://github.com/python/cpython/pull/160828/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
Misc/NEWS.d/next/Library/2026-10-28-13-23-28.gh-issue-59515.wt31yNN4.rsthttps://github.com/python/cpython/pull/160828/files#diff-1c4d45461e3a4b6e4fa69c6b5388cebca7c2ac96a2f3165fca05d194b28aa97d
View file https://github.com/orsenthil/cpython/blob/90fcc995d5fdadac4ccef099b7f5ab2faddd793a/Misc/NEWS.d/next/Library/2026-10-28-13-23-28.gh-issue-59515.wt31yNN4.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160828/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/160828/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.