René's URL Explorer Experiment


Title: bpo-25324: copy tok_name before changing it by albertjan · Pull Request #1608 · python/cpython · GitHub

Open Graph Title: bpo-25324: copy tok_name before changing it by albertjan · Pull Request #1608 · python/cpython

X Title: bpo-25324: copy tok_name before changing it by albertjan · Pull Request #1608 · python/cpython

Description: Saw this open bug report, and since I was looking at tokenize.py anyway. I figured I address it. This may catch people off guard though because they may be relying on tok_name containing ENCODING, COMMENT and NL. 🤷‍♂️

Open Graph Description: Saw this open bug report, and since I was looking at tokenize.py anyway. I figured I address it. This may catch people off guard though because they may be relying on tok_name containing ENCODING, ...

X Description: Saw this open bug report, and since I was looking at tokenize.py anyway. I figured I address it. This may catch people off guard though because they may be relying on tok_name containing ENCODING, ...

Opengraph URL: https://github.com/python/cpython/pull/1608

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4efdc369-1962-dcdd-628c-0fab4e7bde5e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE33A:172D3F:17053F8:1EE5E4A:6A543E95
html-safe-nonce584515c0931b9d9a8bb491eb979f492877999fe449514bd098147fd798771afb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzNBOjE3MkQzRjoxNzA1M0Y4OjFFRTVFNEE6NkE1NDNFOTUiLCJ2aXNpdG9yX2lkIjoiMTM5NjA4NDg3MjMwOTkxNTI4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac40f74c17b35fe6546f9eb114ebce5f9724e05bb5902d13468b78dec04e57b16f
hovercard-subject-tagpull_request:120860853
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/1608/files
twitter:imagehttps://avatars.githubusercontent.com/u/301791?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/301791?s=400&v=4
og:image:altSaw this open bug report, and since I was looking at tokenize.py anyway. I figured I address it. This may catch people off guard though because they may be relying on tok_name containing ENCODING, ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1608/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1608%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1608%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1608/files
Reloadhttps://github.com/python/cpython/pull/1608/files
Reloadhttps://github.com/python/cpython/pull/1608/files
Please reload this pagehttps://github.com/python/cpython/pull/1608/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1608/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
albertjan:fix-issue-25324https://github.com/albertjan/cpython-1/tree/fix-issue-25324
Conversation 28 https://github.com/python/cpython/pull/1608
Commits 11 https://github.com/python/cpython/pull/1608/commits
Checks 0 https://github.com/python/cpython/pull/1608/checks
Files changed https://github.com/python/cpython/pull/1608/files
Please reload this pagehttps://github.com/python/cpython/pull/1608/files
bpo-25324: copy tok_name before changing it https://github.com/python/cpython/pull/1608/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/1608/files
44c1b9e add test to check if were modifying token albertjan May 16, 2017 https://github.com/python/cpython/pull/1608/commits/44c1b9e61548a885201e6efaf902ead94b38cfa1
85ab9d6 copy list so import tokenize doesnt have side effects on token albertjan May 16, 2017 https://github.com/python/cpython/pull/1608/commits/85ab9d61a86cb817050919c35455c45460a94972
ac27a69 shorten line albertjan May 16, 2017 https://github.com/python/cpython/pull/1608/commits/ac27a69d448dd864c6ac1a5b9ec975a5ef9fff81
607dde4 add tokenize tokens to token.h to get them to show up in token albertjan May 24, 2017 https://github.com/python/cpython/pull/1608/commits/607dde4932694b99c90a56c2df0ca09c5a2cbb5c
2c89203 move ERRORTOKEN back to its previous location, and fix nitpick albertjan May 30, 2017 https://github.com/python/cpython/pull/1608/commits/2c89203953c468f35e43ab03f1f8b2ba1e7a3e25
4593e1d copy comments from token.h automatically albertjan May 30, 2017 https://github.com/python/cpython/pull/1608/commits/4593e1d370e8886dea8db2cf013985bac1d483dc
1c26215 fix whitespace and make more pythonic albertjan May 30, 2017 https://github.com/python/cpython/pull/1608/commits/1c262152d77227342eb3e1144e94011bdadff5b2
7759818 change to fix comments from @haypo albertjan May 30, 2017 https://github.com/python/cpython/pull/1608/commits/77598189b60b234afb5d6b5d86085a2bfb84d5a5
6da5c14 update token.rst and Misc/NEWS albertjan May 31, 2017 https://github.com/python/cpython/pull/1608/commits/6da5c143efdb65e159e899f956e78671f81da064
e7113fa change wording albertjan May 31, 2017 https://github.com/python/cpython/pull/1608/commits/e7113fa2ec2368984e408c25cb6a2f2be441aa10
e483bf6 some more wording changes albertjan May 31, 2017 https://github.com/python/cpython/pull/1608/commits/e483bf6361b6f8c9af6cac770ab020e34d0f6f5f
Clear filters https://github.com/python/cpython/pull/1608/files
Please reload this pagehttps://github.com/python/cpython/pull/1608/files
Please reload this pagehttps://github.com/python/cpython/pull/1608/files
token.rst https://github.com/python/cpython/pull/1608/files#diff-025461bf9a1aa1b659556806a2e5ebd3e390d2db2fd27f921e6d180d7167b5f5
token.h https://github.com/python/cpython/pull/1608/files#diff-cec6ca68824b602026d6ca5d4fe48a3beabd534fd6bef3c016a135683b375517
test_tokenize.py https://github.com/python/cpython/pull/1608/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
token.py https://github.com/python/cpython/pull/1608/files#diff-4a711e782c0052faff4c5ffa0df266200f81ddb87687c9b7d92af70233d43dd6
tokenize.py https://github.com/python/cpython/pull/1608/files#diff-35c916ae2b7e488053d1c28da2a853790f2c0474e909c03950e49aa4203ea976
NEWS https://github.com/python/cpython/pull/1608/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
tokenizer.c https://github.com/python/cpython/pull/1608/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
Doc/library/token.rsthttps://github.com/python/cpython/pull/1608/files#diff-025461bf9a1aa1b659556806a2e5ebd3e390d2db2fd27f921e6d180d7167b5f5
View file https://github.com/albertjan/cpython-1/blob/e483bf6361b6f8c9af6cac770ab020e34d0f6f5f/Doc/library/token.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1608/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1608/files#diff-025461bf9a1aa1b659556806a2e5ebd3e390d2db2fd27f921e6d180d7167b5f5
Include/token.hhttps://github.com/python/cpython/pull/1608/files#diff-cec6ca68824b602026d6ca5d4fe48a3beabd534fd6bef3c016a135683b375517
View file https://github.com/albertjan/cpython-1/blob/e483bf6361b6f8c9af6cac770ab020e34d0f6f5f/Include/token.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1608/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1608/files#diff-cec6ca68824b602026d6ca5d4fe48a3beabd534fd6bef3c016a135683b375517
https://github.com/python/cpython/pull/1608/files#diff-cec6ca68824b602026d6ca5d4fe48a3beabd534fd6bef3c016a135683b375517
Lib/test/test_tokenize.pyhttps://github.com/python/cpython/pull/1608/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
View file https://github.com/albertjan/cpython-1/blob/e483bf6361b6f8c9af6cac770ab020e34d0f6f5f/Lib/test/test_tokenize.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1608/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1608/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
https://github.com/python/cpython/pull/1608/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
Lib/token.pyhttps://github.com/python/cpython/pull/1608/files#diff-4a711e782c0052faff4c5ffa0df266200f81ddb87687c9b7d92af70233d43dd6
View file https://github.com/albertjan/cpython-1/blob/e483bf6361b6f8c9af6cac770ab020e34d0f6f5f/Lib/token.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1608/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1608/files#diff-4a711e782c0052faff4c5ffa0df266200f81ddb87687c9b7d92af70233d43dd6
https://github.com/python/cpython/pull/1608/files#diff-4a711e782c0052faff4c5ffa0df266200f81ddb87687c9b7d92af70233d43dd6
https://github.com/python/cpython/pull/1608/files#diff-4a711e782c0052faff4c5ffa0df266200f81ddb87687c9b7d92af70233d43dd6
https://github.com/python/cpython/pull/1608/files#diff-4a711e782c0052faff4c5ffa0df266200f81ddb87687c9b7d92af70233d43dd6
https://github.com/python/cpython/pull/1608/files#diff-4a711e782c0052faff4c5ffa0df266200f81ddb87687c9b7d92af70233d43dd6
Lib/tokenize.pyhttps://github.com/python/cpython/pull/1608/files#diff-35c916ae2b7e488053d1c28da2a853790f2c0474e909c03950e49aa4203ea976
View file https://github.com/albertjan/cpython-1/blob/e483bf6361b6f8c9af6cac770ab020e34d0f6f5f/Lib/tokenize.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1608/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1608/files#diff-35c916ae2b7e488053d1c28da2a853790f2c0474e909c03950e49aa4203ea976
https://github.com/python/cpython/pull/1608/files#diff-35c916ae2b7e488053d1c28da2a853790f2c0474e909c03950e49aa4203ea976
Misc/NEWShttps://github.com/python/cpython/pull/1608/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
View file https://github.com/albertjan/cpython-1/blob/e483bf6361b6f8c9af6cac770ab020e34d0f6f5f/Misc/NEWS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1608/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1608/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
https://github.com/python/cpython/pull/1608/files#diff-f920da77b137d2e8eedf287c987745a3ff99c83d20a6332f656b35d12c479d10
Parser/tokenizer.chttps://github.com/python/cpython/pull/1608/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
View file https://github.com/albertjan/cpython-1/blob/e483bf6361b6f8c9af6cac770ab020e34d0f6f5f/Parser/tokenizer.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1608/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1608/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
https://github.com/python/cpython/pull/1608/files#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.