René's URL Explorer Experiment


Title: gh-160573: Drop the set once when a shared iterator is exhausted by scrieve · Pull Request #160619 · python/cpython · GitHub

Open Graph Title: gh-160573: Drop the set once when a shared iterator is exhausted by scrieve · Pull Request #160619 · python/cpython

X Title: gh-160573: Drop the set once when a shared iterator is exhausted by scrieve · Pull Request #160619 · python/cpython

Description: A set iterator shared between threads over-releases its set when it is exhausted. setiter_iternext() reads si->si_set with no lock held, returns early only when it is already NULL, and clears the field plus Py_DECREF(so) after Py_END_CRITICAL_SECTION(). Threads that arrive on the exhausted branch together all pass the NULL check, so each of them drops the iterator's single reference. Measured on a free-threaded debug build (--disable-gil --with-assertions, gcc 15.2), with eight threads exhausting one iterator over a 300,000-slot set: before: sys.getrefcount(s) goes 1002 to 995, seven extra decrefs, then validate_gc_objects() aborts at finalization with "refcount is too small", exit 134. with this branch: 1002 to 1002, exit 0. ThreadSanitizer reported the race on the unpatched tree and is clean with the change, on the same reproducer. The change holds the iterator's own critical section across the size check, the table walk, the clear, si_pos, si_used and len, and stores NULL with FT_ATOMIC_STORE_PTR_RELAXED, which is what the lock-free fast path reads. The iterator's reference is dropped once, after the lock has been released. On a build with the GIL the critical section compiles away, so behaviour there is unchanged. I kept the table walk inside the set's critical section as it is rather than moving to the _Py_XGetRef plus exchange shape discussed in gh-154130, because gh-124397 asks for the minimal change that stops the crash and this keeps the single release easy to see. I am happy to rework it to the other shape if that is the direction you want for the iterator family. New test in Lib/test/test_free_threading/test_set.py: TestSetIteratorExhaustion. It aborts with _Py_NegativeRefcount on unpatched main and passes here. test_set (644 tests) and test_free_threading.test_set (8 tests) are green on the free-threaded debug build. NEWS entry added. Issue: gh-160573

Open Graph Description: A set iterator shared between threads over-releases its set when it is exhausted. setiter_iternext() reads si->si_set with no lock held, returns early only when it is already NULL, and clears th...

X Description: A set iterator shared between threads over-releases its set when it is exhausted. setiter_iternext() reads si->si_set with no lock held, returns early only when it is already NULL, and clear...

Opengraph URL: https://github.com/python/cpython/pull/160619

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e2d352aa-75f1-20d5-b010-b0f00a87a7bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB968:38EE04:18D4C13:20CAC01:6B020E9C
html-safe-nonced4e2fa6f87df479cf16529ae26902e28b92c9981f59c0e7e24f06b70ac7807ff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTY4OjM4RUUwNDoxOEQ0QzEzOjIwQ0FDMDE6NkIwMjBFOUMiLCJ2aXNpdG9yX2lkIjoiMjQ4Mjk4NzAxMjk4NzE2MjI2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb95a5253300c9042ffd912f6a4efe337a4a2d564313980ba93fb203780e54b14
hovercard-subject-tagpull_request:4998449614
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/160619/files
twitter:imagehttps://avatars.githubusercontent.com/u/86650480?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86650480?s=400&v=4
og:image:altA set iterator shared between threads over-releases its set when it is exhausted. setiter_iternext() reads si->si_set with no lock held, returns early only when it is already NULL, and clears th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/160619/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160619%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160619%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160619/files
Reloadhttps://github.com/python/cpython/pull/160619/files
Reloadhttps://github.com/python/cpython/pull/160619/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
scrieve:gh-160573-setiter-releasehttps://github.com/scrieve/cpython/tree/gh-160573-setiter-release
Conversation 1 https://github.com/python/cpython/pull/160619
Commits 4 https://github.com/python/cpython/pull/160619/commits
Checks 59 https://github.com/python/cpython/pull/160619/checks
Files changed https://github.com/python/cpython/pull/160619/files
Please reload this pagehttps://github.com/python/cpython/pull/160619/files
gh-160573: Drop the set once when a shared iterator is exhausted https://github.com/python/cpython/pull/160619/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/160619/files
c93df6d gh-160573: Drop the set once when a shared iterator is exhausted scrieve Oct 24, 2026 https://github.com/python/cpython/pull/160619/commits/c93df6d34eddd3b074ba626b9d1b5accee8c723c
909027c Keep the set reference until dealloc in free-threaded set iterators kumaraditya303 Nov 20, 2026 https://github.com/python/cpython/pull/160619/commits/909027cc97ca1e41f7bb2b7e00dfce27de841360
db0a136 Tidy formatting of the set iterator changes kumaraditya303 Nov 20, 2026 https://github.com/python/cpython/pull/160619/commits/db0a1360e1905c7fe0225d81f6e4cf3dd83fbf7b
7e0852f Merge branch 'main' into gh-160573-setiter-release kumaraditya303 Nov 20, 2026 https://github.com/python/cpython/pull/160619/commits/7e0852f3a9aa95a95f57cb1c43206f332cdac102
Clear filters https://github.com/python/cpython/pull/160619/files
Please reload this pagehttps://github.com/python/cpython/pull/160619/files
Please reload this pagehttps://github.com/python/cpython/pull/160619/files
test_set.py https://github.com/python/cpython/pull/160619/files#diff-b994f343b9e103f63fa93441746390c7d4224a671119c12cab4b85fb151c4af4
2026-10-24-19-40-00.gh-issue-160573.sT9kQe.rst https://github.com/python/cpython/pull/160619/files#diff-ccc25f43d721f8dbcc17b8cd5a9b8f56e9b7bd25d0bdc67ac9ad14d883ede000
setobject.c https://github.com/python/cpython/pull/160619/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Lib/test/test_free_threading/test_set.pyhttps://github.com/python/cpython/pull/160619/files#diff-b994f343b9e103f63fa93441746390c7d4224a671119c12cab4b85fb151c4af4
View file https://github.com/scrieve/cpython/blob/7e0852f3a9aa95a95f57cb1c43206f332cdac102/Lib/test/test_free_threading/test_set.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160619/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160619/files#diff-b994f343b9e103f63fa93441746390c7d4224a671119c12cab4b85fb151c4af4
Misc/NEWS.d/next/Core_and_Builtins/2026-10-24-19-40-00.gh-issue-160573.sT9kQe.rsthttps://github.com/python/cpython/pull/160619/files#diff-ccc25f43d721f8dbcc17b8cd5a9b8f56e9b7bd25d0bdc67ac9ad14d883ede000
View file https://github.com/scrieve/cpython/blob/7e0852f3a9aa95a95f57cb1c43206f332cdac102/Misc/NEWS.d/next/Core_and_Builtins/2026-10-24-19-40-00.gh-issue-160573.sT9kQe.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160619/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L216
Objects/setobject.chttps://github.com/python/cpython/pull/160619/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
View file https://github.com/scrieve/cpython/blob/7e0852f3a9aa95a95f57cb1c43206f332cdac102/Objects/setobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160619/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160619/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/160619/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/160619/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/160619/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/160619/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/160619/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/160619/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Please reload this pagehttps://github.com/python/cpython/pull/160619/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.