René's URL Explorer Experiment


Title: gh-160506: Fix ntpath.realpath() for broken links via directory links by gpshead · Pull Request #160507 · python/cpython · GitHub

Open Graph Title: gh-160506: Fix ntpath.realpath() for broken links via directory links by gpshead · Pull Request #160507 · python/cpython

X Title: gh-160506: Fix ntpath.realpath() for broken links via directory links by gpshead · Pull Request #160507 · python/cpython

Description: ntpath._readlink_deep(), the fallback realpath() uses for a link Windows cannot open, now resolves the directory that contains the link with _getfinalpathname() before joining a relative target to it, so .. in the target goes up from the real directory. It keeps the textual join only if that directory cannot be resolved with one of the error codes the function already tolerates. Two expectations in test_realpath_broken_symlinks change (broken2 and broken3 now resolve to ABSTFN\missing), because they asserted the unresolved join. I could not run this on Windows: the changed branch and the test_ntpath tests are skipped on Linux, where I only exercised the code over stand-ins for the nt functions. It needs the Windows CI run before review. test_parent_symlink3 in test_tarfile passes on Linux with and without the change; its Windows branch is the one that depends on it. Fixes #160506 ANT-2026-27II3A20 Issue: gh-160506

Open Graph Description: ntpath._readlink_deep(), the fallback realpath() uses for a link Windows cannot open, now resolves the directory that contains the link with _getfinalpathname() before joining a relative target to ...

X Description: ntpath._readlink_deep(), the fallback realpath() uses for a link Windows cannot open, now resolves the directory that contains the link with _getfinalpathname() before joining a relative target to ...

Opengraph URL: https://github.com/python/cpython/pull/160507

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fedc2020-5545-4d48-7848-e1f8b30ba25d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD240:16AB79:3E37917:4F0B102:6B02136B
html-safe-nonce6592f936d7f53ebc7ed1adfb397a150a685306fc33c2d5f40980ed64872442a3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjQwOjE2QUI3OTozRTM3OTE3OjRGMEIxMDI6NkIwMjEzNkIiLCJ2aXNpdG9yX2lkIjoiMTM3NDQ3MzU3MTg0NTQxMTY5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6479d35287203d084d8320fe236d041cdd519f00578d99dfd3156e97de68ec1d
hovercard-subject-tagpull_request:4989381853
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/160507/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altntpath._readlink_deep(), the fallback realpath() uses for a link Windows cannot open, now resolves the directory that contains the link with _getfinalpathname() before joining a relative target to ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/160507/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160507%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160507%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160507/files
Reloadhttps://github.com/python/cpython/pull/160507/files
Reloadhttps://github.com/python/cpython/pull/160507/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:scanfix-ntpath-27ii3a20https://github.com/gpshead/cpython/tree/scanfix-ntpath-27ii3a20
Conversation 8 https://github.com/python/cpython/pull/160507
Commits 1 https://github.com/python/cpython/pull/160507/commits
Checks 77 https://github.com/python/cpython/pull/160507/checks
Files changed https://github.com/python/cpython/pull/160507/files
Please reload this pagehttps://github.com/python/cpython/pull/160507/files
gh-160506: Fix ntpath.realpath() for broken links via directory links https://github.com/python/cpython/pull/160507/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/160507/files
5dbdc22 gh-160506: Fix ntpath.realpath() for broken links via directory links gpshead Oct 22, 2026 https://github.com/python/cpython/pull/160507/commits/5dbdc22572b4207d7a86676b67b9eeda11add97b
Clear filters https://github.com/python/cpython/pull/160507/files
Please reload this pagehttps://github.com/python/cpython/pull/160507/files
Please reload this pagehttps://github.com/python/cpython/pull/160507/files
ntpath.py https://github.com/python/cpython/pull/160507/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
test_ntpath.py https://github.com/python/cpython/pull/160507/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
test_tarfile.py https://github.com/python/cpython/pull/160507/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
2026-10-22-08-08-23.gh-issue-160506.rN4dLq.rst https://github.com/python/cpython/pull/160507/files#diff-3ecc5291be2c78224f742056ee06f963d73f617153b878b6aba18507377f95d5
Lib/ntpath.pyhttps://github.com/python/cpython/pull/160507/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
View file https://github.com/gpshead/cpython/blob/5dbdc22572b4207d7a86676b67b9eeda11add97b/Lib/ntpath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160507/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160507/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/pull/160507/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
Lib/test/test_ntpath.pyhttps://github.com/python/cpython/pull/160507/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
View file https://github.com/gpshead/cpython/blob/5dbdc22572b4207d7a86676b67b9eeda11add97b/Lib/test/test_ntpath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160507/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160507/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
https://github.com/python/cpython/pull/160507/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
https://github.com/python/cpython/pull/160507/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L612
Lib/test/test_tarfile.pyhttps://github.com/python/cpython/pull/160507/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
View file https://github.com/gpshead/cpython/blob/5dbdc22572b4207d7a86676b67b9eeda11add97b/Lib/test/test_tarfile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160507/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160507/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
https://github.com/python/cpython/pull/160507/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
Misc/NEWS.d/next/Security/2026-10-22-08-08-23.gh-issue-160506.rN4dLq.rsthttps://github.com/python/cpython/pull/160507/files#diff-3ecc5291be2c78224f742056ee06f963d73f617153b878b6aba18507377f95d5
View file https://github.com/gpshead/cpython/blob/5dbdc22572b4207d7a86676b67b9eeda11add97b/Misc/NEWS.d/next/Security/2026-10-22-08-08-23.gh-issue-160506.rN4dLq.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160507/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/160507/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.