René's URL Explorer Experiment


Title: [3.14] gh-159739: Keep the instance type alive during ABC subclass checks (GH-160198) by jelle-openai · Pull Request #160488 · python/cpython · GitHub

Open Graph Title: [3.14] gh-159739: Keep the instance type alive during ABC subclass checks (GH-160198) by jelle-openai · Pull Request #160488 · python/cpython

X Title: [3.14] gh-159739: Keep the instance type alive during ABC subclass checks (GH-160198) by jelle-openai · Pull Request #160488 · python/cpython

Description: When an instance advertises a class different from its actual type, ABCMeta.instancecheck performs two subclass checks. The first callback can change the instance's actual type and allow its old type to be collected before the second check, causing a crash. Keep the original type alive through both checks. Backport to 3.15 and 3.14. (cherry picked from commit dcbc453) Co-authored-by: Jelle Zijlstra jelle@openai.com Backport of #160198 to 3.14. Carry over the subclass-callback lifetime fix and its regression test, adapting the test imports to the release branch. Ran test_abc on a free-threaded 3.14 build. Issue: gh-159739

Open Graph Description: When an instance advertises a class different from its actual type, ABCMeta.instancecheck performs two subclass checks. The first callback can change the instance's actual type and allow its ol...

X Description: When an instance advertises a class different from its actual type, ABCMeta.instancecheck performs two subclass checks. The first callback can change the instance's actual type and allow it...

Opengraph URL: https://github.com/python/cpython/pull/160488

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:844f5241-9832-8a5a-70ca-f0a83f3b13f5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABCA:14EB6E:1F6C5A5:2931348:6B022F95
html-safe-noncefe5890cbdefc14c757a46a4dc18e3012d4091a0dfa239198c4b7399451c9ca95
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkNBOjE0RUI2RToxRjZDNUE1OjI5MzEzNDg6NkIwMjJGOTUiLCJ2aXNpdG9yX2lkIjoiNTI3NjQzMjI5MDYwNjYyNDY2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7edabc8a6e28214906851ef560b1ed162b1e78d9fce7964df9a29d66d1b5e3a1
hovercard-subject-tagpull_request:4988562912
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/160488/files
twitter:imagehttps://avatars.githubusercontent.com/u/194148892?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194148892?s=400&v=4
og:image:altWhen an instance advertises a class different from its actual type, ABCMeta.instancecheck performs two subclass checks. The first callback can change the instance's actual type and allow its ol...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/160488/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160488%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160488%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160488/files
Reloadhttps://github.com/python/cpython/pull/160488/files
Reloadhttps://github.com/python/cpython/pull/160488/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:3.14https://github.com/python/cpython/tree/3.14
jelle-openai:jelle/codex/backport-160198-3.14https://github.com/jelle-openai/cpython/tree/jelle/codex/backport-160198-3.14
Conversation 0 https://github.com/python/cpython/pull/160488
Commits 1 https://github.com/python/cpython/pull/160488/commits
Checks 48 https://github.com/python/cpython/pull/160488/checks
Files changed https://github.com/python/cpython/pull/160488/files
Please reload this pagehttps://github.com/python/cpython/pull/160488/files
[3.14] gh-159739: Keep the instance type alive during ABC subclass checks (GH-160198) https://github.com/python/cpython/pull/160488/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/160488/files
94ceb03 [3.14] gh-159739: Keep the instance type alive during ABC subclass ch… jelle-openai Oct 22, 2026 https://github.com/python/cpython/pull/160488/commits/94ceb03adda76aac7fa8ecf878d07feb9e3a7efb
Clear filters https://github.com/python/cpython/pull/160488/files
Please reload this pagehttps://github.com/python/cpython/pull/160488/files
Please reload this pagehttps://github.com/python/cpython/pull/160488/files
test_abc.py https://github.com/python/cpython/pull/160488/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
2026-10-21-21-26-10.gh-issue-159739.yBc6Ei.rst https://github.com/python/cpython/pull/160488/files#diff-427122f0a3aab12649c82d6091142be3bda7f7b0211ac7a19a094efe3c7e3b43
_abc.c https://github.com/python/cpython/pull/160488/files#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687
Lib/test/test_abc.pyhttps://github.com/python/cpython/pull/160488/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
View file https://github.com/jelle-openai/cpython/blob/94ceb03adda76aac7fa8ecf878d07feb9e3a7efb/Lib/test/test_abc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160488/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160488/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
https://github.com/python/cpython/pull/160488/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
https://github.com/python/cpython/pull/160488/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
https://github.com/python/cpython/pull/160488/files#diff-e020d5ddd536ec48b0414753af7d5240750a05262f32dad378b4c79e6cc3743d
Misc/NEWS.d/next/Library/2026-10-21-21-26-10.gh-issue-159739.yBc6Ei.rsthttps://github.com/python/cpython/pull/160488/files#diff-427122f0a3aab12649c82d6091142be3bda7f7b0211ac7a19a094efe3c7e3b43
View file https://github.com/jelle-openai/cpython/blob/94ceb03adda76aac7fa8ecf878d07feb9e3a7efb/Misc/NEWS.d/next/Library/2026-10-21-21-26-10.gh-issue-159739.yBc6Ei.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160488/{{ revealButtonHref }}
Modules/_abc.chttps://github.com/python/cpython/pull/160488/files#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687
View file https://github.com/jelle-openai/cpython/blob/94ceb03adda76aac7fa8ecf878d07feb9e3a7efb/Modules/_abc.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160488/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160488/files#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687
https://github.com/python/cpython/pull/160488/files#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687
https://github.com/python/cpython/pull/160488/files#diff-d88c94f372c2e10cea3d5f2e39c6ce940eb2cfe664d913eeab7f74d23d636687
Please reload this pagehttps://github.com/python/cpython/pull/160488/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.