René's URL Explorer Experiment


Title: [3.14] gh-159739: Validate newline replacement in TextIOWrapper.write (GH-160191) by jelle-openai · Pull Request #160487 · python/cpython · GitHub

Open Graph Title: [3.14] gh-159739: Validate newline replacement in TextIOWrapper.write (GH-160191) by jelle-openai · Pull Request #160487 · python/cpython

X Title: [3.14] gh-159739: Validate newline replacement in TextIOWrapper.write (GH-160191) by jelle-openai · Pull Request #160487 · python/cpython

Description: A str subclass can override replace() and return a non-string while TextIOWrapper.write() translates newlines. The C implementation then treats the result as Unicode and can crash. Reject an invalid replacement with TypeError. Backport to 3.15 and 3.14; on 3.14, put the regression test in Lib/test/test_io.py. (cherry picked from commit c6796a1) Co-authored-by: Jelle Zijlstra jelle@openai.com Backport of #160191 to 3.14. Move the two regression tests into 3.14's Lib/test/test_io.py. Ran test_io on a free-threaded 3.14 build, including invalid replacement results and callbacks that change the stream state. Issue: gh-159739

Open Graph Description: A str subclass can override replace() and return a non-string while TextIOWrapper.write() translates newlines. The C implementation then treats the result as Unicode and can crash. Reject an invali...

X Description: A str subclass can override replace() and return a non-string while TextIOWrapper.write() translates newlines. The C implementation then treats the result as Unicode and can crash. Reject an invali...

Opengraph URL: https://github.com/python/cpython/pull/160487

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8e0b4072-b810-2318-6a7a-8d93acfafaa3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82A0:211F05:A5BEF8:D11649:6B023445
html-safe-nonce3424448fa6138132706d7a2deb73e16bba57a670cf2b00305e871effcca9b778
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkEwOjIxMUYwNTpBNUJFRjg6RDExNjQ5OjZCMDIzNDQ1IiwidmlzaXRvcl9pZCI6IjQwOTA4OTIwNDY5ODQ5NTA4NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5b075e149549b95c48621dacb036ef9bbe080d155878a4252d62a76eaac025ba
hovercard-subject-tagpull_request:4988562005
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/160487/files
twitter:imagehttps://avatars.githubusercontent.com/u/194148892?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194148892?s=400&v=4
og:image:altA str subclass can override replace() and return a non-string while TextIOWrapper.write() translates newlines. The C implementation then treats the result as Unicode and can crash. Reject an invali...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/160487/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160487%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160487%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160487/files
Reloadhttps://github.com/python/cpython/pull/160487/files
Reloadhttps://github.com/python/cpython/pull/160487/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:3.14https://github.com/python/cpython/tree/3.14
jelle-openai:jelle/codex/backport-160191-3.14https://github.com/jelle-openai/cpython/tree/jelle/codex/backport-160191-3.14
Conversation 1 https://github.com/python/cpython/pull/160487
Commits 1 https://github.com/python/cpython/pull/160487/commits
Checks 48 https://github.com/python/cpython/pull/160487/checks
Files changed https://github.com/python/cpython/pull/160487/files
Please reload this pagehttps://github.com/python/cpython/pull/160487/files
[3.14] gh-159739: Validate newline replacement in TextIOWrapper.write (GH-160191) https://github.com/python/cpython/pull/160487/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/160487/files
cdbb078 [3.14] gh-159739: Validate newline replacement in TextIOWrapper.write… jelle-openai Oct 22, 2026 https://github.com/python/cpython/pull/160487/commits/cdbb078a41df4c92194a87e99f9c37ac33131bc6
Clear filters https://github.com/python/cpython/pull/160487/files
Please reload this pagehttps://github.com/python/cpython/pull/160487/files
Please reload this pagehttps://github.com/python/cpython/pull/160487/files
test_io.py https://github.com/python/cpython/pull/160487/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
2026-10-21-21-26-10.gh-issue-159739.k8uuGe.rst https://github.com/python/cpython/pull/160487/files#diff-9f189a03f78be77d9aef3aeedac2c6873082c2de2c01af5ea98062c35ab9d0ac
textio.c https://github.com/python/cpython/pull/160487/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
Lib/test/test_io.pyhttps://github.com/python/cpython/pull/160487/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
View file https://github.com/jelle-openai/cpython/blob/cdbb078a41df4c92194a87e99f9c37ac33131bc6/Lib/test/test_io.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160487/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160487/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
https://github.com/python/cpython/pull/160487/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
Misc/NEWS.d/next/Library/2026-10-21-21-26-10.gh-issue-159739.k8uuGe.rsthttps://github.com/python/cpython/pull/160487/files#diff-9f189a03f78be77d9aef3aeedac2c6873082c2de2c01af5ea98062c35ab9d0ac
View file https://github.com/jelle-openai/cpython/blob/cdbb078a41df4c92194a87e99f9c37ac33131bc6/Misc/NEWS.d/next/Library/2026-10-21-21-26-10.gh-issue-159739.k8uuGe.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160487/{{ revealButtonHref }}
Modules/_io/textio.chttps://github.com/python/cpython/pull/160487/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
View file https://github.com/jelle-openai/cpython/blob/cdbb078a41df4c92194a87e99f9c37ac33131bc6/Modules/_io/textio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160487/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160487/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
https://github.com/python/cpython/pull/160487/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
brittnicole964-gifhttps://github.com/brittnicole964-gif
Oct 24, 2026https://github.com/python/cpython/pull/160487/files#r4368532092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/160487/files
https://github.com/python/cpython/pull/160487/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
https://github.com/python/cpython/pull/160487/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
Please reload this pagehttps://github.com/python/cpython/pull/160487/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.