René's URL Explorer Experiment


Title: gh-160427: Return None from TextIOWrapper.buffer once detached by scrieve · Pull Request #160467 · python/cpython · GitHub

Open Graph Title: gh-160427: Return None from TextIOWrapper.buffer once detached by scrieve · Pull Request #160467 · python/cpython

X Title: gh-160427: Return None from TextIOWrapper.buffer once detached by scrieve · Pull Request #160467 · python/cpython

Description: Fixes gh-160427. TextIOWrapper.buffer raises ValueError: underlying buffer has been detached once the wrapper is detached, so hasattr(stream, "buffer") raises instead of returning a boolean. This is a regression in 3.14.9 and 3.15.1, introduced by gh-157364. That change replaced the buffer member descriptor with a getter that calls buffer_access_safe(), which raises whenever self->buffer is NULL. Before gh-157364 the attribute was exposed as {"buffer", _Py_T_OBJECT, offsetof(textio, buffer), Py_READONLY}, and a NULL object member reads as None. _pyio.TextIOWrapper.buffer still returns self._buffer, which is None after detach, so the two implementations now disagree. The fix returns None from the getter when the wrapper is detached but initialised. buffer_access_safe() is untouched, so every other caller keeps the existing protection, and the uninitialised case still raises. One existing test needed updating: test_reentrant_detach_during_read asserted the ValueError from wrapper.buffer. Its subject is that the buffer survives the read and the wrapper does not crash, which still holds, so it now asserts wrapper.buffer is None. Tests: ./python -m test test_io passes, 1,066 tests. test_detach now also asserts the attribute is None and that hasattr works after detach. I used an AI assistant to help trace the regression and prepare the patch, and I have reviewed every line of it.

Open Graph Description: Fixes gh-160427. TextIOWrapper.buffer raises ValueError: underlying buffer has been detached once the wrapper is detached, so hasattr(stream, "buffer") raises instead of returning a boole...

X Description: Fixes gh-160427. TextIOWrapper.buffer raises ValueError: underlying buffer has been detached once the wrapper is detached, so hasattr(stream, "buffer") raises instead of returning...

Opengraph URL: https://github.com/python/cpython/pull/160467

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fa76ed24-07b1-e07f-1bc4-00d80b90d28c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE616:26ECEB:3E2D51D:4F01143:6B01FD4C
html-safe-nonceaf811732bf9aee0bbbc9db30c26cd62d0c1329ea79e2b7ceb8e705e246b29445
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjE2OjI2RUNFQjozRTJENTFEOjRGMDExNDM6NkIwMUZENEMiLCJ2aXNpdG9yX2lkIjoiNjE3NjU1ODA5MzI1NDY1NTMwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceb219f615f510cb84096d3066c7830fdf6429dba52f78f5825dc3a2ce4448e98
hovercard-subject-tagpull_request:4987953866
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/160467/files
twitter:imagehttps://avatars.githubusercontent.com/u/86650480?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86650480?s=400&v=4
og:image:altFixes gh-160427. TextIOWrapper.buffer raises ValueError: underlying buffer has been detached once the wrapper is detached, so hasattr(stream, "buffer") raises instead of returning a boole...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/160467/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160467%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160467%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160467/files
Reloadhttps://github.com/python/cpython/pull/160467/files
Reloadhttps://github.com/python/cpython/pull/160467/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
scrievehttps://github.com/scrieve
python:mainhttps://github.com/python/cpython/tree/main
scrieve:gh-160427-buffer-nonehttps://github.com/scrieve/cpython/tree/gh-160427-buffer-none
Conversation 6 https://github.com/python/cpython/pull/160467
Commits 1 https://github.com/python/cpython/pull/160467/commits
Checks 54 https://github.com/python/cpython/pull/160467/checks
Files changed https://github.com/python/cpython/pull/160467/files
Please reload this pagehttps://github.com/python/cpython/pull/160467/files
gh-160427: Return None from TextIOWrapper.buffer once detached https://github.com/python/cpython/pull/160467/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/160467/files
0071853 gh-160427: Return None from TextIOWrapper.buffer once detached scrieve Oct 23, 2026 https://github.com/python/cpython/pull/160467/commits/0071853b359d909b6050115016d9e0e590003f9c
Clear filters https://github.com/python/cpython/pull/160467/files
Please reload this pagehttps://github.com/python/cpython/pull/160467/files
Please reload this pagehttps://github.com/python/cpython/pull/160467/files
test_textio.py https://github.com/python/cpython/pull/160467/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
2026-10-23-19-02-11.gh-issue-160427.k3x9aq.rst https://github.com/python/cpython/pull/160467/files#diff-29df366ac7e31b7f4597c2ede799c4fd395c93ec830990ea88c911a71aa9ec31
textio.c https://github.com/python/cpython/pull/160467/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L526
Lib/test/test_io/test_textio.pyhttps://github.com/python/cpython/pull/160467/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
View file https://github.com/scrieve/cpython/blob/0071853b359d909b6050115016d9e0e590003f9c/Lib/test/test_io/test_textio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160467/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160467/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
https://github.com/python/cpython/pull/160467/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
https://github.com/python/cpython/pull/160467/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
https://github.com/python/cpython/pull/160467/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
Misc/NEWS.d/next/Library/2026-10-23-19-02-11.gh-issue-160427.k3x9aq.rsthttps://github.com/python/cpython/pull/160467/files#diff-29df366ac7e31b7f4597c2ede799c4fd395c93ec830990ea88c911a71aa9ec31
View file https://github.com/scrieve/cpython/blob/0071853b359d909b6050115016d9e0e590003f9c/Misc/NEWS.d/next/Library/2026-10-23-19-02-11.gh-issue-160427.k3x9aq.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160467/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L527
Modules/_io/textio.chttps://github.com/python/cpython/pull/160467/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
View file https://github.com/scrieve/cpython/blob/0071853b359d909b6050115016d9e0e590003f9c/Modules/_io/textio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160467/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160467/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
https://github.com/python/cpython/pull/160467/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
Please reload this pagehttps://github.com/python/cpython/pull/160467/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.