René's URL Explorer Experiment


Title: gh-160397: Don't take the warnings lock when emitting a warning by nascheme · Pull Request #160401 · python/cpython · GitHub

Open Graph Title: gh-160397: Don't take the warnings lock when emitting a warning by nascheme · Pull Request #160401 · python/cpython

X Title: gh-160397: Don't take the warnings lock when emitting a warning by nascheme · Pull Request #160401 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: C implementation of warnings held the per-interpreter warnings lock for the whole of warn_explicit(). That includes building the warning message (str() of the message, calling the category) and di...

X Description: C implementation of warnings held the per-interpreter warnings lock for the whole of warn_explicit(). That includes building the warning message (str() of the message, calling the category) and di...

Opengraph URL: https://github.com/python/cpython/pull/160401

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:05d899a3-9d9c-f36f-bdf5-54167089b494
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEC2:1AE20C:402A03F:512FE87:6B021043
html-safe-noncea45ce7702d00062d0a79960b997a455669d8a484704bc1a7d2a9c2574531821d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUMyOjFBRTIwQzo0MDJBMDNGOjUxMkZFODc6NkIwMjEwNDMiLCJ2aXNpdG9yX2lkIjoiNDM0NDEwOTM4NTg4MzE5MzQxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac58eeecd6af171a36f3e9061259186ea479dd13dcfb72811adf412bd518a9c6a2
hovercard-subject-tagpull_request:4975570678
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/160401/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d9f4c84e74e8ed0474464bdfe8e269682fffc4b52912feff68551e76b5d2f940/python/cpython/pull/160401
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d9f4c84e74e8ed0474464bdfe8e269682fffc4b52912feff68551e76b5d2f940/python/cpython/pull/160401
og:image:altC implementation of warnings held the per-interpreter warnings lock for the whole of warn_explicit(). That includes building the warning message (str() of the message, calling the category) and di...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenascheme
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/160401#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160401
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160401
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160401
Reloadhttps://github.com/python/cpython/pull/160401
Reloadhttps://github.com/python/cpython/pull/160401
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
nascheme:gh-160397-warnings-critical-sectionshttps://github.com/nascheme/cpython/tree/gh-160397-warnings-critical-sections
Conversationhttps://github.com/python/cpython/pull/160401
Commits11 (11)https://github.com/python/cpython/pull/160401/commits
Checkshttps://github.com/python/cpython/pull/160401/checks
Files changedhttps://github.com/python/cpython/pull/160401/files
gh-160397: Don't take the warnings lock when emitting a warninghttps://github.com/python/cpython/pull/160401#top
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
nascheme:gh-160397-warnings-critical-sectionshttps://github.com/nascheme/cpython/tree/gh-160397-warnings-critical-sections
https://github.com/nascheme
naschemehttps://github.com/nascheme
Oct 22, 2026https://github.com/python/cpython/pull/160401#issue-5989176589
Please reload this pagehttps://github.com/python/cpython/pull/160401
gh-158195https://github.com/python/cpython/issues/158195
Use critical sections in _warnings.c rather than mutex #160397https://github.com/python/cpython/issues/160397
Please reload this pagehttps://github.com/python/cpython/pull/160401
https://github.com/nascheme
pythongh-160397https://github.com/python/cpython/issues/160397
: Don't take the warnings lock when emitting a warninghttps://github.com/python/cpython/pull/160401/commits/9d3dc193f0bd6c974a90e241670be55bcb90acae
9d3dc19https://github.com/python/cpython/pull/160401/commits/9d3dc193f0bd6c974a90e241670be55bcb90acae
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Oct 22, 2026https://github.com/python/cpython/pull/160401#event-34003522037
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 22, 2026 https://github.com/python/cpython/pull/160401#ref-issue-5989036532
Use critical sections in _warnings.c rather than mutex #160397 https://github.com/python/cpython/issues/160397
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
October 22, 2026 23:36https://github.com/python/cpython/pull/160401#event-34003582127
naschemehttps://github.com/nascheme
October 22, 2026 17:28https://github.com/python/cpython/pull/160401#commits-pushed-5d0326b
https://github.com/nascheme
pythongh-160397https://github.com/python/cpython/issues/160397
: Don't leak warnings filters from ThreadTests.setUp()https://github.com/python/cpython/pull/160401/commits/5d0326b418a961f8d9caeaabfe1dbb5043ddb9bb
5d0326bhttps://github.com/python/cpython/pull/160401/commits/5d0326b418a961f8d9caeaabfe1dbb5043ddb9bb
https://github.com/nascheme
Merge remote-tracking branch 'origin/main' intohttps://github.com/python/cpython/pull/160401/commits/e562f7213d6acbecd861e4f669e3bc464434a5bd
pythongh-160397https://github.com/python/cpython/issues/160397
-warni…https://github.com/python/cpython/pull/160401/commits/e562f7213d6acbecd861e4f669e3bc464434a5bd
e562f72https://github.com/python/cpython/pull/160401/commits/e562f7213d6acbecd861e4f669e3bc464434a5bd
https://github.com/nascheme
Rewrite some code comments.https://github.com/python/cpython/pull/160401/commits/34ace5c00ba80d7e3271e53a9765ca1255260817
34ace5chttps://github.com/python/cpython/pull/160401/commits/34ace5c00ba80d7e3271e53a9765ca1255260817
https://github.com/nascheme
Merge remote-tracking branch 'origin/main' intohttps://github.com/python/cpython/pull/160401/commits/d31ab6ab4b9c41bfd4beaefac39280e406f6ae2c
pythongh-160397https://github.com/python/cpython/issues/160397
-warni…https://github.com/python/cpython/pull/160401/commits/d31ab6ab4b9c41bfd4beaefac39280e406f6ae2c
d31ab6ahttps://github.com/python/cpython/pull/160401/commits/d31ab6ab4b9c41bfd4beaefac39280e406f6ae2c
https://github.com/nascheme
naschemehttps://github.com/nascheme
November 3, 2026 17:23https://github.com/python/cpython/pull/160401#event-35046460791
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 3, 2026https://github.com/python/cpython/pull/160401#event-35046467606
https://github.com/nascheme
naschemehttps://github.com/nascheme
kumaraditya303https://github.com/kumaraditya303
November 4, 2026 17:40https://github.com/python/cpython/pull/160401#event-35156845564
https://github.com/nascheme
naschemehttps://github.com/nascheme
Nov 4, 2026 https://github.com/python/cpython/pull/160401#ref-pullrequest-5873752742
gh-159485: Fix warnings lock deadlock during interpreter shutdown #159488 https://github.com/python/cpython/pull/159488
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Nov 9, 2026 https://github.com/python/cpython/pull/160401#pullrequestreview-5823998604
View reviewed changes https://github.com/python/cpython/pull/160401/files/d31ab6ab4b9c41bfd4beaefac39280e406f6ae2c
Python/_warnings.chttps://github.com/python/cpython/pull/160401/files/d31ab6ab4b9c41bfd4beaefac39280e406f6ae2c#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
Please reload this pagehttps://github.com/python/cpython/pull/160401
naschemehttps://github.com/nascheme
November 9, 2026 12:04https://github.com/python/cpython/pull/160401#commits-pushed-2d78e63
https://github.com/nascheme
Use _Py_XGetRef() for warnings state.https://github.com/python/cpython/pull/160401/commits/2d78e639c15f828fff13c6173126f1bb4a8decbd
2d78e63https://github.com/python/cpython/pull/160401/commits/2d78e639c15f828fff13c6173126f1bb4a8decbd
https://github.com/nascheme
Merge remote-tracking branch 'origin/main' intohttps://github.com/python/cpython/pull/160401/commits/f82442aace8ed462196af12bb2381626568eb571
pythongh-160397https://github.com/python/cpython/issues/160397
-warni…https://github.com/python/cpython/pull/160401/commits/f82442aace8ed462196af12bb2381626568eb571
f82442ahttps://github.com/python/cpython/pull/160401/commits/f82442aace8ed462196af12bb2381626568eb571
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Nov 10, 2026https://github.com/python/cpython/pull/160401#issuecomment-6762623975
Please reload this pagehttps://github.com/python/cpython/pull/160401
naschemehttps://github.com/nascheme
November 10, 2026 13:19https://github.com/python/cpython/pull/160401#commits-pushed-9a5b491
https://github.com/nascheme
Read warnings filter version under the registry lockhttps://github.com/python/cpython/pull/160401/commits/9a5b4912f329a1bb7a70f514ad9b5e138b839d41
9a5b491https://github.com/python/cpython/pull/160401/commits/9a5b4912f329a1bb7a70f514ad9b5e138b839d41
https://github.com/nascheme
Merge remote-tracking branch 'origin/main' intohttps://github.com/python/cpython/pull/160401/commits/4fca4bf35d806993d43c33bbdff163a7a3be6745
pythongh-160397https://github.com/python/cpython/issues/160397
-warni…https://github.com/python/cpython/pull/160401/commits/4fca4bf35d806993d43c33bbdff163a7a3be6745
4fca4bfhttps://github.com/python/cpython/pull/160401/commits/4fca4bf35d806993d43c33bbdff163a7a3be6745
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Nov 11, 2026https://github.com/python/cpython/pull/160401#issuecomment-6795145459
Please reload this pagehttps://github.com/python/cpython/pull/160401
Please reload this pagehttps://github.com/python/cpython/pull/160401
naschemehttps://github.com/nascheme
November 11, 2026 11:48https://github.com/python/cpython/pull/160401#commits-pushed-eff9ca5
https://github.com/nascheme
Address review: drop unneeded changes in _warnings.chttps://github.com/python/cpython/pull/160401/commits/eff9ca53a5f93ef77a14611c2c2f62b1c846bc2d
eff9ca5https://github.com/python/cpython/pull/160401/commits/eff9ca53a5f93ef77a14611c2c2f62b1c846bc2d
https://github.com/nascheme
Merge remote-tracking branch 'origin/main' intohttps://github.com/python/cpython/pull/160401/commits/b01e1f656d8d286ee303e9dc7c5094c9a52c0844
pythongh-160397https://github.com/python/cpython/issues/160397
-warni…https://github.com/python/cpython/pull/160401/commits/b01e1f656d8d286ee303e9dc7c5094c9a52c0844
b01e1f6https://github.com/python/cpython/pull/160401/commits/b01e1f656d8d286ee303e9dc7c5094c9a52c0844
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Nov 12, 2026 https://github.com/python/cpython/pull/160401#pullrequestreview-5873312644
View reviewed changes https://github.com/python/cpython/pull/160401/files/b01e1f656d8d286ee303e9dc7c5094c9a52c0844
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 12, 2026https://github.com/python/cpython/pull/160401#event-35903770406
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
f871449https://github.com/python/cpython/commit/f8714494a9d54910b5142e0b3fe6eb5875e8c09d
Nov 12, 2026https://github.com/python/cpython/pull/160401#event-35903830450
Please reload this pagehttps://github.com/python/cpython/pull/160401
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 12, 2026https://github.com/python/cpython/pull/160401#event-35903836662
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Nov 15, 2026 https://github.com/python/cpython/pull/160401#ref-issue-6296878675
Free-threading race betwen two Py_SETREF #161714 https://github.com/python/cpython/issues/161714
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160401
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/160401/files/b01e1f656d8d286ee303e9dc7c5094c9a52c0844
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/160401
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Please reload this pagehttps://github.com/python/cpython/pull/160401
https://github.com/nascheme
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.