René's URL Explorer Experiment


Title: gh-154130: Fix double decref of the dict in shared dict iterators by mpage · Pull Request #160312 · python/cpython · GitHub

Open Graph Title: gh-154130: Fix double decref of the dict in shared dict iterators by mpage · Pull Request #160312 · python/cpython

X Title: gh-154130: Fix double decref of the dict in shared dict iterators by mpage · Pull Request #160312 · python/cpython

Description: In the free-threaded build, threads advancing the same dict iterator each read di_dict as a borrowed reference, so concurrently exhausting it could run di->di_dict = NULL; Py_DECREF(d) more than once and free the dict while other threads were still using it. Reversed iterators were also affected: they dropped the reference while holding the dict's critical section. In the free-threaded build, keep the iterator's reference to the dict until the iterator is deallocated (as list and tuple iterators do) and mark exhaustion by setting di_pos to -1. Issue: gh-154130

Open Graph Description: In the free-threaded build, threads advancing the same dict iterator each read di_dict as a borrowed reference, so concurrently exhausting it could run di->di_dict = NULL; Py_DECREF(d) more than...

X Description: In the free-threaded build, threads advancing the same dict iterator each read di_dict as a borrowed reference, so concurrently exhausting it could run di->di_dict = NULL; Py_DECREF(d) more ...

Opengraph URL: https://github.com/python/cpython/pull/160312

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c0f34db7-eb08-6cdd-decb-9eee810651a2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA5A:399E4B:3AA3FB2:4DC340A:6B021627
html-safe-nonceb1d2516f57b9e77c3f825c097582cb63668b4ccc49f979a0580f157612e3379c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTVBOjM5OUU0QjozQUEzRkIyOjREQzM0MEE6NkIwMjE2MjciLCJ2aXNpdG9yX2lkIjoiMzUwOTA0NjU4MjUxMzM3NDc1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac56764e425582127dbd7b86f9edd51b2823da8c093ac19985bc6bb2afeac72570
hovercard-subject-tagpull_request:4972587876
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/160312/files
twitter:imagehttps://avatars.githubusercontent.com/u/577841?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/577841?s=400&v=4
og:image:altIn the free-threaded build, threads advancing the same dict iterator each read di_dict as a borrowed reference, so concurrently exhausting it could run di->di_dict = NULL; Py_DECREF(d) more than...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/160312/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160312%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F160312%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/160312/files
Reloadhttps://github.com/python/cpython/pull/160312/files
Reloadhttps://github.com/python/cpython/pull/160312/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
mpage:gh-154130-dictiter-double-freehttps://github.com/mpage/cpython/tree/gh-154130-dictiter-double-free
Conversation 4 https://github.com/python/cpython/pull/160312
Commits 3 https://github.com/python/cpython/pull/160312/commits
Checks 52 https://github.com/python/cpython/pull/160312/checks
Files changed https://github.com/python/cpython/pull/160312/files
Please reload this pagehttps://github.com/python/cpython/pull/160312/files
gh-154130: Fix double decref of the dict in shared dict iterators https://github.com/python/cpython/pull/160312/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/160312/files
364cc82 gh-154130: Fix double decref of the dict in shared dict iterators mpage Oct 22, 2026 https://github.com/python/cpython/pull/160312/commits/364cc82ab2d924eeda3f5c49b69318702f73f40c
5c50132 Merge remote-tracking branch 'upstream/main' into gh-154130-dictiter-… kumaraditya303 Nov 20, 2026 https://github.com/python/cpython/pull/160312/commits/5c501324f3f9ae788b8400685bc4087de0dda059
9c7cbef Update di_dict comment for the free-threaded build kumaraditya303 Nov 20, 2026 https://github.com/python/cpython/pull/160312/commits/9c7cbefb41439b9f6c6cf158ce5b6117b1e44532
Clear filters https://github.com/python/cpython/pull/160312/files
Please reload this pagehttps://github.com/python/cpython/pull/160312/files
Please reload this pagehttps://github.com/python/cpython/pull/160312/files
test_dict.py https://github.com/python/cpython/pull/160312/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
dictobject.c https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Lib/test/test_free_threading/test_dict.pyhttps://github.com/python/cpython/pull/160312/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
View file https://github.com/mpage/cpython/blob/9c7cbefb41439b9f6c6cf158ce5b6117b1e44532/Lib/test/test_free_threading/test_dict.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160312/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160312/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
https://github.com/python/cpython/pull/160312/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L212
Objects/dictobject.chttps://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
View file https://github.com/mpage/cpython/blob/9c7cbefb41439b9f6c6cf158ce5b6117b1e44532/Objects/dictobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/160312/{{ revealButtonHref }}
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/160312/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/160312/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.