René's URL Explorer Experiment


Title: GH-159101: Fix UAF when tp_finalize changes the base class by sergey-miryanov · Pull Request #159888 · python/cpython · GitHub

Open Graph Title: GH-159101: Fix UAF when tp_finalize changes the base class by sergey-miryanov · Pull Request #159888 · python/cpython

X Title: GH-159101: Fix UAF when tp_finalize changes the base class by sergey-miryanov · Pull Request #159888 · python/cpython

Description: There are two issues to address. First, we fix the UAF in PyObject_CallFinalizer. We set the FINALIZED flag before calling tp_finalize, so we don't need to call _PyType_IS_GC again. Both gc.c and gc_free_threading.c do the same. Second, after calling PyObject_CallFinalizerFromDealloc, we extract the type of self again to get the updated type, and the rest works correctly. We do the same for tp_del later in the code. Issue: gh-159101

Open Graph Description: There are two issues to address. First, we fix the UAF in PyObject_CallFinalizer. We set the FINALIZED flag before calling tp_finalize, so we don't need to call _PyType_IS_GC again. Both gc.c a...

X Description: There are two issues to address. First, we fix the UAF in PyObject_CallFinalizer. We set the FINALIZED flag before calling tp_finalize, so we don't need to call _PyType_IS_GC again. Both gc...

Opengraph URL: https://github.com/python/cpython/pull/159888

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7f5c3376-c715-91d9-f571-27b838e80fe2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7B2:16AB79:3CE4959:4D5FA00:6B020C3C
html-safe-noncebe8a27377d4ae2b62288469bcc3cffebc887998d98a495185105d5768b7338ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0IyOjE2QUI3OTozQ0U0OTU5OjRENUZBMDA6NkIwMjBDM0MiLCJ2aXNpdG9yX2lkIjoiMzA5NDIyNjk0MTU3NDc3NzkxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace06968efc72d596052f6713299021ee6214398241463d4acf05f8d632e8cb055
hovercard-subject-tagpull_request:4938062855
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159888/files
twitter:imagehttps://avatars.githubusercontent.com/u/67315?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/67315?s=400&v=4
og:image:altThere are two issues to address. First, we fix the UAF in PyObject_CallFinalizer. We set the FINALIZED flag before calling tp_finalize, so we don't need to call _PyType_IS_GC again. Both gc.c a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159888/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159888%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159888%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159888/files
Reloadhttps://github.com/python/cpython/pull/159888/files
Reloadhttps://github.com/python/cpython/pull/159888/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
sergey-miryanovhttps://github.com/sergey-miryanov
python:mainhttps://github.com/python/cpython/tree/main
sergey-miryanov:bug/159101-uaf-after-finalizehttps://github.com/sergey-miryanov/cpython/tree/bug/159101-uaf-after-finalize
Conversation 7 https://github.com/python/cpython/pull/159888
Commits 7 https://github.com/python/cpython/pull/159888/commits
Checks 58 https://github.com/python/cpython/pull/159888/checks
Files changed https://github.com/python/cpython/pull/159888/files
Please reload this pagehttps://github.com/python/cpython/pull/159888/files
GH-159101: Fix UAF when tp_finalize changes the base class https://github.com/python/cpython/pull/159888/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/159888/files
4041aae Set GC_FINALIZED before calling tp_finalize sergey-miryanov Oct 18, 2026 https://github.com/python/cpython/pull/159888/commits/4041aae3b8eeb73c259b6a429e0c7573193865fa
e0e5535 Re-extract the type of self after calling tp_finalize sergey-miryanov Oct 20, 2026 https://github.com/python/cpython/pull/159888/commits/e0e5535cf3795384f4910b9ecd0a51f25c046e93
7a24d33 Add news sergey-miryanov Oct 20, 2026 https://github.com/python/cpython/pull/159888/commits/7a24d33fa3175af09662cb487df317c3df98d86f
5dfc9ea Update Misc/NEWS.d/next/Core_and_Builtins/2026-10-20-20-38-38.gh-issu… sergey-miryanov Oct 20, 2026 https://github.com/python/cpython/pull/159888/commits/5dfc9ea0fe33e047f534985e501f7d9c253b8c08
cafc48a Merge branch 'main' into bug/159101-uaf-after-finalize sergey-miryanov Oct 26, 2026 https://github.com/python/cpython/pull/159888/commits/cafc48a8f33d85b2fbbf5079b35ec1d75c73040b
76f1eda Merge branch 'main' into bug/159101-uaf-after-finalize sergey-miryanov Nov 5, 2026 https://github.com/python/cpython/pull/159888/commits/76f1edaeda55ab0c45d4de85a1803c555a47aadd
6394404 Merge branch 'main' into bug/159101-uaf-after-finalize sergey-miryanov Nov 7, 2026 https://github.com/python/cpython/pull/159888/commits/63944045534475b5414bf50d703620b62a51e542
Clear filters https://github.com/python/cpython/pull/159888/files
Please reload this pagehttps://github.com/python/cpython/pull/159888/files
Please reload this pagehttps://github.com/python/cpython/pull/159888/files
2026-10-20-20-38-38.gh-issue-159101.vFwrZY.rst https://github.com/python/cpython/pull/159888/files#diff-b1193b779f61a2598b128594aaca568306b01a9609c59cfdce83f0aa2d0d2efc
object.c https://github.com/python/cpython/pull/159888/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
typeobject.c https://github.com/python/cpython/pull/159888/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Misc/NEWS.d/next/Core_and_Builtins/2026-10-20-20-38-38.gh-issue-159101.vFwrZY.rsthttps://github.com/python/cpython/pull/159888/files#diff-b1193b779f61a2598b128594aaca568306b01a9609c59cfdce83f0aa2d0d2efc
View file https://github.com/sergey-miryanov/cpython/blob/63944045534475b5414bf50d703620b62a51e542/Misc/NEWS.d/next/Core_and_Builtins/2026-10-20-20-38-38.gh-issue-159101.vFwrZY.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159888/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L215
Objects/object.chttps://github.com/python/cpython/pull/159888/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
View file https://github.com/sergey-miryanov/cpython/blob/63944045534475b5414bf50d703620b62a51e542/Objects/object.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159888/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159888/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
https://github.com/python/cpython/pull/159888/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L217
Objects/typeobject.chttps://github.com/python/cpython/pull/159888/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
View file https://github.com/sergey-miryanov/cpython/blob/63944045534475b5414bf50d703620b62a51e542/Objects/typeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159888/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159888/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/159888/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/159888/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.