René's URL Explorer Experiment


Title: GH-159101: Fix UAF when tp_finalize changes the base class by sergey-miryanov · Pull Request #159888 · python/cpython · GitHub

Open Graph Title: GH-159101: Fix UAF when tp_finalize changes the base class by sergey-miryanov · Pull Request #159888 · python/cpython

X Title: GH-159101: Fix UAF when tp_finalize changes the base class by sergey-miryanov · Pull Request #159888 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: There are two issues to address. First, we fix the UAF in PyObject_CallFinalizer. We set the FINALIZED flag before calling tp_finalize, so we don't need to call _PyType_IS_GC again. Both gc.c a...

X Description: There are two issues to address. First, we fix the UAF in PyObject_CallFinalizer. We set the FINALIZED flag before calling tp_finalize, so we don't need to call _PyType_IS_GC again. Both gc...

Opengraph URL: https://github.com/python/cpython/pull/159888

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8b34e309-281c-7ae6-af43-19d225bba036
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA312:148EE1:3D18D2:4D4981:6B01FCF8
html-safe-nonce7302dee01b44fe9561f2fa1de2cb640253dd1252c3e4d66092ad444fa27c3703
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzEyOjE0OEVFMTozRDE4RDI6NEQ0OTgxOjZCMDFGQ0Y4IiwidmlzaXRvcl9pZCI6IjkwODkwMTgxNDMwMDY5MTU4MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac121df8310172c2ee67a6e6f3af2ebcf1f9150bb82620e9bc1f89744c5fd38147
hovercard-subject-tagpull_request:4938062855
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/159888/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1b42ebfa6b758ab092b214c02ca26af509b539a4c318dbc27d9dfb4326b6d01/python/cpython/pull/159888
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1b42ebfa6b758ab092b214c02ca26af509b539a4c318dbc27d9dfb4326b6d01/python/cpython/pull/159888
og:image:altThere are two issues to address. First, we fix the UAF in PyObject_CallFinalizer. We set the FINALIZED flag before calling tp_finalize, so we don't need to call _PyType_IS_GC again. Both gc.c a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesergey-miryanov
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/159888#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159888
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159888
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159888
Reloadhttps://github.com/python/cpython/pull/159888
Reloadhttps://github.com/python/cpython/pull/159888
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
sergey-miryanovhttps://github.com/sergey-miryanov
python:mainhttps://github.com/python/cpython/tree/main
sergey-miryanov:bug/159101-uaf-after-finalizehttps://github.com/sergey-miryanov/cpython/tree/bug/159101-uaf-after-finalize
Conversationhttps://github.com/python/cpython/pull/159888
Commits7 (7)https://github.com/python/cpython/pull/159888/commits
Checkshttps://github.com/python/cpython/pull/159888/checks
Files changedhttps://github.com/python/cpython/pull/159888/files
GH-159101: Fix UAF when tp_finalize changes the base classhttps://github.com/python/cpython/pull/159888#top
sergey-miryanovhttps://github.com/sergey-miryanov
python:mainhttps://github.com/python/cpython/tree/main
sergey-miryanov:bug/159101-uaf-after-finalizehttps://github.com/sergey-miryanov/cpython/tree/bug/159101-uaf-after-finalize
https://github.com/sergey-miryanov
sergey-miryanovhttps://github.com/sergey-miryanov
Oct 20, 2026https://github.com/python/cpython/pull/159888#issue-5944425690
Please reload this pagehttps://github.com/python/cpython/pull/159888
Use-after-free in PyObject_CallFinalizer when __del__ changes __class__ #159101https://github.com/python/cpython/issues/159101
Please reload this pagehttps://github.com/python/cpython/pull/159888
sergey-miryanovhttps://github.com/sergey-miryanov
October 18, 2026 23:40https://github.com/python/cpython/pull/159888#commits-pushed-4041aae
https://github.com/sergey-miryanov
Set GC_FINALIZED before calling tp_finalizehttps://github.com/python/cpython/pull/159888/commits/4041aae3b8eeb73c259b6a429e0c7573193865fa
4041aaehttps://github.com/python/cpython/pull/159888/commits/4041aae3b8eeb73c259b6a429e0c7573193865fa
https://github.com/sergey-miryanov
Re-extract the type of self after calling tp_finalizehttps://github.com/python/cpython/pull/159888/commits/e0e5535cf3795384f4910b9ecd0a51f25c046e93
e0e5535https://github.com/python/cpython/pull/159888/commits/e0e5535cf3795384f4910b9ecd0a51f25c046e93
https://github.com/sergey-miryanov
sergey-miryanovhttps://github.com/sergey-miryanov
ZeroIntensityhttps://github.com/ZeroIntensity
markshannonhttps://github.com/markshannon
code ownershttps://github.com/python/cpython/blob/4b33a9db8084bb4a5c631db5cb97e4a2e0e33a98/.github/CODEOWNERS#L211
October 20, 2026 15:24https://github.com/python/cpython/pull/159888#event-33756494274
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 20, 2026 https://github.com/python/cpython/pull/159888#ref-issue-5789085062
Use-after-free in PyObject_CallFinalizer when __del__ changes __class__ #159101 https://github.com/python/cpython/issues/159101
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 20, 2026https://github.com/python/cpython/pull/159888#event-33756508114
https://github.com/sergey-miryanov
Add newshttps://github.com/python/cpython/pull/159888/commits/7a24d33fa3175af09662cb487df317c3df98d86f
7a24d33https://github.com/python/cpython/pull/159888/commits/7a24d33fa3175af09662cb487df317c3df98d86f
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 20, 2026 https://github.com/python/cpython/pull/159888#pullrequestreview-5588028082
View reviewed changes https://github.com/python/cpython/pull/159888/files/7a24d33fa3175af09662cb487df317c3df98d86f
Misc/NEWS.d/next/Core_and_Builtins/2026-10-20-20-38-38.gh-issue-159101.vFwrZY.rsthttps://github.com/python/cpython/pull/159888/files/7a24d33fa3175af09662cb487df317c3df98d86f#diff-b1193b779f61a2598b128594aaca568306b01a9609c59cfdce83f0aa2d0d2efc
Please reload this pagehttps://github.com/python/cpython/pull/159888
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 20, 2026https://github.com/python/cpython/pull/159888#event-33761153457
https://github.com/sergey-miryanov
https://github.com/ZeroIntensity
Update Misc/NEWS.d/next/Core_and_Builtins/2026-10-20-20-38-38.gh-issu…https://github.com/python/cpython/pull/159888/commits/5dfc9ea0fe33e047f534985e501f7d9c253b8c08
5dfc9eahttps://github.com/python/cpython/pull/159888/commits/5dfc9ea0fe33e047f534985e501f7d9c253b8c08
https://github.com/sergey-miryanov
sergey-miryanovhttps://github.com/sergey-miryanov
Oct 20, 2026https://github.com/python/cpython/pull/159888#issuecomment-6295575545
@naschemehttps://github.com/nascheme
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/159888
https://github.com/sergey-miryanov
Merge branch 'main' into bug/159101-uaf-after-finalizehttps://github.com/python/cpython/pull/159888/commits/cafc48a8f33d85b2fbbf5079b35ec1d75c73040b
cafc48ahttps://github.com/python/cpython/pull/159888/commits/cafc48a8f33d85b2fbbf5079b35ec1d75c73040b
https://github.com/nascheme
naschemehttps://github.com/nascheme
Nov 4, 2026 https://github.com/python/cpython/pull/159888#pullrequestreview-5774541880
View reviewed changes https://github.com/python/cpython/pull/159888/files/63944045534475b5414bf50d703620b62a51e542
naschemehttps://github.com/nascheme
https://github.com/python/cpython/pull/159888#pullrequestreview-5774541880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/159888
https://github.com/sergey-miryanov
Merge branch 'main' into bug/159101-uaf-after-finalizehttps://github.com/python/cpython/pull/159888/commits/76f1edaeda55ab0c45d4de85a1803c555a47aadd
76f1edahttps://github.com/python/cpython/pull/159888/commits/76f1edaeda55ab0c45d4de85a1803c555a47aadd
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Nov 5, 2026 https://github.com/python/cpython/pull/159888#pullrequestreview-5788068688
View reviewed changes https://github.com/python/cpython/pull/159888/files/63944045534475b5414bf50d703620b62a51e542
https://github.com/sergey-miryanov
sergey-miryanovhttps://github.com/sergey-miryanov
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 7, 2026https://github.com/python/cpython/pull/159888#event-35416323927
https://github.com/sergey-miryanov
Merge branch 'main' into bug/159101-uaf-after-finalizehttps://github.com/python/cpython/pull/159888/commits/63944045534475b5414bf50d703620b62a51e542
6394404https://github.com/python/cpython/pull/159888/commits/63944045534475b5414bf50d703620b62a51e542
https://github.com/sergey-miryanov
sergey-miryanovhttps://github.com/sergey-miryanov
November 7, 2026 05:45https://github.com/python/cpython/pull/159888#event-35416403088
https://github.com/sergey-miryanov
sergey-miryanovhttps://github.com/sergey-miryanov
6c5596chttps://github.com/python/cpython/commit/6c5596c7199792ea1e8cf26f65da8cd0023c0473
Nov 7, 2026https://github.com/python/cpython/pull/159888#event-35417806515
Please reload this pagehttps://github.com/python/cpython/pull/159888
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 7, 2026https://github.com/python/cpython/pull/159888#event-35417809099
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Nov 7, 2026https://github.com/python/cpython/pull/159888#issuecomment-6703329878
@sergey-miryanovhttps://github.com/sergey-miryanov
Please reload this pagehttps://github.com/python/cpython/pull/159888
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 7, 2026https://github.com/python/cpython/pull/159888#issuecomment-6703332421
GH-161534https://github.com/python/cpython/pull/161534
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/159888
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Nov 7, 2026https://github.com/python/cpython/pull/159888#event-35417819396
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 7, 2026https://github.com/python/cpython/pull/159888#issuecomment-6703333262
GH-161535https://github.com/python/cpython/pull/161535
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/159888
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Nov 7, 2026https://github.com/python/cpython/pull/159888#event-35417822672
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159888
https://github.com/nascheme
nascheme https://github.com/nascheme
https://github.com/python/cpython/pull/159888/files/63944045534475b5414bf50d703620b62a51e542
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/python/cpython/pull/159888/files/63944045534475b5414bf50d703620b62a51e542
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/159888/files/7a24d33fa3175af09662cb487df317c3df98d86f
https://github.com/markshannon
markshannon https://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/159888
Please reload this pagehttps://github.com/python/cpython/pull/159888
https://github.com/sergey-miryanov
https://github.com/nascheme
https://github.com/pablogsal
https://github.com/ZeroIntensity
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.