René's URL Explorer Experiment


Title: gh-159864: Fix syslog.openlog() crash with concurrent sys.argv changes by espressolee · Pull Request #159884 · python/cpython · GitHub

Open Graph Title: gh-159864: Fix syslog.openlog() crash with concurrent sys.argv changes by espressolee · Pull Request #159884 · python/cpython

X Title: gh-159864: Fix syslog.openlog() crash with concurrent sys.argv changes by espressolee · Pull Request #159884 · python/cpython

Description: syslog_get_argv() took sys.argv[0] with PyList_GetItem() and only increfed it afterwards, so on the free-threaded build another thread replacing sys.argv[0] could free it in between. Use PyList_GetItemRef() instead. Adds a regression test to test_free_threading.test_syslog that races syslog.openlog() (without ident) against sys.argv[0] assignment. Thanks to @lazerg for confirming the crash on main and identifying the fix. Fixes #159864. Issue: gh-159864

Open Graph Description: syslog_get_argv() took sys.argv[0] with PyList_GetItem() and only increfed it afterwards, so on the free-threaded build another thread replacing sys.argv[0] could free it in between. Use PyList_Get...

X Description: syslog_get_argv() took sys.argv[0] with PyList_GetItem() and only increfed it afterwards, so on the free-threaded build another thread replacing sys.argv[0] could free it in between. Use PyList_Get...

Opengraph URL: https://github.com/python/cpython/pull/159884

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6f687bd3-f99e-b6e7-f192-e9762f9fd091
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF3C:23B7F8:5C78E2:8090E3:6AF85B2D
html-safe-nonce0351a3b8bf6547ec1fb3dc82044eda4552d330058d9a05e178c72221d7dced79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjNDOjIzQjdGODo1Qzc4RTI6ODA5MEUzOjZBRjg1QjJEIiwidmlzaXRvcl9pZCI6IjE0Mjg2MjMzNzI3NTY0NzQ2NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccb495b9c8ceb7ea4e50a3f588ad5a6a5bf77b7c7948f1b12720e785c6aadd9e0
hovercard-subject-tagpull_request:4936630933
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159884/files
twitter:imagehttps://avatars.githubusercontent.com/u/70549809?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/70549809?s=400&v=4
og:image:altsyslog_get_argv() took sys.argv[0] with PyList_GetItem() and only increfed it afterwards, so on the free-threaded build another thread replacing sys.argv[0] could free it in between. Use PyList_Get...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5713ecd83001b2f55c3509fb7a292bf7d66d0f167c7ae87a9f7eaec5a52bf8db
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release653be32ff5c755082a4db662491bfbbcfc9112c1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159884/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159884%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159884%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159884/files
Reloadhttps://github.com/python/cpython/pull/159884/files
Reloadhttps://github.com/python/cpython/pull/159884/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ZeroIntensityhttps://github.com/ZeroIntensity
python:mainhttps://github.com/python/cpython/tree/main
espressolee:gh-159864-syslog-argvhttps://github.com/espressolee/cpython/tree/gh-159864-syslog-argv
Conversation 7 https://github.com/python/cpython/pull/159884
Commits 1 https://github.com/python/cpython/pull/159884/commits
Checks 72 https://github.com/python/cpython/pull/159884/checks
Files changed https://github.com/python/cpython/pull/159884/files
Please reload this pagehttps://github.com/python/cpython/pull/159884/files
gh-159864: Fix syslog.openlog() crash with concurrent sys.argv changes https://github.com/python/cpython/pull/159884/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/159884/files
38a30c5 gh-159864: Fix syslog.openlog() crash with concurrent sys.argv changes espressolee Oct 20, 2026 https://github.com/python/cpython/pull/159884/commits/38a30c5a5d93a5cf8e9771d4a4e7eec6406482fa
Clear filters https://github.com/python/cpython/pull/159884/files
Please reload this pagehttps://github.com/python/cpython/pull/159884/files
Please reload this pagehttps://github.com/python/cpython/pull/159884/files
test_syslog.py https://github.com/python/cpython/pull/159884/files#diff-a71f68a9fccec021d32c130bc7292b02c2c118ba18e202bf1d189d59470cda84
2026-10-20-12-30-00.gh-issue-159864.4FZ6MR.rst https://github.com/python/cpython/pull/159884/files#diff-b5c082625f43c2967beb95e0076750a4344b3523101e75bc9dcb66e9b394fde6
syslogmodule.c https://github.com/python/cpython/pull/159884/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
Lib/test/test_free_threading/test_syslog.pyhttps://github.com/python/cpython/pull/159884/files#diff-a71f68a9fccec021d32c130bc7292b02c2c118ba18e202bf1d189d59470cda84
View file https://github.com/espressolee/cpython/blob/38a30c5a5d93a5cf8e9771d4a4e7eec6406482fa/Lib/test/test_free_threading/test_syslog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159884/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159884/files#diff-a71f68a9fccec021d32c130bc7292b02c2c118ba18e202bf1d189d59470cda84
https://github.com/python/cpython/pull/159884/files#diff-a71f68a9fccec021d32c130bc7292b02c2c118ba18e202bf1d189d59470cda84
Misc/NEWS.d/next/Library/2026-10-20-12-30-00.gh-issue-159864.4FZ6MR.rsthttps://github.com/python/cpython/pull/159884/files#diff-b5c082625f43c2967beb95e0076750a4344b3523101e75bc9dcb66e9b394fde6
View file https://github.com/espressolee/cpython/blob/38a30c5a5d93a5cf8e9771d4a4e7eec6406482fa/Misc/NEWS.d/next/Library/2026-10-20-12-30-00.gh-issue-159864.4FZ6MR.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159884/{{ revealButtonHref }}
Modules/syslogmodule.chttps://github.com/python/cpython/pull/159884/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
View file https://github.com/espressolee/cpython/blob/38a30c5a5d93a5cf8e9771d4a4e7eec6406482fa/Modules/syslogmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159884/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159884/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
https://github.com/python/cpython/pull/159884/files#diff-d14bac03cd6d37d67cf2b5800a66f3cea233a3edd515fcf53bc7a6234af8f810
Please reload this pagehttps://github.com/python/cpython/pull/159884/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.