René's URL Explorer Experiment


Title: [3.14] gh-157364: Fix use-after-free in io.TextIOWrapper during reentrant detach by vstinner · Pull Request #159600 · python/cpython · GitHub

Open Graph Title: [3.14] gh-157364: Fix use-after-free in io.TextIOWrapper during reentrant detach by vstinner · Pull Request #159600 · python/cpython

X Title: [3.14] gh-157364: Fix use-after-free in io.TextIOWrapper during reentrant detach by vstinner · Pull Request #159600 · python/cpython

Description: gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access (#145957) TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detached by user code, such as custom .flush implementations resulting in self->buffer being set to NULL. The implementation often checked at the start of functions if self->buffer is in a good state, but did not always recheck after other Python code was called which could modify self->buffer. The cases which need to be re-checked are hard to spot so rather than rely on reviewer effort create better safety by making all self->buffer access go through helper functions. Thank you yihong0618 for the test, NEWS and initial implementation in gh-143041. (cherry picked from commit db4b194) gh-154523: Fix data-race in TextIOWrapper.detach() (#154565) (cherry picked from commit 8440a6a) gh-157364: Fix use-after-free in io.TextIOWrapper during reentrant detach (#157370) (cherry picked from commit e19dc47) (cherry picked from commit ea1312b)

Open Graph Description: gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access (#145957) TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detach...

X Description: gh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access (#145957) TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be de...

Opengraph URL: https://github.com/python/cpython/pull/159600

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f9c039b2-254b-da55-f130-2a8f6f9c9d31
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC84A:2E3FEE:3FE4EA9:50D7A0B:6B02142A
html-safe-nonced9f746e32056d773f16f1b2272c7863655720e55b2d138e6e713a314e739c602
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODRBOjJFM0ZFRTozRkU0RUE5OjUwRDdBMEI6NkIwMjE0MkEiLCJ2aXNpdG9yX2lkIjoiNjU2MzA4Nzc1NTI3NzExMjM2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacea8ed361a49c57506714ba5e117c42ce4e2a00656b109e21602b425c00654895
hovercard-subject-tagpull_request:4895411579
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159600/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altgh-143008: Fix Null pointer dereferences in TextIOWrapper underlying stream access (#145957) TextIOWrapper keeps its underlying stream in a member called self->buffer. That stream can be detach...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159600/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159600%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159600%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159600/files
Reloadhttps://github.com/python/cpython/pull/159600/files
Reloadhttps://github.com/python/cpython/pull/159600/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:3.14https://github.com/python/cpython/tree/3.14
vstinner:textio14https://github.com/vstinner/cpython/tree/textio14
Conversation 0 https://github.com/python/cpython/pull/159600
Commits 1 https://github.com/python/cpython/pull/159600/commits
Checks 48 https://github.com/python/cpython/pull/159600/checks
Files changed https://github.com/python/cpython/pull/159600/files
Please reload this pagehttps://github.com/python/cpython/pull/159600/files
[3.14] gh-157364: Fix use-after-free in io.TextIOWrapper during reentrant detach https://github.com/python/cpython/pull/159600/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/159600/files
5145a3e [3.15] gh-157364: Fix use-after-free in io.TextIOWrapper during reent… vstinner Oct 16, 2026 https://github.com/python/cpython/pull/159600/commits/5145a3e9b4c621b341ce6a8c0cf2d26ced64a45a
Clear filters https://github.com/python/cpython/pull/159600/files
Please reload this pagehttps://github.com/python/cpython/pull/159600/files
Please reload this pagehttps://github.com/python/cpython/pull/159600/files
test_io.py https://github.com/python/cpython/pull/159600/files#diff-bf1f83ccd2a3dfa0660824e2d685f4980d59e08e094ea0d88d08b074b70bd52d
test_io.py https://github.com/python/cpython/pull/159600/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
2025-12-21-17-56-37.gh-issue-143008.aakErJ.rst https://github.com/python/cpython/pull/159600/files#diff-64eacb2a655e36ff9e4bfcd2977e304d123c8382e1aa025ef213a67b3162a23c
2026-06-04-18-22-56.gh-issue-143008.z5tw-J.rst https://github.com/python/cpython/pull/159600/files#diff-6bbf39fad3c6da5b3d5f1a116a950c59d38b733ccf56f3c27c26869a511f19d9
2026-07-23-18-53-48.gh-issue-154523.XUSRBO.rst https://github.com/python/cpython/pull/159600/files#diff-5639271757db741150a26547c613409a306e9b2d3796493fd6396f20c44d25c3
2026-09-12-18-03-15.gh-issue-157364.Qd7mKs.rst https://github.com/python/cpython/pull/159600/files#diff-0f39e67e5600db4664769ebce28c3f81885f17ff18ba5001b59baf6e2b371276
textio.c.h https://github.com/python/cpython/pull/159600/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8
textio.c https://github.com/python/cpython/pull/159600/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3
Lib/test/test_free_threading/test_io.pyhttps://github.com/python/cpython/pull/159600/files#diff-bf1f83ccd2a3dfa0660824e2d685f4980d59e08e094ea0d88d08b074b70bd52d
View file https://github.com/vstinner/cpython/blob/5145a3e9b4c621b341ce6a8c0cf2d26ced64a45a/Lib/test/test_free_threading/test_io.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159600/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159600/files#diff-bf1f83ccd2a3dfa0660824e2d685f4980d59e08e094ea0d88d08b074b70bd52d
Lib/test/test_io.pyhttps://github.com/python/cpython/pull/159600/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
View file https://github.com/vstinner/cpython/blob/5145a3e9b4c621b341ce6a8c0cf2d26ced64a45a/Lib/test/test_io.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159600/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159600/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
https://github.com/python/cpython/pull/159600/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f
Misc/NEWS.d/next/Library/2025-12-21-17-56-37.gh-issue-143008.aakErJ.rsthttps://github.com/python/cpython/pull/159600/files#diff-64eacb2a655e36ff9e4bfcd2977e304d123c8382e1aa025ef213a67b3162a23c
View file https://github.com/vstinner/cpython/blob/5145a3e9b4c621b341ce6a8c0cf2d26ced64a45a/Misc/NEWS.d/next/Library/2025-12-21-17-56-37.gh-issue-143008.aakErJ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159600/{{ revealButtonHref }}
Misc/NEWS.d/next/Library/2026-06-04-18-22-56.gh-issue-143008.z5tw-J.rsthttps://github.com/python/cpython/pull/159600/files#diff-6bbf39fad3c6da5b3d5f1a116a950c59d38b733ccf56f3c27c26869a511f19d9
View file https://github.com/vstinner/cpython/blob/5145a3e9b4c621b341ce6a8c0cf2d26ced64a45a/Misc/NEWS.d/next/Library/2026-06-04-18-22-56.gh-issue-143008.z5tw-J.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159600/{{ revealButtonHref }}
Misc/NEWS.d/next/Library/2026-07-23-18-53-48.gh-issue-154523.XUSRBO.rsthttps://github.com/python/cpython/pull/159600/files#diff-5639271757db741150a26547c613409a306e9b2d3796493fd6396f20c44d25c3
View file https://github.com/vstinner/cpython/blob/5145a3e9b4c621b341ce6a8c0cf2d26ced64a45a/Misc/NEWS.d/next/Library/2026-07-23-18-53-48.gh-issue-154523.XUSRBO.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159600/{{ revealButtonHref }}
Misc/NEWS.d/next/Library/2026-09-12-18-03-15.gh-issue-157364.Qd7mKs.rsthttps://github.com/python/cpython/pull/159600/files#diff-0f39e67e5600db4664769ebce28c3f81885f17ff18ba5001b59baf6e2b371276
View file https://github.com/vstinner/cpython/blob/5145a3e9b4c621b341ce6a8c0cf2d26ced64a45a/Misc/NEWS.d/next/Library/2026-09-12-18-03-15.gh-issue-157364.Qd7mKs.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159600/{{ revealButtonHref }}
Modules/_io/clinic/textio.c.hhttps://github.com/python/cpython/pull/159600/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8
View file https://github.com/vstinner/cpython/blob/5145a3e9b4c621b341ce6a8c0cf2d26ced64a45a/Modules/_io/clinic/textio.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/159600/files
Please reload this pagehttps://github.com/python/cpython/pull/159600/files
Please reload this pagehttps://github.com/python/cpython/pull/159600/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.