René's URL Explorer Experiment


Title: gh-159514: Fix tuple item reference leak on resize allocation failure by zolaski333 · Pull Request #159526 · python/cpython · GitHub

Open Graph Title: gh-159514: Fix tuple item reference leak on resize allocation failure by zolaski333 · Pull Request #159526 · python/cpython

X Title: gh-159514: Fix tuple item reference leak on resize allocation failure by zolaski333 · Pull Request #159526 · python/cpython

Description: _PyTuple_Resize() frees the tuple storage after a failed PyObject_GC_Resize() without releasing its item references. Release the remaining items before freeing the storage. Py_XDECREF() also handles entries already cleared during shrinking. Add a regression test that forces MemoryError through the allocator's checked size limit and verifies that the item is released. It fails before the fix and passes afterwards. The leak was also reproduced by calling _PyTuple_Resize() directly through ctypes.pythonapi, without _testcapi: the caller's pointer became NULL, but the item remained alive. The _testcapi wrapper is unchanged. Validation on Windows x64 Debug: test_capi.test_tuple, test_capi.test_mem and test_tuple pass in the standard build and the free-threaded build with the GIL disabled and enabled. test_capi.test_tuple passes -R 3:3 in both builds. Allocation-failure checks cover growing, shrinking and NULL entries. patchcheck and git diff --check pass. Issue: gh-159514

Open Graph Description: _PyTuple_Resize() frees the tuple storage after a failed PyObject_GC_Resize() without releasing its item references. Release the remaining items before freeing the storage. Py_XDECREF() also handle...

X Description: _PyTuple_Resize() frees the tuple storage after a failed PyObject_GC_Resize() without releasing its item references. Release the remaining items before freeing the storage. Py_XDECREF() also handle...

Opengraph URL: https://github.com/python/cpython/pull/159526

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:be687b1b-3cff-548c-2e51-ebcd4b25284d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9B2:97D39:181416E:1F94E5B:6B023CAE
html-safe-nonced1403feed45b46e4b42cecd42cb9a6b50e34efd28f616035a99cb69c7f0391ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUIyOjk3RDM5OjE4MTQxNkU6MUY5NEU1Qjo2QjAyM0NBRSIsInZpc2l0b3JfaWQiOiI3OTE3MjQ0MDgxMzE3NzU2MDc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac584fcf925db2f981a88f6de0979309eeec6a8ef33b2f3aa83bc301d80be01b82
hovercard-subject-tagpull_request:4887937713
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159526/files
twitter:imagehttps://avatars.githubusercontent.com/u/57315647?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/57315647?s=400&v=4
og:image:alt_PyTuple_Resize() frees the tuple storage after a failed PyObject_GC_Resize() without releasing its item references. Release the remaining items before freeing the storage. Py_XDECREF() also handle...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159526/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159526%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159526%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159526/files
Reloadhttps://github.com/python/cpython/pull/159526/files
Reloadhttps://github.com/python/cpython/pull/159526/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zolaski333https://github.com/zolaski333
python:mainhttps://github.com/python/cpython/tree/main
zolaski333:gh-159514-tuple-resize-leakhttps://github.com/zolaski333/cpython/tree/gh-159514-tuple-resize-leak
Conversation 0 https://github.com/python/cpython/pull/159526
Commits 2 https://github.com/python/cpython/pull/159526/commits
Checks 52 https://github.com/python/cpython/pull/159526/checks
Files changed 3 https://github.com/python/cpython/pull/159526/files
gh-159514: Fix tuple item reference leak on resize allocation failure https://github.com/python/cpython/pull/159526/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/159526/files
9437875 gh-159514: Fix tuple item reference leak on resize allocation failure zolaski333 Oct 16, 2026 https://github.com/python/cpython/pull/159526/commits/9437875a71b3e8a790fb6c8d0d4fb5c3f03e4124
e6db664 gh-159514: Use the current NEWS category directory zolaski333 Oct 16, 2026 https://github.com/python/cpython/pull/159526/commits/e6db664361702a2103f7352f2e1a22c2921d8e19
Clear filters https://github.com/python/cpython/pull/159526/files
Please reload this pagehttps://github.com/python/cpython/pull/159526/files
Please reload this pagehttps://github.com/python/cpython/pull/159526/files
test_tuple.py https://github.com/python/cpython/pull/159526/files#diff-666a430c62401e7e7ef2b95168ac5523aa614e3cebaf0f524aabc9e322029b28
2026-10-16-13-45-00.gh-issue-159514.tuple-resize.rst https://github.com/python/cpython/pull/159526/files#diff-0ccc830ead071bff5880175af52d01b1f67c3d271cda449eb978d7afc42edb51
tupleobject.c https://github.com/python/cpython/pull/159526/files#diff-1c580282bd10a8157cc81dd4a4658d4bb47f75ea476cd433bc7435913b33eb77
Lib/test/test_capi/test_tuple.pyhttps://github.com/python/cpython/pull/159526/files#diff-666a430c62401e7e7ef2b95168ac5523aa614e3cebaf0f524aabc9e322029b28
View file https://github.com/zolaski333/cpython/blob/e6db664361702a2103f7352f2e1a22c2921d8e19/Lib/test/test_capi/test_tuple.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159526/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159526/files#diff-666a430c62401e7e7ef2b95168ac5523aa614e3cebaf0f524aabc9e322029b28
https://github.com/python/cpython/pull/159526/files#diff-666a430c62401e7e7ef2b95168ac5523aa614e3cebaf0f524aabc9e322029b28
https://github.com/python/cpython/pull/159526/files#diff-666a430c62401e7e7ef2b95168ac5523aa614e3cebaf0f524aabc9e322029b28
...S.d/next/Core_and_Builtins/2026-10-16-13-45-00.gh-issue-159514.tuple-resize.rsthttps://github.com/python/cpython/pull/159526/files#diff-0ccc830ead071bff5880175af52d01b1f67c3d271cda449eb978d7afc42edb51
View file https://github.com/zolaski333/cpython/blob/e6db664361702a2103f7352f2e1a22c2921d8e19/Misc/NEWS.d/next/Core_and_Builtins/2026-10-16-13-45-00.gh-issue-159514.tuple-resize.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159526/{{ revealButtonHref }}
Objects/tupleobject.chttps://github.com/python/cpython/pull/159526/files#diff-1c580282bd10a8157cc81dd4a4658d4bb47f75ea476cd433bc7435913b33eb77
View file https://github.com/zolaski333/cpython/blob/e6db664361702a2103f7352f2e1a22c2921d8e19/Objects/tupleobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159526/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159526/files#diff-1c580282bd10a8157cc81dd4a4658d4bb47f75ea476cd433bc7435913b33eb77
https://github.com/python/cpython/pull/159526/files#diff-1c580282bd10a8157cc81dd4a4658d4bb47f75ea476cd433bc7435913b33eb77
Please reload this pagehttps://github.com/python/cpython/pull/159526/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.