René's URL Explorer Experiment


Title: gh-159485: Fix warnings lock deadlock during interpreter shutdown by ngoldbaum · Pull Request #159488 · python/cpython · GitHub

Open Graph Title: gh-159485: Fix warnings lock deadlock during interpreter shutdown by ngoldbaum · Pull Request #159488 · python/cpython

X Title: gh-159485: Fix warnings lock deadlock during interpreter shutdown by ngoldbaum · Pull Request #159488 · python/cpython

Description: Closes #159485 It looks like the 3.14 backport will need to happen manually but I think the same fix applies there as well if I adjust where the shutdown hook goes. Issue: gh-159485

Open Graph Description: Closes #159485 It looks like the 3.14 backport will need to happen manually but I think the same fix applies there as well if I adjust where the shutdown hook goes. Issue: gh-159485

X Description: Closes #159485 It looks like the 3.14 backport will need to happen manually but I think the same fix applies there as well if I adjust where the shutdown hook goes. Issue: gh-159485

Opengraph URL: https://github.com/python/cpython/pull/159488

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8bc6b085-7bbd-6865-ec61-0309b640094f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC518:3B07B3:9C9DFE:C44C3B:6B021BAA
html-safe-nonce17f0aabb551b60c51017c33cca77bd5e49e8abdb71f09397ddbb6ec1c18a49e3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTE4OjNCMDdCMzo5QzlERkU6QzQ0QzNCOjZCMDIxQkFBIiwidmlzaXRvcl9pZCI6IjYwODg4NTkyNzIwMDE3NTYwNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac06df47ccdefb4bc4fa629948e5bdb9855435237cc3558a2455cb1f22ec26d383
hovercard-subject-tagpull_request:4879696287
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159488/files
twitter:imagehttps://avatars.githubusercontent.com/u/3126246?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3126246?s=400&v=4
og:image:altCloses #159485 It looks like the 3.14 backport will need to happen manually but I think the same fix applies there as well if I adjust where the shutdown hook goes. Issue: gh-159485
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159488/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159488%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159488%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159488/files
Reloadhttps://github.com/python/cpython/pull/159488/files
Reloadhttps://github.com/python/cpython/pull/159488/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ngoldbaumhttps://github.com/ngoldbaum
python:mainhttps://github.com/python/cpython/tree/main
ngoldbaum:gh-158974-warnings-shutdownhttps://github.com/ngoldbaum/cpython/tree/gh-158974-warnings-shutdown
Conversation 18 https://github.com/python/cpython/pull/159488
Commits 5 https://github.com/python/cpython/pull/159488/commits
Checks 52 https://github.com/python/cpython/pull/159488/checks
Files changed https://github.com/python/cpython/pull/159488/files
Please reload this pagehttps://github.com/python/cpython/pull/159488/files
gh-159485: Fix warnings lock deadlock during interpreter shutdown https://github.com/python/cpython/pull/159488/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/159488/files
37baa8f gh-159485: Fix warnings lock deadlock during interpreter shutdown ngoldbaum Oct 15, 2026 https://github.com/python/cpython/pull/159488/commits/37baa8fb9af1d2a68c5350d5d8f781ad095ed864
fdec193 gh-159485: Hold an interpreter guard while using the warnings lock ngoldbaum Oct 16, 2026 https://github.com/python/cpython/pull/159488/commits/fdec193a5878d772dd7f4640c8aa4d39d516022b
3f35eeb Merge branch 'main' into gh-158974-warnings-shutdown ngoldbaum Oct 16, 2026 https://github.com/python/cpython/pull/159488/commits/3f35eeb4b823d12d598804632098ebce24a7ab3b
538a842 gh-159485: Use the public interpreter guard API for the warnings lock ngoldbaum Oct 16, 2026 https://github.com/python/cpython/pull/159488/commits/538a8429f64d13824a5d6d69e51ea61c9cca4110
ff88988 Merge branch 'main' into gh-158974-warnings-shutdown ngoldbaum Oct 16, 2026 https://github.com/python/cpython/pull/159488/commits/ff88988be1bab4df1c49e0cca0e45427b2dfa4a3
Clear filters https://github.com/python/cpython/pull/159488/files
Please reload this pagehttps://github.com/python/cpython/pull/159488/files
Please reload this pagehttps://github.com/python/cpython/pull/159488/files
pycore_tstate.h https://github.com/python/cpython/pull/159488/files#diff-7d65c03065cc654fe51b92748324dcc062d995c291981e586bba827af6aa7045
test_embed.py https://github.com/python/cpython/pull/159488/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
2026-10-15-14-41-28.gh-issue-159485.S3IOyb.rst https://github.com/python/cpython/pull/159488/files#diff-2ee50caf4e7ef0c0122a5b958100b0fe3cd3bfa32abef2c1c77214845d5a82ff
_warnings.c https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L330
Include/internal/pycore_tstate.hhttps://github.com/python/cpython/pull/159488/files#diff-7d65c03065cc654fe51b92748324dcc062d995c291981e586bba827af6aa7045
View file https://github.com/ngoldbaum/cpython/blob/ff88988be1bab4df1c49e0cca0e45427b2dfa4a3/Include/internal/pycore_tstate.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159488/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159488/files#diff-7d65c03065cc654fe51b92748324dcc062d995c291981e586bba827af6aa7045
https://github.com/python/cpython/pull/159488/files#diff-7d65c03065cc654fe51b92748324dcc062d995c291981e586bba827af6aa7045
Lib/test/test_embed.pyhttps://github.com/python/cpython/pull/159488/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
View file https://github.com/ngoldbaum/cpython/blob/ff88988be1bab4df1c49e0cca0e45427b2dfa4a3/Lib/test/test_embed.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159488/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159488/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
https://github.com/python/cpython/pull/159488/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
Misc/NEWS.d/next/Core_and_Builtins/2026-10-15-14-41-28.gh-issue-159485.S3IOyb.rsthttps://github.com/python/cpython/pull/159488/files#diff-2ee50caf4e7ef0c0122a5b958100b0fe3cd3bfa32abef2c1c77214845d5a82ff
View file https://github.com/ngoldbaum/cpython/blob/ff88988be1bab4df1c49e0cca0e45427b2dfa4a3/Misc/NEWS.d/next/Core_and_Builtins/2026-10-15-14-41-28.gh-issue-159485.S3IOyb.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159488/{{ revealButtonHref }}
Python/_warnings.chttps://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
View file https://github.com/ngoldbaum/cpython/blob/ff88988be1bab4df1c49e0cca0e45427b2dfa4a3/Python/_warnings.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159488/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
https://github.com/python/cpython/pull/159488/files#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
Please reload this pagehttps://github.com/python/cpython/pull/159488/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.