René's URL Explorer Experiment


Title: gh-159485: Fix warnings lock deadlock during interpreter shutdown by ngoldbaum · Pull Request #159488 · python/cpython · GitHub

Open Graph Title: gh-159485: Fix warnings lock deadlock during interpreter shutdown by ngoldbaum · Pull Request #159488 · python/cpython

X Title: gh-159485: Fix warnings lock deadlock during interpreter shutdown by ngoldbaum · Pull Request #159488 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Closes #159485 It looks like the 3.14 backport will need to happen manually but I think the same fix applies there as well if I adjust where the shutdown hook goes. Issue: Interpreter shutdown ca...

X Description: Closes #159485 It looks like the 3.14 backport will need to happen manually but I think the same fix applies there as well if I adjust where the shutdown hook goes. Issue: Interpreter shutdown ca...

Opengraph URL: https://github.com/python/cpython/pull/159488

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4ed1f9bf-bff4-44d6-ee94-08e907dc5e75
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92CA:B1B84:336A45C:416934F:6B0212CF
html-safe-nonce856e41481e414fa4edd4f02f2267a6643d34af40b33111aa9f482761bd99c5a7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkNBOkIxQjg0OjMzNkE0NUM6NDE2OTM0Rjo2QjAyMTJDRiIsInZpc2l0b3JfaWQiOiI1MTM2MTg2NjMxODQxMjU2MTQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7a390a3e647af4bf44da8f9696e5cdf0e6dd05a6437274ccf38f269ffb107d8b
hovercard-subject-tagpull_request:4879696287
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/159488/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bd9d172c7ebb76a8243a910f682c8bca8ce396981131bb7fb2f0f79c8c6ebb8e/python/cpython/pull/159488
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bd9d172c7ebb76a8243a910f682c8bca8ce396981131bb7fb2f0f79c8c6ebb8e/python/cpython/pull/159488
og:image:altCloses #159485 It looks like the 3.14 backport will need to happen manually but I think the same fix applies there as well if I adjust where the shutdown hook goes. Issue: Interpreter shutdown ca...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamengoldbaum
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/159488#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159488
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159488
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159488
Reloadhttps://github.com/python/cpython/pull/159488
Reloadhttps://github.com/python/cpython/pull/159488
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
ngoldbaumhttps://github.com/ngoldbaum
python:mainhttps://github.com/python/cpython/tree/main
ngoldbaum:gh-158974-warnings-shutdownhttps://github.com/ngoldbaum/cpython/tree/gh-158974-warnings-shutdown
Conversationhttps://github.com/python/cpython/pull/159488
Commits5 (5)https://github.com/python/cpython/pull/159488/commits
Checkshttps://github.com/python/cpython/pull/159488/checks
Files changedhttps://github.com/python/cpython/pull/159488/files
gh-159485: Fix warnings lock deadlock during interpreter shutdownhttps://github.com/python/cpython/pull/159488#top
ngoldbaumhttps://github.com/ngoldbaum
python:mainhttps://github.com/python/cpython/tree/main
ngoldbaum:gh-158974-warnings-shutdownhttps://github.com/ngoldbaum/cpython/tree/gh-158974-warnings-shutdown
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
Oct 15, 2026https://github.com/python/cpython/pull/159488#issue-5873752742
Please reload this pagehttps://github.com/python/cpython/pull/159488
#159485https://github.com/python/cpython/issues/159485
Interpreter shutdown can deadlock when a daemon thread holds the warnings lock #159485https://github.com/python/cpython/issues/159485
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/ngoldbaum
pythongh-159485https://github.com/python/cpython/issues/159485
: Fix warnings lock deadlock during interpreter shutdownhttps://github.com/python/cpython/pull/159488/commits/37baa8fb9af1d2a68c5350d5d8f781ad095ed864
37baa8fhttps://github.com/python/cpython/pull/159488/commits/37baa8fb9af1d2a68c5350d5d8f781ad095ed864
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
naschemehttps://github.com/nascheme
October 15, 2026 20:53https://github.com/python/cpython/pull/159488#event-33377622306
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Oct 15, 2026https://github.com/python/cpython/pull/159488#event-33377623690
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
code ownerhttps://github.com/python/cpython/blob/938144efad4659f7aa66bf9ef362fd3c602c4bbc/.github/CODEOWNERS#L314
October 15, 2026 20:53https://github.com/python/cpython/pull/159488#event-33377623941
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
Oct 15, 2026https://github.com/python/cpython/pull/159488#event-33377624042
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
FFY00https://github.com/FFY00
ZeroIntensityhttps://github.com/ZeroIntensity
code ownershttps://github.com/python/cpython/blob/938144efad4659f7aa66bf9ef362fd3c602c4bbc/.github/CODEOWNERS#L314
October 15, 2026 20:53https://github.com/python/cpython/pull/159488#event-33377624138
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Oct 15, 2026https://github.com/python/cpython/pull/159488#event-33377624364
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 15, 2026 https://github.com/python/cpython/pull/159488#ref-issue-5873460855
Interpreter shutdown can deadlock when a daemon thread holds the warnings lock #159485 https://github.com/python/cpython/issues/159485
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 15, 2026https://github.com/python/cpython/pull/159488#event-33377634318
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 15, 2026 https://github.com/python/cpython/pull/159488#pullrequestreview-5540418405
View reviewed changes https://github.com/python/cpython/pull/159488/files/37baa8fb9af1d2a68c5350d5d8f781ad095ed864
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/159488#pullrequestreview-5540418405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
Oct 15, 2026https://github.com/python/cpython/pull/159488#issuecomment-6203540494
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 16, 2026https://github.com/python/cpython/pull/159488#issuecomment-6204924549
Please reload this pagehttps://github.com/python/cpython/pull/159488
ngoldbaumhttps://github.com/ngoldbaum
October 16, 2026 09:10https://github.com/python/cpython/pull/159488#commits-pushed-fdec193
https://github.com/ngoldbaum
pythongh-159485https://github.com/python/cpython/issues/159485
: Hold an interpreter guard while using the warnings lockhttps://github.com/python/cpython/pull/159488/commits/fdec193a5878d772dd7f4640c8aa4d39d516022b
fdec193https://github.com/python/cpython/pull/159488/commits/fdec193a5878d772dd7f4640c8aa4d39d516022b
https://github.com/ngoldbaum
Merge branch 'main' intohttps://github.com/python/cpython/pull/159488/commits/3f35eeb4b823d12d598804632098ebce24a7ab3b
pythongh-158974https://github.com/python/cpython/pull/158974
-warnings-shutdownhttps://github.com/python/cpython/pull/159488/commits/3f35eeb4b823d12d598804632098ebce24a7ab3b
3f35eebhttps://github.com/python/cpython/pull/159488/commits/3f35eeb4b823d12d598804632098ebce24a7ab3b
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
Oct 16, 2026https://github.com/python/cpython/pull/159488#issuecomment-6218511080
@ZeroIntensityhttps://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 16, 2026 https://github.com/python/cpython/pull/159488#pullrequestreview-5550062230
View reviewed changes https://github.com/python/cpython/pull/159488/files/3f35eeb4b823d12d598804632098ebce24a7ab3b
Python/_warnings.chttps://github.com/python/cpython/pull/159488/files/3f35eeb4b823d12d598804632098ebce24a7ab3b#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 16, 2026https://github.com/python/cpython/pull/159488#discussion_r4296406114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/159488
ngoldbaumhttps://github.com/ngoldbaum
Oct 16, 2026https://github.com/python/cpython/pull/159488#discussion_r4297369586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/159488
Python/_warnings.chttps://github.com/python/cpython/pull/159488/files/3f35eeb4b823d12d598804632098ebce24a7ab3b#diff-868cb9c3ec7f49459c652319e480e03ee132976b45fbedacb94958f8e0a9ea58
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 16, 2026https://github.com/python/cpython/pull/159488#discussion_r4296448857
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/159488
ngoldbaumhttps://github.com/ngoldbaum
Oct 16, 2026https://github.com/python/cpython/pull/159488#discussion_r4296549948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@naschemehttps://github.com/nascheme
Please reload this pagehttps://github.com/python/cpython/pull/159488
naschemehttps://github.com/nascheme
Oct 16, 2026https://github.com/python/cpython/pull/159488#discussion_r4297199947
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/159488
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 16, 2026https://github.com/python/cpython/pull/159488#discussion_r4297906070
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/159488
naschemehttps://github.com/nascheme
Oct 16, 2026https://github.com/python/cpython/pull/159488#discussion_r4299640032
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/159488
ngoldbaumhttps://github.com/ngoldbaum
October 16, 2026 11:12https://github.com/python/cpython/pull/159488#commits-pushed-538a842
https://github.com/ngoldbaum
pythongh-159485https://github.com/python/cpython/issues/159485
: Use the public interpreter guard API for the warning…https://github.com/python/cpython/pull/159488/commits/538a8429f64d13824a5d6d69e51ea61c9cca4110
538a842https://github.com/python/cpython/pull/159488/commits/538a8429f64d13824a5d6d69e51ea61c9cca4110
https://github.com/ngoldbaum
Merge branch 'main' intohttps://github.com/python/cpython/pull/159488/commits/ff88988be1bab4df1c49e0cca0e45427b2dfa4a3
pythongh-158974https://github.com/python/cpython/pull/158974
-warnings-shutdownhttps://github.com/python/cpython/pull/159488/commits/ff88988be1bab4df1c49e0cca0e45427b2dfa4a3
ff88988https://github.com/python/cpython/pull/159488/commits/ff88988be1bab4df1c49e0cca0e45427b2dfa4a3
https://github.com/nascheme
naschemehttps://github.com/nascheme
Oct 16, 2026https://github.com/python/cpython/pull/159488#issuecomment-6221077048
gh-126688https://github.com/python/cpython/issues/126688
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 16, 2026https://github.com/python/cpython/pull/159488#issuecomment-6221978911
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/nascheme
naschemehttps://github.com/nascheme
Oct 16, 2026https://github.com/python/cpython/pull/159488#issuecomment-6225580438
fork fixhttps://github.com/python/cpython/pull/158974
GH-158974https://github.com/python/cpython/pull/158974
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
Oct 16, 2026https://github.com/python/cpython/pull/159488#issuecomment-6226022857
@ZeroIntensityhttps://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 16, 2026https://github.com/python/cpython/pull/159488#issuecomment-6226556807
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/nascheme
naschemehttps://github.com/nascheme
Nov 4, 2026https://github.com/python/cpython/pull/159488#issuecomment-6639805052
GH-160401https://github.com/python/cpython/pull/160401
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
Nov 4, 2026https://github.com/python/cpython/pull/159488#event-35165914814
https://github.com/ngoldbaum
ngoldbaumhttps://github.com/ngoldbaum
Nov 4, 2026https://github.com/python/cpython/pull/159488#issuecomment-6639897058
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159488
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/159488/files/3f35eeb4b823d12d598804632098ebce24a7ab3b
https://github.com/nascheme
nascheme https://github.com/nascheme
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/FFY00
FFY00 https://github.com/FFY00
Please reload this pagehttps://github.com/python/cpython/pull/159488
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Interpreter shutdown can deadlock when a daemon thread holds the warnings lock https://github.com/python/cpython/issues/159485
Please reload this pagehttps://github.com/python/cpython/pull/159488
https://github.com/ngoldbaum
https://github.com/ZeroIntensity
https://github.com/nascheme
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.