René's URL Explorer Experiment


Title: gh-159449: Fix a free-threaded asyncio race that corrupts the task lists by jblespiau · Pull Request #159483 · python/cpython · GitHub

Open Graph Title: gh-159449: Fix a free-threaded asyncio race that corrupts the task lists by jblespiau · Pull Request #159483 · python/cpython

X Title: gh-159449: Fix a free-threaded asyncio race that corrupts the task lists by jblespiau · Pull Request #159483 · python/cpython

Description: When a thread exits with pending asyncio Tasks, PyThreadState_Clear() moves them onto the shared interp->asyncio_tasks_head list, but each Task still records the _Py_ThreadId() of the thread that created it. unregister_task() skips the stop-the-world pause whenever that id matches the current thread. That also happens for a later thread that reuses the exited thread's pthread_t, and for destructors that run later in PyThreadState_Clear(). The resulting unlocked llist_remove() calls on the shared list race with each other and can leave an already-removed node (next == NULL) linked into it. asyncio.all_tasks(), which asyncio.run() calls on shutdown, then crashes with SIGSEGV in _asyncio_all_tasks(). Record the unique id (PyThreadState.id) of the creating thread state instead, and only take the lock-free path while that thread state is not being cleared. Also drop the assertion in add_tasks_llist() that every linked Task is pending. A Task's state is set before unregister_task() unlinks it, and that removal can be waiting for the stop-the-world pause during which the list is walked. add_one_task() already filters out Tasks that are done. 3.14 fix is in #159451 that we can reopen if this one is accepted. Issue: gh-159449

Open Graph Description: When a thread exits with pending asyncio Tasks, PyThreadState_Clear() moves them onto the shared interp->asyncio_tasks_head list, but each Task still records the _Py_ThreadId() of the thread tha...

X Description: When a thread exits with pending asyncio Tasks, PyThreadState_Clear() moves them onto the shared interp->asyncio_tasks_head list, but each Task still records the _Py_ThreadId() of the thread...

Opengraph URL: https://github.com/python/cpython/pull/159483

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:acb066bd-9b00-a0a6-6d61-7a028d6277aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7CA:14EB6E:15ABB38:1C874BF:6B01F8A9
html-safe-nonceff5f2db526fb7d9a8823c6a051f9a158537e58e6d18f202436d21c8d30ccdc1e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0NBOjE0RUI2RToxNUFCQjM4OjFDODc0QkY6NkIwMUY4QTkiLCJ2aXNpdG9yX2lkIjoiMTQxMTcxOTUyMzk0MTM0OTU0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccb77a8b6db9630ce055a1adbed9f98a1e35a5d6cf6722dfe3fc6d158c783ddf1
hovercard-subject-tagpull_request:4878203817
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159483/files
twitter:imagehttps://avatars.githubusercontent.com/u/534945?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534945?s=400&v=4
og:image:altWhen a thread exits with pending asyncio Tasks, PyThreadState_Clear() moves them onto the shared interp->asyncio_tasks_head list, but each Task still records the _Py_ThreadId() of the thread tha...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159483/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159483%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159483%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159483/files
Reloadhttps://github.com/python/cpython/pull/159483/files
Reloadhttps://github.com/python/cpython/pull/159483/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
jblespiau:fix-asyncio-task-unregister-racehttps://github.com/jblespiau/cpython/tree/fix-asyncio-task-unregister-race
Conversation 17 https://github.com/python/cpython/pull/159483
Commits 13 https://github.com/python/cpython/pull/159483/commits
Checks 62 https://github.com/python/cpython/pull/159483/checks
Files changed https://github.com/python/cpython/pull/159483/files
Please reload this pagehttps://github.com/python/cpython/pull/159483/files
gh-159449: Fix a free-threaded asyncio race that corrupts the task lists https://github.com/python/cpython/pull/159483/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/159483/files
8e75acc gh-159449: Fix a free-threaded asyncio race that corrupts the task lists jblespiau Oct 15, 2026 https://github.com/python/cpython/pull/159483/commits/8e75accaa1757b117eedfbee8f688fc2258b4268
e60bb19 📜🤖 Added by blurb_it. blurb-it[bot] Oct 15, 2026 https://github.com/python/cpython/pull/159483/commits/e60bb199fda7f36e8116906468b37749f1ca54cb
acea81d Remove extra blub-it file. jblespiau Oct 15, 2026 https://github.com/python/cpython/pull/159483/commits/acea81d7b3d7dcf458ae4b0985248c35e4657c22
e79f79e Merge branch 'main' into fix-asyncio-task-unregister-race jblespiau Oct 15, 2026 https://github.com/python/cpython/pull/159483/commits/e79f79e1d7c73773c4b840be6d4741511b1b890c
78ffcac Merge branch 'main' into fix-asyncio-task-unregister-race jblespiau Nov 2, 2026 https://github.com/python/cpython/pull/159483/commits/78ffcac91880474743f3625a4edf38cd2c235282
58c83fc Remove comments and rebase to head. jblespiau Nov 2, 2026 https://github.com/python/cpython/pull/159483/commits/58c83fcef31c7e47f5fbef4a2e47e57acba1d343
3f23308 Merge branch 'main' of https://github.com/python/cpython into fix-asy… jblespiau Nov 2, 2026 https://github.com/python/cpython/pull/159483/commits/3f233088bf0f01aefc18df78dab13f8bd0533d94
0def8d4 Restore main changes in _asynciomodule.c and remove comments jblespiau Nov 2, 2026 https://github.com/python/cpython/pull/159483/commits/0def8d4668fdef721cf61168be2607f5dde8603a
5a64c43 Restore original comments. jblespiau Nov 2, 2026 https://github.com/python/cpython/pull/159483/commits/5a64c43bf6e641e80fec6c02511abc649df00a75
12ea214 Record the owning thread state in register_task() only and rework test kumaraditya303 Nov 5, 2026 https://github.com/python/cpython/pull/159483/commits/12ea2145ad1617174483dc3d3542808760296eda
ab6f461 fix comments kumaraditya303 Nov 5, 2026 https://github.com/python/cpython/pull/159483/commits/ab6f46117af6d550d950e2e8ad2adae01fd021f4
d472986 Apply suggestion from @kumaraditya303 kumaraditya303 Nov 5, 2026 https://github.com/python/cpython/pull/159483/commits/d4729861be11223773a528791ec8fe28d6bbf022
d8ed8d2 Merge branch 'main' into fix-asyncio-task-unregister-race kumaraditya303 Nov 5, 2026 https://github.com/python/cpython/pull/159483/commits/d8ed8d22b395417da7ead8cff5d31beb2c4f7de3
Clear filters https://github.com/python/cpython/pull/159483/files
Please reload this pagehttps://github.com/python/cpython/pull/159483/files
Please reload this pagehttps://github.com/python/cpython/pull/159483/files
test_free_threading.py https://github.com/python/cpython/pull/159483/files#diff-b89972b25cde443d8f01dc4e5bed054e3ea65959e5c76372524acc231f6a2da0
2026-10-15-10-15-27.gh-issue-159449.xsdzFf.rst https://github.com/python/cpython/pull/159483/files#diff-c0b7a28d86b8a463af7875dce4db0e9fb77f4ddefe901c47dc6708cb8716fbc5
_asynciomodule.c https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L377
Lib/test/test_asyncio/test_free_threading.pyhttps://github.com/python/cpython/pull/159483/files#diff-b89972b25cde443d8f01dc4e5bed054e3ea65959e5c76372524acc231f6a2da0
View file https://github.com/jblespiau/cpython/blob/d8ed8d22b395417da7ead8cff5d31beb2c4f7de3/Lib/test/test_asyncio/test_free_threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159483/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159483/files#diff-b89972b25cde443d8f01dc4e5bed054e3ea65959e5c76372524acc231f6a2da0
https://github.com/python/cpython/pull/159483/files#diff-b89972b25cde443d8f01dc4e5bed054e3ea65959e5c76372524acc231f6a2da0
Misc/NEWS.d/next/Core_and_Builtins/2026-10-15-10-15-27.gh-issue-159449.xsdzFf.rsthttps://github.com/python/cpython/pull/159483/files#diff-c0b7a28d86b8a463af7875dce4db0e9fb77f4ddefe901c47dc6708cb8716fbc5
View file https://github.com/jblespiau/cpython/blob/d8ed8d22b395417da7ead8cff5d31beb2c4f7de3/Misc/NEWS.d/next/Core_and_Builtins/2026-10-15-10-15-27.gh-issue-159449.xsdzFf.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159483/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L378
Modules/_asynciomodule.chttps://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
View file https://github.com/jblespiau/cpython/blob/d8ed8d22b395417da7ead8cff5d31beb2c4f7de3/Modules/_asynciomodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159483/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
https://github.com/python/cpython/pull/159483/files#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
Please reload this pagehttps://github.com/python/cpython/pull/159483/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.