René's URL Explorer Experiment


Title: gh-158597: Resolve lazy submodules with the declaration in scope by xv1rcn · Pull Request #159476 · python/cpython · GitHub

Open Graph Title: gh-158597: Resolve lazy submodules with the declaration in scope by xv1rcn · Pull Request #159476 · python/cpython

X Title: gh-158597: Resolve lazy submodules with the declaration in scope by xv1rcn · Pull Request #159476 · python/cpython

Description: gh-158597: Resolve lazy submodules with the declaration in scope lazy import xml.missing records a pending child in interp->imports.lazy_pending_submodules, keyed only by (parent, child): pending["xml"]["missing"] = register_lazy_on_parent() writes that slot with PyDict_SetItem(), so a later declaration of the same name by another module replaces the earlier one. When a module then evaluates xml.missing, _PyImport_TryLoadLazySubmodule() reads that one slot and _PyLazyImport_LoadChild() copies lz_code / lz_instr_offset out of it, so the chained ImportError reports whichever declaration was registered last, no matter who is accessing. Measured before the change (main at 64018ac, debug build): declarations, in order reported location A only A.py:1 B, then A A.py:2 A, then B B.py:1 A, B, C C.py:1 This keys the declarations by the declaring module and selects one at access time from the frame's globals, so a name resolves with the declaration in scope where the access is written: pending["xml"]["missing"] == {"A": , "B": } # declarations pending["xml"]["dom"] == None # pending, no declaration A declaration made by another module still names the same child and imports the same thing, so it is still used when there is nothing in scope. It is not reported as a frame of the accessing module's traceback: lz_attributed on the placeholder records whether the location belongs to the module performing the access, and lazy_import_add_exception_cause() only adds a frame when it does. The chained ImportError then carries no frame rather than pointing into an unrelated file, and the exception type is unchanged. One visible change beyond the reported case: _PyLazyImport_LoadChild() takes lz_builtins from the declaration it is given, so the selected declaration also decides which __import__ runs. An access with a declaration of its own in scope now runs that module's hook instead of the last-registered one's — the case Yhg1s described in the gh-158521 review ("module A may end up calling module B's __import__ when it does its reification"), and the principle test_namespace_import_hooks already covers for placeholders. It does not cover it completely: an access with no declaration in scope still resolves with the most recently registered one, as before, so that case is unchanged. Remaining gaps: Two modules sharing the same __name__ are still indistinguishable, as noted in the gh-158521 review discussion. add_lazy_declaration() reads and then writes the per-child dict. The surrounding code already reads lazy_pending_submodules without a lock in _PyImport_TryLoadLazySubmodule(), and the consequence here is only that concurrent registrations of the same child can drop one declaration (the child stays pending and is resolved by the remaining one). I did not add locking because it would be a separate change; happy to do it if you want it in this PR. Testing ./python -m test test_lazy_import test_import test_importlib test_module test_sys test_capi — 3267 tests pass (debug build); -R 3:3 clean. The same on a --disable-gil --with-pydebug build. Two regression tests in ErrorHandlingTests, both failing on unmodified main: test_pending_child_reports_accessing_module_declaration test_unattributed_access_is_not_given_another_declaration NEWS entry added. AI assistance was used to locate the cause and to draft the change and the tests. I have reviewed the analysis and the patch and can explain every part of the diff.

Open Graph Description: gh-158597: Resolve lazy submodules with the declaration in scope lazy import xml.missing records a pending child in interp->imports.lazy_pending_submodules, keyed only by (parent, child): pendin...

X Description: gh-158597: Resolve lazy submodules with the declaration in scope lazy import xml.missing records a pending child in interp->imports.lazy_pending_submodules, keyed only by (parent, child): pe...

Opengraph URL: https://github.com/python/cpython/pull/159476

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fe1f8efd-0363-9a45-ecde-5e6c770fe176
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2C0:2168C:6B1D:851F:6B01F69B
html-safe-noncefbc946c980dbdcdfd6fae615a0628e0fe4b710adf164f21f7004d6224506b255
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkMwOjIxNjhDOjZCMUQ6ODUxRjo2QjAxRjY5QiIsInZpc2l0b3JfaWQiOiIzNTg5MzQzMzkyNzAzODM3ODUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacede034acb70afc913a3510cfce20a6d710d40fb2f38919a3e787f328b05b4660
hovercard-subject-tagpull_request:4876233655
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159476/files
twitter:imagehttps://avatars.githubusercontent.com/u/86313530?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86313530?s=400&v=4
og:image:altgh-158597: Resolve lazy submodules with the declaration in scope lazy import xml.missing records a pending child in interp->imports.lazy_pending_submodules, keyed only by (parent, child): pendin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159476/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159476%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159476%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159476/files
Reloadhttps://github.com/python/cpython/pull/159476/files
Reloadhttps://github.com/python/cpython/pull/159476/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
xv1rcnhttps://github.com/xv1rcn
python:mainhttps://github.com/python/cpython/tree/main
xv1rcn:gh-158597-lazy-declaration-scopehttps://github.com/xv1rcn/cpython/tree/gh-158597-lazy-declaration-scope
Conversation 2 https://github.com/python/cpython/pull/159476
Commits 1 https://github.com/python/cpython/pull/159476/commits
Checks 52 https://github.com/python/cpython/pull/159476/checks
Files changed https://github.com/python/cpython/pull/159476/files
Please reload this pagehttps://github.com/python/cpython/pull/159476/files
gh-158597: Resolve lazy submodules with the declaration in scope https://github.com/python/cpython/pull/159476/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/159476/files
00db886 gh-158597: Resolve lazy submodules with the declaration in scope xv1rcn Oct 15, 2026 https://github.com/python/cpython/pull/159476/commits/00db886877d37c0c418194a5f831d34c5d7e9e6f
Clear filters https://github.com/python/cpython/pull/159476/files
Please reload this pagehttps://github.com/python/cpython/pull/159476/files
Please reload this pagehttps://github.com/python/cpython/pull/159476/files
pycore_lazyimportobject.h https://github.com/python/cpython/pull/159476/files#diff-c8a7b6d56406abd5bc9ad1563c6dd4de12965f1be33361713ec5e87f1e9b6877
__init__.py https://github.com/python/cpython/pull/159476/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
2026-10-13-01-40-00.gh-issue-158597.k3QwZt.rst https://github.com/python/cpython/pull/159476/files#diff-f4ad6074f185b89b5735ed28ce01e4f2cbc600d6b65a2ace3812cb826bfa8c0a
lazyimportobject.c https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
import.c https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L298
Include/internal/pycore_lazyimportobject.hhttps://github.com/python/cpython/pull/159476/files#diff-c8a7b6d56406abd5bc9ad1563c6dd4de12965f1be33361713ec5e87f1e9b6877
View file https://github.com/xv1rcn/cpython/blob/00db886877d37c0c418194a5f831d34c5d7e9e6f/Include/internal/pycore_lazyimportobject.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159476/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159476/files#diff-c8a7b6d56406abd5bc9ad1563c6dd4de12965f1be33361713ec5e87f1e9b6877
https://github.com/python/cpython/pull/159476/files#diff-c8a7b6d56406abd5bc9ad1563c6dd4de12965f1be33361713ec5e87f1e9b6877
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L299
Lib/test/test_lazy_import/__init__.pyhttps://github.com/python/cpython/pull/159476/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
View file https://github.com/xv1rcn/cpython/blob/00db886877d37c0c418194a5f831d34c5d7e9e6f/Lib/test/test_lazy_import/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159476/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159476/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/159476/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/159476/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/python/cpython/pull/159476/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
Misc/NEWS.d/next/Core_and_Builtins/2026-10-13-01-40-00.gh-issue-158597.k3QwZt.rsthttps://github.com/python/cpython/pull/159476/files#diff-f4ad6074f185b89b5735ed28ce01e4f2cbc600d6b65a2ace3812cb826bfa8c0a
View file https://github.com/xv1rcn/cpython/blob/00db886877d37c0c418194a5f831d34c5d7e9e6f/Misc/NEWS.d/next/Core_and_Builtins/2026-10-13-01-40-00.gh-issue-158597.k3QwZt.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159476/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L297
Objects/lazyimportobject.chttps://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
View file https://github.com/xv1rcn/cpython/blob/00db886877d37c0c418194a5f831d34c5d7e9e6f/Objects/lazyimportobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159476/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/pull/159476/files#diff-362fa1f6146fe0049dde412c8f168e18b426ac50e4b11361611337a30309d935
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L262
Python/import.chttps://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
View file https://github.com/xv1rcn/cpython/blob/00db886877d37c0c418194a5f831d34c5d7e9e6f/Python/import.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159476/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/159476/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
Please reload this pagehttps://github.com/python/cpython/pull/159476/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.