René's URL Explorer Experiment


Title: gh-159440: Pass --work-tree to the git commands used for the version tag by sendaoYan · Pull Request #159442 · python/cpython · GitHub

Open Graph Title: gh-159440: Pass --work-tree to the git commands used for the version tag by sendaoYan · Pull Request #159442 · python/cpython

X Title: gh-159440: Pass --work-tree to the git commands used for the version tag by sendaoYan · Pull Request #159442 · python/cpython

Description: Summary The GITTAG build stamp uses git --git-dir $(srcdir)/.git describe --all --always --dirty. --git-dir does not imply a work tree, so git falls back to the current directory. In an out-of-tree build make runs in the build tree, where none of the tracked files exist, so the internal diff-index HEAD of --dirty reports every tracked file as deleted and the tag always comes out as heads/-dirty — even for a pristine checkout. In-tree builds never hit this, and GITVERSION/GITBRANCH don't touch the work tree, so only the dirty check was wrong. Pass --work-tree $(srcdir) for all three commands. The semantics of -dirty are preserved (a genuinely modified source tree still reports -dirty), and in-tree builds are unchanged because $(srcdir) is .. Reproduce sys.version reports a spurious -dirty git tag for out-of-tree builds, even when the checkout is pristine: $ mkdir -p ~/build/cpython && cd ~/build/cpython $ bash ~/git/cpython/configure --prefix=$HOME/opt/cpython > /dev/null $ make -j && make install -j $ ~/opt/cpython/bin/python3 -VV Python 3.16.0a1+dev (heads/main-dirty:25883627946, Oct 14 2026, 22:17:06) [GCC 11.4.0] Root cause GITTAG uses git --git-dir $(srcdir)/.git describe --all --always --dirty. --git-dir does not imply a work tree, so git falls back to the current directory. In an out-of-tree build make runs in the build directory, where none of the tracked files exist, and the internal diff-index HEAD behind --dirty reports every tracked file as deleted. GITVERSION and GITBRANCH never touch the work tree, so only the dirty check was wrong. Change All three git commands now get --work-tree $(srcdir): - GITTAG="git --git-dir \$(srcdir)/.git describe --all --always --dirty" + GITTAG="git --git-dir \$(srcdir)/.git --work-tree \$(srcdir) describe --all --always --dirty" The semantics of -dirty are preserved: a genuinely modified source tree still reports -dirty, and in-tree builds are unchanged because $(srcdir) is .. Testing Out-of-tree build from a clean checkout: ./python -VV reports heads/main: instead of heads/main-dirty:. With an uncommitted change to a tracked file in the source tree, the rebuild correctly reports heads/main-dirty: again. In-tree build: the git commands resolve to the same values as before ($(srcdir) is .). git state checks / make regen-configure produce no further diff in configure, pyconfig.h.in or aclocal.m4. Issue Issue: gh-159440

Open Graph Description: Summary The GITTAG build stamp uses git --git-dir $(srcdir)/.git describe --all --always --dirty. --git-dir does not imply a work tree, so git falls back to the current directory. In an out-of-tree...

X Description: Summary The GITTAG build stamp uses git --git-dir $(srcdir)/.git describe --all --always --dirty. --git-dir does not imply a work tree, so git falls back to the current directory. In an out-of-tree...

Opengraph URL: https://github.com/python/cpython/pull/159442

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4e374d26-556a-b783-99a3-2066e48ffc87
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F50:2A16C9:135041D:19A50CB:6AFEAEFE
html-safe-nonce93be3dc9718eb1ef4e5071400a7aeea0272c816e0374d98dedc84557cb8f6900
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjUwOjJBMTZDOToxMzUwNDFEOjE5QTUwQ0I6NkFGRUFFRkUiLCJ2aXNpdG9yX2lkIjoiNDc3OTUxODc5NTA5NTkxMjE5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf59f8c8bb8e045d1d37bbf5601e317f1ec72f13d72a093d429d76a19f49941da
hovercard-subject-tagpull_request:4867687862
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159442/files
twitter:imagehttps://avatars.githubusercontent.com/u/24123821?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24123821?s=400&v=4
og:image:altSummary The GITTAG build stamp uses git --git-dir $(srcdir)/.git describe --all --always --dirty. --git-dir does not imply a work tree, so git falls back to the current directory. In an out-of-tree...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159442/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159442%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159442%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159442/files
Reloadhttps://github.com/python/cpython/pull/159442/files
Reloadhttps://github.com/python/cpython/pull/159442/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
itamarohttps://github.com/itamaro
python:mainhttps://github.com/python/cpython/tree/main
sendaoYan:issue-159440-dirtyhttps://github.com/sendaoYan/cpython-ysd/tree/issue-159440-dirty
Conversation 4 https://github.com/python/cpython/pull/159442
Commits 1 https://github.com/python/cpython/pull/159442/commits
Checks 63 https://github.com/python/cpython/pull/159442/checks
Files changed https://github.com/python/cpython/pull/159442/files
Please reload this pagehttps://github.com/python/cpython/pull/159442/files
gh-159440: Pass --work-tree to the git commands used for the version tag https://github.com/python/cpython/pull/159442/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/159442/files
c95ebcc gh-159440: Pass --work-tree to the git commands used for the version tag sendaoYan Oct 15, 2026 https://github.com/python/cpython/pull/159442/commits/c95ebccf7a7ef0e9a40edd6e158c30a487abe859
Clear filters https://github.com/python/cpython/pull/159442/files
Please reload this pagehttps://github.com/python/cpython/pull/159442/files
Please reload this pagehttps://github.com/python/cpython/pull/159442/files
2026-10-15-11-20-48.gh-issue-159440.uIz6ms.rst https://github.com/python/cpython/pull/159442/files#diff-0e6a5a3e93b5b1e42955dca4143f23e498c883a3ef04c76646e4f5e3c3eba085
configure https://github.com/python/cpython/pull/159442/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.ac https://github.com/python/cpython/pull/159442/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
Misc/NEWS.d/next/Build/2026-10-15-11-20-48.gh-issue-159440.uIz6ms.rsthttps://github.com/python/cpython/pull/159442/files#diff-0e6a5a3e93b5b1e42955dca4143f23e498c883a3ef04c76646e4f5e3c3eba085
View file https://github.com/sendaoYan/cpython-ysd/blob/c95ebccf7a7ef0e9a40edd6e158c30a487abe859/Misc/NEWS.d/next/Build/2026-10-15-11-20-48.gh-issue-159440.uIz6ms.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159442/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L84
configurehttps://github.com/python/cpython/pull/159442/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
View file https://github.com/sendaoYan/cpython-ysd/blob/c95ebccf7a7ef0e9a40edd6e158c30a487abe859/configure
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/159442/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L84
configure.achttps://github.com/python/cpython/pull/159442/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
View file https://github.com/sendaoYan/cpython-ysd/blob/c95ebccf7a7ef0e9a40edd6e158c30a487abe859/configure.ac
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159442/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159442/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/pull/159442/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
Please reload this pagehttps://github.com/python/cpython/pull/159442/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.