René's URL Explorer Experiment


Title: gh-142782: Fix use-after-free in the zoneinfo strong cache by tonghuaroot · Pull Request #159441 · python/cpython · GitHub

Open Graph Title: gh-142782: Fix use-after-free in the zoneinfo strong cache by tonghuaroot · Pull Request #159441 · python/cpython

X Title: gh-142782: Fix use-after-free in the zoneinfo strong cache by tonghuaroot · Pull Request #159441 · python/cpython

Description: find_in_strong_cache() compares the lookup key against each cached key with PyObject_RichCompareBool(). A str subclass whose __eq__ calls ZoneInfo.clear_cache() frees the node being compared, and the traversal then dereferences the freed node (gh-142782). This keeps a reference to the node key during the comparison, and bumps a strong_cache_version counter on every strong-cache mutation; if the version changes during a comparison, the lookup returns a miss instead of touching a possibly-freed node. This also addresses the false-negative / duplicate concern raised on the issue. Verified under ./configure --with-address-sanitizer: the reproducer and the new test_strong_cache_reentrant_clear crash without the fix and are clean with it; the full test_zoneinfo suite passes.

Open Graph Description: find_in_strong_cache() compares the lookup key against each cached key with PyObject_RichCompareBool(). A str subclass whose __eq__ calls ZoneInfo.clear_cache() frees the node being compared, and t...

X Description: find_in_strong_cache() compares the lookup key against each cached key with PyObject_RichCompareBool(). A str subclass whose __eq__ calls ZoneInfo.clear_cache() frees the node being compared, and t...

Opengraph URL: https://github.com/python/cpython/pull/159441

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2aa5ca90-af63-d18e-a4b1-3239aa881404
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9808:3B07B3:8183FD:A25A9C:6B0212A6
html-safe-nonce9f5b9ffced1bd1d5a656094b7df6ff3c1a482d28e34ab37d06aa1043c130bd43
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODA4OjNCMDdCMzo4MTgzRkQ6QTI1QTlDOjZCMDIxMkE2IiwidmlzaXRvcl9pZCI6IjI1NjkwODc5MjA3MDAxNzcwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7e092005aa58cfb68ce1bbda1c6b4a752c3e919802e7c92af8a664d10e2ff994
hovercard-subject-tagpull_request:4867546354
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159441/files
twitter:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
og:image:altfind_in_strong_cache() compares the lookup key against each cached key with PyObject_RichCompareBool(). A str subclass whose __eq__ calls ZoneInfo.clear_cache() frees the node being compared, and t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159441/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159441%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159441%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159441/files
Reloadhttps://github.com/python/cpython/pull/159441/files
Reloadhttps://github.com/python/cpython/pull/159441/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
tonghuaroothttps://github.com/tonghuaroot
python:mainhttps://github.com/python/cpython/tree/main
tonghuaroot:zoneinfo-strong-cache-reentrant-uafhttps://github.com/tonghuaroot/cpython/tree/zoneinfo-strong-cache-reentrant-uaf
Conversation 13 https://github.com/python/cpython/pull/159441
Commits 4 https://github.com/python/cpython/pull/159441/commits
Checks 57 https://github.com/python/cpython/pull/159441/checks
Files changed 3 https://github.com/python/cpython/pull/159441/files
gh-142782: Fix use-after-free in the zoneinfo strong cache https://github.com/python/cpython/pull/159441/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/159441/files
e553c8a gh-142782: Fix use-after-free in the zoneinfo strong cache tonghuaroot Oct 15, 2026 https://github.com/python/cpython/pull/159441/commits/e553c8a1c17509fa56c9cfdb2bdfb068ac8ae98e
b7c45b6 Trim comments tonghuaroot Oct 15, 2026 https://github.com/python/cpython/pull/159441/commits/b7c45b64fdf2fa0155360f0d3e9ce251371e9852
8b10008 Assert the returned zone in the regression test tonghuaroot Oct 15, 2026 https://github.com/python/cpython/pull/159441/commits/8b10008babf517ec0b9ec7726116b7f9a328c66c
02994eb gh-142782: Retry the strong-cache scan after reentrant mutation tonghuaroot Oct 22, 2026 https://github.com/python/cpython/pull/159441/commits/02994eb4d667a5f1c27be43ff25057c403e190d3
Clear filters https://github.com/python/cpython/pull/159441/files
Please reload this pagehttps://github.com/python/cpython/pull/159441/files
Please reload this pagehttps://github.com/python/cpython/pull/159441/files
test_zoneinfo.py https://github.com/python/cpython/pull/159441/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
2026-10-15-09-30-00.gh-issue-142782.z1Uaf7.rst https://github.com/python/cpython/pull/159441/files#diff-dd23572bc6a4781aeddba14ea4e9f82c23f8012e24fca7ef7a8dced050dec01f
_zoneinfo.c https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L431
Lib/test/test_zoneinfo/test_zoneinfo.pyhttps://github.com/python/cpython/pull/159441/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
View file https://github.com/tonghuaroot/cpython/blob/02994eb4d667a5f1c27be43ff25057c403e190d3/Lib/test/test_zoneinfo/test_zoneinfo.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159441/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159441/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
https://github.com/python/cpython/pull/159441/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
Misc/NEWS.d/next/Library/2026-10-15-09-30-00.gh-issue-142782.z1Uaf7.rsthttps://github.com/python/cpython/pull/159441/files#diff-dd23572bc6a4781aeddba14ea4e9f82c23f8012e24fca7ef7a8dced050dec01f
View file https://github.com/tonghuaroot/cpython/blob/02994eb4d667a5f1c27be43ff25057c403e190d3/Misc/NEWS.d/next/Library/2026-10-15-09-30-00.gh-issue-142782.z1Uaf7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159441/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L436
Modules/_zoneinfo.chttps://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
View file https://github.com/tonghuaroot/cpython/blob/02994eb4d667a5f1c27be43ff25057c403e190d3/Modules/_zoneinfo.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159441/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
pgansslehttps://github.com/pganssle
Oct 21, 2026https://github.com/python/cpython/pull/159441/files#r4342036009
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/159441/files
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
https://github.com/python/cpython/pull/159441/files#diff-7a27d869df7929eb9c160f1e309e0a00d7059cc81fa7613464c499d775dc0562
Please reload this pagehttps://github.com/python/cpython/pull/159441/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.