René's URL Explorer Experiment


Title: gh-159312: Resolve CPU attribution from collected stacks by pablogsal · Pull Request #159328 · python/cpython · GitHub

Open Graph Title: gh-159312: Resolve CPU attribution from collected stacks by pablogsal · Pull Request #159328 · python/cpython

X Title: gh-159312: Resolve CPU attribution from collected stacks by pablogsal · Pull Request #159328 · python/cpython

Description: CPU mode can attribute samples to a suspended stack when another thread state uses the same native thread. Use the binding status and stacks already collected to prefer a bound, nonempty stack. Preserve the existing attribution when no such stack is present, including native work after a callback deletes or empties its temporary state. Only samples containing an unbound stack run the local filter. It uses a temporary set and two passes over the collected results, with no additional remote reads or OS thread-status queries. Ordinary bound-state samples add only local checks. The regression uses the existing test helper. External-inspection and profiling tests pass on regular and free-threaded debug builds, with 547 tests on each; the regression also passes reference-leak checks. Linux syscall counts match the original code for ordinary, duplicate-state, and callback-return samples, with frame caching on and off. In cached ALL-mode debug measurements, median sample times were 6.14 to 6.09 microseconds for ordinary sampling, 19.85 to 20.31 for duplicate states, and 29.00 to 29.56 after a callback. The unusual cases still incur local filtering work. Issue: gh-159312

Open Graph Description: CPU mode can attribute samples to a suspended stack when another thread state uses the same native thread. Use the binding status and stacks already collected to prefer a bound, nonempty stack. Pre...

X Description: CPU mode can attribute samples to a suspended stack when another thread state uses the same native thread. Use the binding status and stacks already collected to prefer a bound, nonempty stack. Pre...

Opengraph URL: https://github.com/python/cpython/pull/159328

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1e3b40c3-4a25-6b86-7953-5868ef924fd4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9446:2E124E:448E3CC:57655D5:6B0244FE
html-safe-nonce072e89897c2e60942e5a730ebeb28ccff62033630d05ecfa0c9fca2c3b625d44
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDQ2OjJFMTI0RTo0NDhFM0NDOjU3NjU1RDU6NkIwMjQ0RkUiLCJ2aXNpdG9yX2lkIjoiNTE1NzMwNjg1MDA1MTUwNzQ1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceffd7fd539d52c1ae531586d53297626ac19c22fda8b105286bea6812c1bfa8e
hovercard-subject-tagpull_request:4846211478
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/159328/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altCPU mode can attribute samples to a suspended stack when another thread state uses the same native thread. Use the binding status and stacks already collected to prefer a bound, nonempty stack. Pre...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/159328/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159328%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F159328%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/159328/files
Reloadhttps://github.com/python/cpython/pull/159328/files
Reloadhttps://github.com/python/cpython/pull/159328/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:fix-159312-cpu-tstatehttps://github.com/pablogsal/cpython/tree/fix-159312-cpu-tstate
Conversation 0 https://github.com/python/cpython/pull/159328
Commits 3 https://github.com/python/cpython/pull/159328/commits
Checks 52 https://github.com/python/cpython/pull/159328/checks
Files changed https://github.com/python/cpython/pull/159328/files
Please reload this pagehttps://github.com/python/cpython/pull/159328/files
gh-159312: Resolve CPU attribution from collected stacks https://github.com/python/cpython/pull/159328/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/159328/files
ecac33a gh-159312: Prefer bound stacks for CPU sample attribution pablogsal Oct 13, 2026 https://github.com/python/cpython/pull/159328/commits/ecac33a6d4aadb44e8abbf7d4068dc94a9a39093
35b3947 gh-159312: Confine CPU attribution checks to unbound states pablogsal Oct 13, 2026 https://github.com/python/cpython/pull/159328/commits/35b39478b4bb60fe3eb3acbc5b874c6eb13418f2
17efadc gh-159312: Resolve CPU attribution from collected stacks pablogsal Oct 15, 2026 https://github.com/python/cpython/pull/159328/commits/17efadc87051ff6aa7d046ded05d8b2b824127d8
Clear filters https://github.com/python/cpython/pull/159328/files
Please reload this pagehttps://github.com/python/cpython/pull/159328/files
Please reload this pagehttps://github.com/python/cpython/pull/159328/files
test_external_inspection.py https://github.com/python/cpython/pull/159328/files#diff-e23d1425a6f43944cb282709edbeacfa2398f4cd4c109e59dd49366dac46f2d7
2026-10-13-18-00-00.gh-issue-159312.Lk3w9a.rst https://github.com/python/cpython/pull/159328/files#diff-d0f33b235a70bcddc4ed5c66c272bceecc09209310a7fb01580429a70aba484d
_remote_debugging.h https://github.com/python/cpython/pull/159328/files#diff-a6ce0bef7825b17047f05fdec7aa610bc1d2d2b368e72b6871a79c3b1d2dfaf9
module.c https://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
threads.c https://github.com/python/cpython/pull/159328/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
Lib/test/test_external_inspection.pyhttps://github.com/python/cpython/pull/159328/files#diff-e23d1425a6f43944cb282709edbeacfa2398f4cd4c109e59dd49366dac46f2d7
View file https://github.com/python/cpython/blob/17efadc87051ff6aa7d046ded05d8b2b824127d8/Lib/test/test_external_inspection.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159328/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159328/files#diff-e23d1425a6f43944cb282709edbeacfa2398f4cd4c109e59dd49366dac46f2d7
https://github.com/python/cpython/pull/159328/files#diff-e23d1425a6f43944cb282709edbeacfa2398f4cd4c109e59dd49366dac46f2d7
https://github.com/python/cpython/pull/159328/files#diff-e23d1425a6f43944cb282709edbeacfa2398f4cd4c109e59dd49366dac46f2d7
https://github.com/python/cpython/pull/159328/files#diff-e23d1425a6f43944cb282709edbeacfa2398f4cd4c109e59dd49366dac46f2d7
Misc/NEWS.d/next/Library/2026-10-13-18-00-00.gh-issue-159312.Lk3w9a.rsthttps://github.com/python/cpython/pull/159328/files#diff-d0f33b235a70bcddc4ed5c66c272bceecc09209310a7fb01580429a70aba484d
View file https://github.com/python/cpython/blob/17efadc87051ff6aa7d046ded05d8b2b824127d8/Misc/NEWS.d/next/Library/2026-10-13-18-00-00.gh-issue-159312.Lk3w9a.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159328/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L336
Modules/_remote_debugging/_remote_debugging.hhttps://github.com/python/cpython/pull/159328/files#diff-a6ce0bef7825b17047f05fdec7aa610bc1d2d2b368e72b6871a79c3b1d2dfaf9
View file https://github.com/python/cpython/blob/17efadc87051ff6aa7d046ded05d8b2b824127d8/Modules/_remote_debugging/_remote_debugging.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159328/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159328/files#diff-a6ce0bef7825b17047f05fdec7aa610bc1d2d2b368e72b6871a79c3b1d2dfaf9
https://github.com/python/cpython/pull/159328/files#diff-a6ce0bef7825b17047f05fdec7aa610bc1d2d2b368e72b6871a79c3b1d2dfaf9
https://github.com/python/cpython/pull/159328/files#diff-a6ce0bef7825b17047f05fdec7aa610bc1d2d2b368e72b6871a79c3b1d2dfaf9
https://github.com/python/cpython/pull/159328/files#diff-a6ce0bef7825b17047f05fdec7aa610bc1d2d2b368e72b6871a79c3b1d2dfaf9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L336
Modules/_remote_debugging/module.chttps://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
View file https://github.com/python/cpython/blob/17efadc87051ff6aa7d046ded05d8b2b824127d8/Modules/_remote_debugging/module.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159328/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
https://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
https://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
https://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
https://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
https://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
https://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
https://github.com/python/cpython/pull/159328/files#diff-9676fd8cee6e0d841f42f405a8e33a434fbebbc861207051571c97cef17c4108
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L336
Modules/_remote_debugging/threads.chttps://github.com/python/cpython/pull/159328/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
View file https://github.com/python/cpython/blob/17efadc87051ff6aa7d046ded05d8b2b824127d8/Modules/_remote_debugging/threads.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/159328/{{ revealButtonHref }}
https://github.com/python/cpython/pull/159328/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
https://github.com/python/cpython/pull/159328/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
https://github.com/python/cpython/pull/159328/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
https://github.com/python/cpython/pull/159328/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
Please reload this pagehttps://github.com/python/cpython/pull/159328/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.